Commit Graph

818 Commits

Author SHA1 Message Date
Bryan Housel
d2687d9068 pacify eslint 2018-11-26 22:13:38 -05:00
Bryan Housel
822917466c Display name suggestion presets on 2 lines
(closes #5514)
2018-11-26 21:55:13 -05:00
Bryan Housel
7170e93b39 Adjust tooltip 2018-11-26 17:35:38 -05:00
Bryan Housel
df91eb2959 Cleanup style, make sure multilingual fields always render 2018-11-26 17:13:55 -05:00
Bryan Housel
9341e477a6 Merge remote-tracking branch 'origin/master' into brand-name-protection 2018-11-26 15:27:56 -05:00
Bryan Housel
f6f146f79b Lock down some fields when a brand preset has been chosen 2018-11-26 15:13:40 -05:00
Quincy Morgan
b3e71c7522 Manual removal of the hover-highlight styling when clicking on a relation or member in the sidebar.
Closes #5521
2018-11-25 18:15:33 -05:00
Bryan Housel
ae063e9616 Make name and brand fields readonly on suggestion presets
(re #5515)
2018-11-23 23:44:52 -05:00
Quincy Morgan
e2b2649976 Merge pull request #5498 from quincylvania/form-field-flexbox
Flexbox preset field, member, and membership UI
2018-11-21 20:14:36 -05:00
Bryan Housel
ea9e3008a5 addTags() -> setTags() / removeTags() -> unsetTags()
This avoids overriding the `addTags` and `removeTags` objects with functions
2018-11-21 12:59:43 -05:00
Bryan Housel
2699418c3e Disable the name field when matching a suggestion preset
(re: #5515)
2018-11-21 12:40:12 -05:00
Bryan Housel
622621ca89 Improve suggestion combo behavior in the name field
- adds minItems(1) so it will match
- displays up to 10 suggestions
- correctly removes old tags by setting the `undefined`
- adjust the name distance scoring
- only shows name suggestions if the preset can benefit from them
  (i.e. a generic/fallback or a preset that has some suggestions in the index)
2018-11-21 11:15:03 -05:00
Bryan Housel
e3f5aecda9 Remove dataSuggestions and utilSuggestNames
- dataSuggestions was just a reexport of the name-suggestion-index
- utilSuggestNames was a combobox fetcher function used only once by uiFieldLocalized
    Doesn't need to be a util if it's only used once in the code
    and the tests for it were not really that interesting
2018-11-20 21:27:32 -05:00
Quincy Morgan
7bad67ff76 Flexbox preset field, member, and membership UI 2018-11-18 11:28:48 -05:00
Bryan Housel
b7e218a6cb Remap Safari gesture events to wheel events - #5492
(still needs some more testing)
2018-11-17 02:31:15 -05:00
Bryan Housel
152022aec4 Use context.keybinding for keybindings that don't change
(closes #5487)
2018-11-13 20:57:21 -05:00
Bryan Housel
bb30cbf555 Move lib/d3.keybinding.js -> util/keybinding.js
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
Bryan Housel
4a3d5e2316 Avoid reflow caused by restriction editor checking its dimensions 2018-11-10 00:40:45 -05:00
Bryan Housel
3bc841e95b Adjust layer ordering to draw touch targets above data layers 2018-11-09 21:48:45 -05:00
Bryan Housel
509464c932 Don't allow user to toggle sidebar in the walkthrough
(this would mess up all the tooltips)
2018-11-08 14:07:06 -05:00
Bryan Housel
826e08149b Setup data layers before starting the walkthrough
(closes #5136)
2018-11-08 13:53:13 -05:00
Bryan Housel
a73a75d1d3 Adjust initialization order so that map has dimensions before hash()
This fixes a weird regression where the hash would try to centerzoom the map,
but the map did not yet have dimensions, so the center would end up in the top-left.
2018-11-08 11:15:26 -05:00
Bryan Housel
a1dbdea725 Merge branch 'master' into flexbox-buttons 2018-11-07 10:13:40 -05:00
Bryan Housel
42aa834fab Avoid obscuring selected entity when expanding the sidebar 2018-11-06 17:03:58 -05:00
Bryan Housel
cc227ed4e2 Make map panning optional on sidebar expand/collapse 2018-11-06 16:06:45 -05:00
Bryan Housel
e31e84b109 Simplify some things I found confusing
- class the #sidebar itself as collapsed not the #id-container
- the #sidebar is the selection, so just use `selection` instead of
  `var sidebar = d3_select('#sidebar');`
  (which conflicts with the closure `sidebar()` function)
- have separate functions `expand` `collapse` `toggle` rather than a
  `toggle(shouldCollapse)`
2018-11-06 15:08:05 -05:00
Bryan Housel
3d65dd8903 preventDefault on sourceEvent, if present
This prevents a crash when d3_event is not the actual event, but is a
transition event or similar
2018-11-06 14:16:23 -05:00
Bryan Housel
08e9476f3e Fix photoviewer resize event 2018-11-06 13:09:04 -05:00
Bryan Housel
b4119ae1ad Class toolbars with narrow if we detect overflow happening
Also add css rules to drop labels from toolbar buttons if needed
2018-11-05 17:16:50 -05:00
Bryan Housel
136e4556a7 Move spinner to flex-end, and some css cleanups 2018-11-05 12:22:20 -05:00
Quincy Morgan
dcc654f269 Merge pull request #5467 from quincylvania/tag-row-flexbox
Keeps the raw tag editor buttons fixed-width using flexbox
2018-11-04 13:07:20 -08:00
Quincy Morgan
5a2444ed40 Converts == to === in the prior commit 2018-11-04 12:42:04 -08:00
Quincy Morgan
3ff1139364 Fixes an error where preventDefault would be called on an event object without that function 2018-11-04 12:40:59 -08:00
Quincy Morgan
1db80ff49c Adds missing semicolon 2018-11-04 12:06:32 -08:00
Quincy Morgan
f4a64c27a4 Keeps the raw tag editor buttons fixed-width using flexbox 2018-11-04 11:55:29 -08:00
Bryan Housel
c1d28d9333 Wrap sidebar button in div, so the .tool-group > div rule pads it 2018-11-03 00:11:10 -04:00
Bryan Housel
d4e31a82e3 Adjust sidebar resizer to keep map still by anti-panning 2018-11-02 23:21:59 -04:00
Bryan Housel
aecbaec896 Add key to toggle the sidebar 2018-11-02 11:15:52 -04:00
Bryan Housel
26e63d64e3 Flexbox buttons in top bar
- Makes the "Sidebar" toggle button permanent but removes the label
- Did some things to the "Save" button to make it the same width whether there
  is a count or not (prevents the buttons from jumping when pressing undo/redo)
- Removes a lot of the floated col rules that aren't used much anymore
2018-11-01 23:42:26 -04:00
Quincy Morgan
a0b0337ab4 - The sidebar can be now be resized by dragging the divider (closes #3447)
- Dragging the sidebar below a minimum size collapses it
- A button in the top toolbar lets you uncollapse the sidebar, complete with icon and tooltip
- Double-clicking the divider toggles the sidebar collapse
- Collapse-toggling is animated
- Selecting a feature or ending an add-feature mode auto-opens the sidebar
- Photoviewer UI has been moved from init.js to photoviewer.js
- The photoviewer now has a slight margin to set it away from the sidebar
- The undo/redo, save, and progress indicator controls are now floated to the right
- The save count has been redesigned to visually integrate with the save button
- When the sidebar is collapsed, the mode buttons are centered
- Full right-to-left layout support for all of the above
2018-10-27 17:05:50 -07:00
Bryan Housel
05709565f0 Merge pull request #5429 from quincylvania/relation-membership-highlighting
Adds hover-highlighting for relations in the raw membership list
2018-10-27 14:24:50 -04:00
n42k
bc0ec1f380 Fixed using help's navigation buttons not resetting the help pane to the top. 2018-10-27 16:21:59 +01:00
Quincy Morgan
1161767932 Moves the entity highlighting function to util/util.js
Breaks out the code for getting a selector for entities and all their descendants into a generic function
Accounts for circular relations when recursively getting all relation member IDs
2018-10-26 18:39:01 -07:00
Quincy Morgan
51386e03ae Restores the hover-highlight comment in selection_list.js 2018-10-24 22:30:29 -07:00
Quincy Morgan
ddb6e1b119 Fixes comments related to hover-highlighting 2018-10-24 22:27:37 -07:00
Quincy Morgan
81feb1cd99 Adds hover-highlighting for relations in the raw membership list
Moves hover-highlighting behavior to its own function
Hover-highlighting now correctly highlights all members of the target relation
2018-10-24 22:17:28 -07:00
Quincy Morgan
169a92df7c Fixes label button wrap on right-to-left layouts 2018-10-15 21:20:44 -07:00
Quincy Morgan
ffe38c7975 Adds a button to the relation member list item for zooming to the feature without selecting it
Adds "remove" tooltip to the delete relation member button
2018-10-15 20:41:45 -07:00
Quincy Morgan
aeed2cc29f Adds the same hover highlighting to the selected features list as the relation members list 2018-10-14 18:31:30 -07:00
Quincy Morgan
b24256973f Makes relation members highlighted via hovering on list items more prominent 2018-10-13 23:04:35 -07:00