Commit Graph

13 Commits

Author SHA1 Message Date
SilentSpike 51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike 406264c37e Simplify structure of QA error data 2020-02-03 23:20:42 +00:00
Bryan Housel bb0a47b255 Remove kr and keepRight for styles used generically
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
Bryan Housel e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
SilentSpike 781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
Bryan Housel 7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
SilentSpike 20ed8b50c9 Add generic QA error
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.

Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
SilentSpike 183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00
SilentSpike 54e02ec28d Introduce new container icon for errors
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.

I learned quite a bit about SVGs and using them in HTML while
implementing this 😝Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
SilentSpike 214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike 9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike 23a4d71410 Handle turn restriction errors 2019-02-01 22:50:55 +00:00
SilentSpike 4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00