5091966056
[WIP] add string length indicator and max-length message
2022-11-25 17:48:33 +01:00
56e92e661c
split function branches to reduce complexity
2022-11-08 13:55:28 +01:00
5f1360ed0f
don't suggest to "connect the ends" if a feature with area tags matches a line preset
...
For example, when a feature tagged as `highway=primary` (line preset) and `man_made=bridge` (area preset) is mapped as an unclosed way, converting it to an area (by closing the way by connecting the endpoints) does not improve the situation, as then the other tag doesn't fit to the geometry anymore.
closes #7037
2022-11-04 12:23:15 +01:00
097c6bd774
skip unsupported/invalid restrictions instead of fallback to "no_*"
...
closes #9337 (at least kind of… for a proper solution see #6460 )
2022-10-27 18:36:05 +02:00
81f3b0666c
support incrementing cardinal directions with the 🔼 / 🔽 buttons ( #9141 )
2022-07-15 16:48:47 +02:00
e9759bd425
treat chipseal as a paved surface ( #9139 )
2022-06-09 18:20:08 +02:00
724462ec47
consider lifecycle prefixes in osmTagSuggestingArea ( #8881 )
2022-06-06 15:56:31 +02:00
04a07092d2
Handle more "hybrid" area+line tags as area-by-default, fixes #8985
2022-02-16 15:56:28 +01:00
35e528946d
seamark:type=separation_lane implies oneway
2022-01-07 18:05:26 +13:00
7a1d08f80e
Return the empty string when calling toOSM() on entities with test IDs
2021-12-06 21:25:22 +01:00
1457759994
Add support for connectivity relations
2021-09-08 20:30:38 -07:00
3d24736b8f
trailing spaces
2021-08-05 17:36:48 +02:00
750b4e023f
crossing_ways fixing - specially handle crossing nodes
2021-08-05 14:50:38 +02:00
3665f80d46
Also include operator:wikidata as a wikidata tag
...
osmEntity#hasWikipedia was only used by the suspicious_name validator
2021-01-29 11:11:59 -05:00
ba48a861bc
Enable curly and block-spacing eslint rules
2020-11-10 14:19:11 -05:00
d247ec3aed
Enable brace-style eslint rule
2020-11-10 13:49:48 -05:00
15c8e060f8
Fix tests
2020-10-23 15:49:30 -04:00
f2ef27f78c
Enable no-implicit-coercion eslint rule for strings
2020-10-23 14:03:50 -04:00
3f9ac9105b
Enable no-undef-init eslint rule
2020-10-23 11:33:47 -04:00
f8e4e43fab
Enable additional eslint rules, including no-constructor-return
2020-10-23 11:11:32 -04:00
7ab7e4ffe0
Don't warn about deprecated tags that would overwrite existing data when upgraded ( close #7843 )
2020-10-21 11:58:00 -04:00
b42dec741b
Followup to #8083
2020-10-21 09:51:36 -04:00
90d3f59aa6
Remove some unneeded variables.
...
These should theoretically actually slow down the JIT (if very marginally) so performance-wise it's better not to have them.
2020-10-14 19:00:10 +01:00
4ddd4a358b
Deprecate vending=parcel_mail_in;parcel_pickup -> vending=parcel_pickup;parcel_mail_in ( close #7988 )
...
Enable upgrading of entire semicolon-delimited values
2020-09-28 16:07:11 -04:00
c940d827e6
Enable the Split operation for multiple selected nodes ( close #7990 )
2020-09-24 15:13:05 -04:00
5ddcfb0ced
Add parameter to specify which way should keep the history when splitting ways (re: #7795 )
...
Fix code tests
2020-09-14 11:27:20 -04:00
4205ca1d07
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
(cherry picked from commit 2c47a11008
2020-08-10 17:32:37 +01:00
d179f791a9
Significantly improve the performance of the crossing_ways validation in areas with long ways ( close #7656 )
2020-06-22 16:49:32 -04:00
fd180ff60c
Improve performance somewhat in some scenarios (re: #7656 )
2020-06-22 13:35:51 -04:00
05d357159d
Add implied oneway logic info for man_made=goods_conveyor
2020-06-09 17:55:17 -04:00
762307bd7d
Restrict key, value, and role character limits based on unicode characters, not UTF-16 code units (re: #6817 )
2020-06-09 15:41:15 -04:00
85ce071704
Render "semi-paved" roads like cobblestone, paving stones, and wood with a solider line than unpaved roads ( close #7466 )
2020-03-26 19:26:29 -07:00
5125c04a58
Fix issue where merging a point matching a fallback preset into an area could discard tag values ( close #7446 )
2020-03-23 12:47:14 -07:00
3ee32776a7
Fix QA error icons
...
Pass service itself in to QAItem constructor for purpose of fetching
data. Store string as `title` property on the service.
2020-02-12 21:27:38 +00:00
a9a1f945f8
Move the qa_data external
...
- this means that QAItem now asks the service for the icon rather than knowing it directly
2020-02-07 10:06:47 -05:00
51efd5b714
Update and standardise QA implementations
...
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible
Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
406264c37e
Simplify structure of QA error data
2020-02-03 23:20:42 +00:00
567eeac587
Make several data external instead of bundled:
...
Also dist/data/* contains minified files now
These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
17ae12b3d7
Address most common places where tag keys or values could exceed the 255 character API limit ( close #6817 )
2020-01-27 15:57:55 -05:00
45d22261fc
Don't leave an extra junction segment when the end node of the crossing edge is only the endpoint of two lines (re: #7202 )
...
Make the length of added crossing structures much closer to the intended spherical length
2020-01-16 17:55:13 -05:00
5011039087
Clarify some variable names in osmEntity.deprecatedTags and add more code tests
2020-01-09 09:49:31 -05:00
09ad21a26f
Improve "add a bridge/tunnel" fixes by basing the structure length on the crossed feature type, not a fixed constant (re: #7202 )
2020-01-08 12:03:30 -05:00
1049c338c6
Add waterway=tidal_channel preset ( close #7232 )
2020-01-07 10:14:43 -05:00
31941e9389
Fix JavaScript error that could cause validation warnings to appear unexpectedly ( close #7166 )
...
Add code test to account for deprecated tags with no replacement
2019-12-31 12:03:57 -05:00
93ff34dc39
Add preset for waterway=fish_pass
2019-12-17 13:22:05 -05:00
81b561fffc
Don't close unclosed multipolygon parts with fewer than three nodes when generating geojson
...
Update multipolygon geojson code tests
2019-11-22 17:01:51 -05:00
d0c5add378
Update some variable names to not be misleading
2019-11-22 14:43:16 -05:00
4b9b0860bf
Fix incomplete rendering of unclosed multipolygon rings ( close #2945 )
2019-11-22 13:09:46 -05:00
1f5cce9bdd
Don't treat source_ref subtags as descriptive tags
2019-11-18 15:49:32 -05:00
b2611a941c
Don't treat various source tags as descriptive tags
2019-11-18 15:43:46 -05:00
Martin Raifer