Commit Graph

2402 Commits

Author SHA1 Message Date
Martin Raifer
fa501696e5 fix false-positive missing translation, for street+place subfield
closes #10812
2025-02-24 15:33:43 +01:00
Kyℓe Hensel
8659416af2 Fix duplicate values in the source field on the changeset page (#10799) 2025-02-22 09:57:18 +01:00
Martin Raifer
fb22f01b30 allow # (full width number sign) as alternative # sign for hashtags
this appears to be somewhat common in some asian scripts, resulting in unrecognized hashtags or superfluous "#" in `hashtags` changeset tag (e.g. https://stats.now.ohsome.org/dashboard#hashtag=%25EF%25BC%2583missingmaps&start=2007-02-20T23:00:00Z&end=2025-02-21T22:59:59Z&interval=P1M&countries=&topics=).
2025-02-21 18:48:42 +01:00
Kyℓe Hensel
0fc978de45 remove leading semicolon from changeset source (#9887) 2025-02-17 11:13:52 +01:00
Martin Raifer
9b7b0cde9e fix walkthrough from not correctly registering deleted ways
fixes #10776, this was a regression in 7559dea
2025-02-16 11:37:25 +01:00
Kyℓe Hensel
c1ca888b72 linkify keys & tags in the preset docs from the wiki (#10763) 2025-02-12 15:42:29 +01:00
Kyℓe Hensel
33c68064a6 Enable autofill for the source tag in the changeset panel (#10764) 2025-02-12 15:22:50 +01:00
Kyℓe Hensel
bd85d31b73 fix relation membership list using a non-deterministic order (#10648) 2025-02-12 15:16:54 +01:00
Kyℓe Hensel
4747ae253c refactor isOneWay to properly support bidirectional ways (#10730) 2025-02-12 14:22:09 +01:00
Deeptanshu Sankhwar
f7fc707159 Show both lat/lon and lon/lat when searching coordinates (#10725) 2025-02-11 12:50:07 +01:00
dragoon
6575296a85 Use distinct placeholder text for feature type search box (#10734) 2025-02-05 15:31:41 +01:00
Youssef Ahmed Hassan Elzedy
afd6b83edf change icon to "X" for the exit button of feature type selection panel (#10733) 2025-02-05 14:19:18 +01:00
Kyℓe Hensel
2c0f8a4b5f handle cycleway:both=* (#9587)
this works for any `directionalCombo` field, including `sidewalk:both`
2025-02-05 10:41:48 +01:00
Martin Raifer
51ee85f6f5 refresh text-mode raw tag editor also when no tags are changed
e.g. when duplicate tag keys are entered or the text input contained empty or invalid lines that need to be cleaned up
2025-01-31 17:34:42 +01:00
Martin Raifer
bb57d34413 fix: coordinate search result's label should upate while typing 2025-01-31 16:00:31 +01:00
Nick Doiron
6dcc73cf7c Add lang atttribute on multilingual names, wikidata/wikipedia fields (#10716)
This improves rendering of CJK names that contain unified ideographs that share a unicode codepoint, such as 化.
2025-01-31 13:49:49 +01:00
Kyℓe Hensel
561197ea5c remove rarely-used keyboard shortcut L (#9999) 2025-01-30 11:27:50 +01:00
Kyℓe Hensel
add513f39e fix confusing behaviour after logging out in the standalone build of iD (#10683)
when user logs out of osm.org via the logout button: the popup continues to the login screen, which if completed now logs the user back into iD with the new credentials
2025-01-22 17:25:56 +01:00
Martin Raifer
edf41a98d2 allow tiles to be underzoomed slightly in minimap
preventing minimap from blacking out "too soon" on low map zoom, fixes #10653. Closes #10694 and #10680
2025-01-22 17:06:01 +01:00
Kyℓe Hensel
172aeb6e57 fix backspace not working as a keyboard shortcut (#9995) 2025-01-15 12:05:46 +01:00
Kyℓe Hensel
d1b48ece73 fix bug preventing cardinal direction increment (#9932) 2025-01-15 11:31:33 +01:00
Kyℓe Hensel
a585e7f946 fix crash when searching for coordinates (#10679) 2025-01-15 11:10:12 +01:00
Martin Raifer
e0937f34bb also highlight search results when focusing entries using keyboard (tab) 2025-01-11 14:02:30 +01:00
Martin Raifer
415c30e60b fix search results from being stuck in highlighted state
fixes #10661, replaces and closes #10666

See https://github.com/openstreetmap/iD/pull/10666#issuecomment-2585256927 for more details about this fix
2025-01-11 14:02:29 +01:00
Martin Raifer
7559dead80 add missing retries in walkthrough if edit menu is closed accidentally
e.g. for the "delete node" step, when the map is accidentally panned the edit menu will be closed, causing the walkthrough to get stuck
2025-01-10 16:04:55 +01:00
Martin Raifer
8c1fc20311 walkthrough: use left/right tooltips if the anchor is close to the left/right edge of the screen
closes #10634

This happens for example when the tooltip are rendered for the map controlls (right or left edge of the screen depending on user locale): If the anchor is close to the bottom of the screen, the tooltip would be placed not ideally in the corner and hard to read. It is solved by falling back to left/right tooltips with a potentially offset arrow in these cases
2025-01-10 16:01:17 +01:00
Martin Raifer
40a5c32e2f fix misaligned walkthrough mask when supersurface is not at 0/0 origin
closes #10624

The misalignment happens because the origin offset is not properly accounted for boxes around map coordinates, when the map surface is itself offset from the top-left corner of the map. This can happen with customized installations of iD, e.g. the version built into the HOT tasking manager.
2025-01-10 15:13:54 +01:00
Martin Raifer
4ae5e86491 make sure walkthrough tooltip are using the main map surface
fixes bug: if there were extra rendering surfaces loaded, e.g. the one of the turn restriction editor, the walkthrough tooltips and the curresponding masks were inadvertently rendered to that secondary surface, which can be even offscreen
2025-01-10 14:15:49 +01:00
Devin Fahnestock
313022728c prevent map panels from covering up edit menu, fixes #10495 (#10586) 2024-12-13 15:08:50 +01:00
Deeptanshu Sankhwar
9e2f9e0324 add a short reminder for data being objective during the walkthrough, fixes #10566 (#10568) 2024-12-11 15:06:28 +01:00
Martin Raifer
404e08518e use correct margins when limiting photoviewer size, fixes #10558
replaces hardcoded values with dynamically calculated heights/margins.

closes #10563
2024-12-04 13:03:34 +01:00
Deeptanshu Sankhwar
e48aa3c2c4 Ensure correct this context for addMembership function to call the blur method correctly. Fixes #10555 (#10560)
* Pass the  reference explicitly to the  function to ensure the correct context is available.

* refactor: handle blur() in a closure to separate UI logic from addMembership

* spacing

* Fixed typo

---------

Co-authored-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
2024-11-30 22:43:54 -08:00
Minh Nguyễn
6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Kyle Hensel
7afecd39ec minor tweaks to make some tests pass 2024-09-03 19:23:21 +10:00
Martin Raifer
34bb143561 fix undefined translation string, see #10417 2024-08-22 13:54:23 +02:00
Martin Raifer
31bef9f064 fix calculation of non-node feature extents, fixes #10417 2024-08-22 13:52:24 +02:00
Martin Raifer
945fea1dc0 allow to enter strings with quote marks in raw tag editor's text mode (#10371)
and use fully quoted strings for cases which have characters that need to be encoded

old: tag=foo\"bar\" -> new: tag=foo"bar" or tag="foo\"bar\""
old: tag=foo\nbar   -> new: tag="foo\nbar"

falls back to raw tag values if a quoted string cannot be parsed
2024-08-01 15:19:33 +02:00
Martin Raifer
e89121b550 fix vegbilder overlay from being overwritten by panoramax layer 2024-07-31 17:53:33 +02:00
Martin Raifer
9407f309a7 Merge branch 'develop' into panoramax 2024-07-29 15:13:38 +02:00
Martin Raifer
984f25adbb Merge pull request #10046 from laigyu/add-button-to-mapillary
Add a button in the mapillary image photo viewer to "add the current image id as field to feature"
2024-07-16 22:14:21 +02:00
Martin Raifer
d13c202ac0 update "add mapillary tag" button state when tags of the feature change
addresses https://github.com/openstreetmap/iD/pull/10046#pullrequestreview-2176313208
2024-07-16 22:10:08 +02:00
Martin Raifer
42f274f73f move reused regex to exported constant 2024-07-16 17:04:49 +02:00
Sam Ho
43c65bf994 Fix localized field hidden despite nonempty subkeys (Closes#10323) 2024-07-16 12:38:06 +01:00
Martin Raifer
e195947509 Merge branch 'develop' into panoramax 2024-07-12 18:22:53 +02:00
Martin Raifer
7d65b19d6d simplify code 2024-07-12 18:02:14 +02:00
Martin Raifer
1d0f9e6447 lint 2024-07-12 17:53:41 +02:00
Martin Raifer
d9c973b745 disable button when photo is too far from selected feature 2024-07-12 17:49:34 +02:00
Martin Raifer
b604ef8f6f make button work on newly created features; refactor code
code: we should not to not rely on directly manipulating/accessing other components DOM elements
2024-07-12 17:22:03 +02:00
Martin Raifer
6e9d225828 use slightly smaller "plus" icon
(this one is also used in other similar UI locations, e.g. the "add tag" in the raw tags editor, etc.)
2024-07-12 17:20:09 +02:00
mattiapezzotti
a9d8da10d1 prepared for pr 2024-07-12 00:01:05 +02:00