Commit Graph

26 Commits

Author SHA1 Message Date
Bryan Housel e4e0d9d13a Add oneway icon for ImproveOSM oneway markers 2019-02-03 23:55:16 -05:00
SilentSpike 9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
SilentSpike c9e249ee6c Send only relevant query parameters 2019-02-01 23:14:54 +00:00
SilentSpike e9397aa14f Fix incorrect usage of osm.userDetails callback
Javascript is not my usual domain so still getting used to how scope
works and working with callbacks. Believe this code is now written as
intended.

As a bonus a response status to the error update request which isn't the
expected 200 now returns before visibly removing the error and adding it
to the closed cache.
2019-02-01 22:51:05 +00:00
SilentSpike 21824e6377 Fix coincident errors
Potential for multiple missing turn restrictions on one node and I've
also seen a case of missing one-way along the same stretch of road in
opposite directions!

Missing geometry is tile based so can't really be coincident, but
doesn't hurt to check in case they happen to land on a one-way or turn
restriction.
2019-02-01 22:51:04 +00:00
SilentSpike 183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00
SilentSpike d82757c392 Include node in turn restriction description
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike 60128b0402 Fix one-way error positioning and description
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).

The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike 45ce4e4c57 Move turn restriction error position slightly 2019-02-01 22:51:02 +00:00
SilentSpike ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike 5d907c1e16 Render errors like points with icons
This allows more diverse representation of the error subject at a glance
than relying on colour alone.

However, it would be good to have a generic error icon that can contain
icons which is differentiated from the point icon for clarity.

Sidebar header currently still uses the bolt icon until I figure out
how to deal with that. Also the font awesome icons don't seem to work,
perhaps there's additional code needed for those that I've missed.
2019-02-01 22:51:01 +00:00
SilentSpike 4a166d7a5b Use more descriptive key names 2019-02-01 22:51:01 +00:00
SilentSpike 88a59cb15f Stop hijacking the inflight cache
This could result in error updates getting aborted when new errors are
loaded as their individual ids are never going to match tile IDs (see
`abortUnwantedRequests` function).
2019-02-01 22:51:01 +00:00
SilentSpike 3334abf776 Remove some unnecessary code 2019-02-01 22:51:00 +00:00
SilentSpike 31091f1159 Add direction of travel to oneway errors 2019-02-01 22:50:59 +00:00
SilentSpike 6bdd0cfa89 Fix missing semicolons 2019-02-01 22:50:58 +00:00
SilentSpike 3174db76b7 Fix north direction in some error descriptions 2019-02-01 22:50:58 +00:00
SilentSpike 9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike 214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike 39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike 9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike 23a4d71410 Handle turn restriction errors 2019-02-01 22:50:55 +00:00
SilentSpike 4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
SilentSpike 4d89810721 Add ImproveOSM service
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00