Martin Raifer
984f25adbb
Merge pull request #10046 from laigyu/add-button-to-mapillary
...
Add a button in the mapillary image photo viewer to "add the current image id as field to feature"
2024-07-16 22:14:21 +02:00
Martin Raifer
d13c202ac0
update "add mapillary tag" button state when tags of the feature change
...
addresses https://github.com/openstreetmap/iD/pull/10046#pullrequestreview-2176313208
2024-07-16 22:10:08 +02:00
Martin Raifer
42f274f73f
move reused regex to exported constant
2024-07-16 17:04:49 +02:00
Sam Ho
43c65bf994
Fix localized field hidden despite nonempty subkeys (Closes#10323)
2024-07-16 12:38:06 +01:00
Martin Raifer
7d65b19d6d
simplify code
2024-07-12 18:02:14 +02:00
Martin Raifer
1d0f9e6447
lint
2024-07-12 17:53:41 +02:00
Martin Raifer
d9c973b745
disable button when photo is too far from selected feature
2024-07-12 17:49:34 +02:00
Martin Raifer
b604ef8f6f
make button work on newly created features; refactor code
...
code: we should not to not rely on directly manipulating/accessing other components DOM elements
2024-07-12 17:22:03 +02:00
Martin Raifer
6e9d225828
use slightly smaller "plus" icon
...
(this one is also used in other similar UI locations, e.g. the "add tag" in the raw tags editor, etc.)
2024-07-12 17:20:09 +02:00
arch0345
14794ee992
Remove references to ImproveOSM
2024-07-08 17:15:38 -07:00
Martin Raifer
49492a0e06
keep chosen dropdown item if user clicked on one
...
fixes a bug where in case multiple items with the same `value` are present in the combobox' dropdown, always the first one is returned in the `accept` event
2024-06-05 19:56:56 +02:00
Martin Raifer
97d1aa5e2d
Fix address field overwriting existing data when switching features
...
fixes #12060
This bug can occur occasionally under the following circumstances:
* map feature 1 is selected
* the cursor is in an address (sub) field
* map feature 2 gets selected directly
* now, in some cases, the contents of the address fields of feature 2 are written into feature 1's tags
2024-06-05 19:55:51 +02:00
Martin Raifer
99d7a85ab4
Merge remote-tracking branch 'k-yle/highway-ladder' into develop
2024-06-05 12:58:56 +02:00
Martin Raifer
342a03bcfe
allow type/id syntax in id hash param, and add support for notes
2024-05-28 20:18:53 +02:00
Kyle Hensel
c7731f5499
support highway=ladder
2024-05-25 16:25:59 +10:00
Pavel Zbytovský
aa53bbf550
Sort "more fields" dropdown items ( #10181 )
2024-04-25 15:34:39 +02:00
Martin Raifer
5251ee6b65
add new method to reuse localized text span, closes #8994
2024-04-24 17:29:06 +02:00
Martin Raifer
fc4e05601a
reduce unnecessary html injection
2024-04-24 13:53:43 +02:00
laigyu
42691dec9d
fix onclick handler when closing/reopening notes with comment ( #10205 )
2024-04-24 13:49:25 +02:00
laigyu
6a6f30b5a8
fix link button when dragging combo field chips #10153 ( #10209 )
2024-04-24 12:24:52 +02:00
laigyu
904c802587
Merge branch 'openstreetmap:develop' into add-button-to-mapillary
2024-04-17 22:59:27 +08:00
laigyu
b1ff86cd29
tooltip update
2024-04-15 14:54:43 +08:00
Martin Raifer
211b6dde5f
upgrade to eslintv9 (config format, lint to updated rules)
2024-04-12 18:44:04 +02:00
laigyu
2325de4662
update butotn logic
2024-04-12 18:37:26 +08:00
laigyu
6b8b41c2ff
tooltip style change
2024-04-08 18:22:58 +08:00
laigyu
d448b586ed
revert error handler
2024-04-07 23:19:41 +08:00
laigyu
94e32a85b0
revert field button
2024-04-07 22:04:22 +08:00
laigyu
8bb1d0dfa9
Merge remote-tracking branch 'upstream/develop' into add-button-to-mapillary
2024-04-05 13:17:59 +08:00
Hirako
85278c35e4
Field: fix wikiURL by URL encoding it - and slight refactors ( #10165 )
...
* Field: fix wikiURL by URL encoding it - and slight refactors
* Field: fix wikiURL only encodeURIComponent instead of redundant full URL
* Field: refactors function to generate wikiURL, ensures anchor part is also URI encoded, ensures the anchor ref is not encoded, adds unit tests
* Field: refactors wikipedia URI encoding of the anchor logic, removes legacy anchorencode effort via try-catch that replaced percentage character with dots, adds unit further tests, reduces exessive inlining
2024-03-21 00:42:08 -07:00
Asif Sheriff
1683313621
preserve rows with empty tag values in raw tag editor ( #10151 )
2024-03-15 01:13:07 +01:00
Mattia Pezzotti
a75eace135
Fix for Point Tutorial ( #10129 )
2024-03-07 23:38:51 +01:00
Martin Raifer
5d06d3b83e
Merge pull request #10149 from openstreetmap/split-relation-members
...
Robust local splitting of ways which are part of (route) relations
2024-03-06 13:54:14 +01:00
Martin Raifer
d7111e20f5
add button to load a feature's relations fully (if incomplete), fixes #5420
2024-03-05 14:25:16 +01:00
Tobias
b72a089f35
Field: Fix html tag type of wikidata label ( #10144 )
...
The `span` need to be a `div` after https://github.com/openstreetmap/iD/pull/10127/files
2024-03-04 19:25:53 +01:00
Tobias
ce51b33cf2
Improve combobox dropdown styling to give labels more room and readability ( #10127 )
...
* Fields: Break long lines in combo dropdown instead of ellipsis
Longer translations keys are not readable with ellipsis and the tooltip only shows the description (or fallback), not the title.
This change makes long use line breaks with small line height to make the whole text visible.
* Fields: Use table styles for rows to maximize available space
The flex box solution gave a lot of space to the label. This solution minimizes that space to give more space to the values dropdown.
2024-02-26 14:02:22 +01:00
Martin Raifer
96e6dc124f
Show message about how to support OSM after a successful save, closes #10054
...
for example in form of a donation
this can be disabled by setting an env variable (`ID_SHOW_DONATION_MESSAGE=false`)
the icon is from https://uxwing.com/charity-donation-hand-love-icon/
2024-02-24 12:48:35 +01:00
NaVis0mple
6b860b7da0
refactor the code
...
'_' change to '-'
2024-02-05 18:12:01 +08:00
NaVis0mple
01d650d450
Expand DMS format and fix sec rounding logic ( #10066 )
...
Most DMS format parsed by @mapbox/sexagesimal,
add a expandable matcher and two new formats for coordinates in DMS format in search bar
example: `35 11 10.1 , 136 49 53.8` (D M SS format), or `35 11.168 , 136 49.896` (D MM format)
2024-02-02 15:26:47 +01:00
NaVis0mple
666bbbfbfc
code style change
2024-02-02 17:07:26 +08:00
NaVis0mple
b597cc1341
refactor the code
2024-02-02 16:30:52 +08:00
NaVis0mple
cc10898a58
finish open the viewer button logic
...
button disable class reacts to photoviewer close
2024-01-29 17:38:29 +08:00
NaVis0mple
0ad46e0b72
Add error message in photoviewer when invalid id
...
and update input.js
2024-01-27 15:14:27 +08:00
NaVis0mple
437ecf956b
update open the viewer button logic
...
1 problem remain: if entity select and close the photoviewer,
view button will not update class, still clickable though
2024-01-24 20:57:59 +08:00
NaVis0mple
59668638ac
Search OSM notes by ID ( #10062 )
2024-01-24 13:32:35 +01:00
NaVis0mple
0ef947d425
Update set_photo_from_viewer button create/remove logic
...
refactor the code expandability for other photo_overlay
Not sure about context.features().on('change'), and hash part
2024-01-20 20:07:49 +08:00
NaVis0mple
2b0e0f6349
update core.yaml
2024-01-18 15:36:05 +08:00
NaVis0mple
6523ae6f94
Update icon to '#iD-operation-merge'
2024-01-18 15:20:33 +08:00
NaVis0mple
5890b79472
Add set mapillary id button in the mapillary photo viewer
...
It is the a. part in https://github.com/openstreetmap/iD/issues/6196#issuecomment-751460516
still need to add button disabled logic
2023-12-28 00:34:14 +08:00
NaVis0mple
33f4f8ee5c
fix button title
2023-12-21 21:49:47 +08:00
NaVis0mple
a2296cf03f
fix setButton when imageChange disabled
2023-12-21 00:20:12 +08:00
