CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-06 19:31:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,381 Commits 2 Branches 0 Tags
fbe5389ecb05226c17d87de44939e3d2de044f0e
Commit Graph

2795 Commits

Author SHA1 Message Date
Bryan Housel
fbe5389ecb Set textarea height to fit content 2019-05-03 10:14:53 -04:00
Bryan Housel
c95860f36d Convert changes in the textarea back to tag changes 2019-05-02 23:01:33 -04:00
Bryan Housel
7b4a9a43b0 Change utilTagDiff to return an object with details 2019-05-02 22:59:41 -04:00
Bryan Housel
61819058d3 Avoid frequent reflow from setting scrollTop 
(possibly re: #6289)
 2019-05-02 14:21:57 -04:00
Bryan Housel
b17e4e4f1d Add 'list'/'text' toggle buttons 2019-05-02 13:49:26 -04:00
Bryan Housel
cebe4ced8a Preserve user's preference for 'list'/'text' view for the raw tag editor 2019-05-02 11:17:06 -04:00
Bryan Housel
ed9a436318 Move common tag diffing code from validators into utilTagDiff 2019-05-02 11:16:15 -04:00
Bryan Housel
af97f09150 Remove "key=value" pasting into raw tag editor key 
(Reverts: #6211, #5070, #5024)

The old code allows users to circumvent the readonly tag protection
see https://github.com/openstreetmap/iD/issues/6185#issuecomment-488692351

We'll offer a text-mode instead, with stricter checks on which keys can be modified.
 2019-05-02 10:22:37 -04:00
Bryan Housel
ea40634ac6 Add list<->text toggle for raw tag editor 2019-05-01 21:53:43 -04:00
Bryan Housel
087f252b18 When removing a tag, remove it from _indexedKeys too 
(re: d026f2f / #5927)

So that if the user decides to put it back, it will be sorted to the
end and not inserted back at its original position in the middle
 2019-05-01 19:17:59 -04:00
Bryan Housel
382e0a7dd6 Merge pull request #6270 from westnordost/patch-10 
inherit preset.removeTags from preset.addTags if not defined [Ready for Review]
 2019-05-01 19:15:24 -04:00
Bryan Housel
d7a569c425 Merge branch 'defer-select-for-6028' 2019-05-01 14:49:31 -04:00
Bryan Housel
37557a7c98 Defer processing clicks in behaviorSelect 
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
 2019-05-01 14:47:29 -04:00
Quincy Morgan
949b57d118 Ensure that relations are called before ways when categorizing fetched features (close #6277) 2019-05-01 11:33:39 -07:00
Quincy Morgan
907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel
d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Bryan Housel
d026f2f296 Add index property to tag rows, don't reorder on modifying key 
(closes #5927)
 2019-04-30 18:22:11 -04:00
Tobias Zwick
446dc1097d Merge branch 'master' into patch-10 
# Conflicts:
#	data/presets/presets/highway/crossing/unmarked-raised.json
#	data/presets/presets/highway/crossing/unmarked.json
 2019-04-30 22:20:05 +02:00
Quincy Morgan
9d6b461d0e Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways 2019-04-30 11:53:03 -07:00
Quincy Morgan
07573091ad Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244) 2019-04-30 11:46:15 -07:00
Quincy Morgan
942d55a4bf Update strings for duplicate node validation 
Use routable highway tags for duplicate node validation instead of any highway tag
 2019-04-30 10:18:22 -07:00
Quincy Morgan
ddae6641b3 Fix issue where preset list would not appear when adding new features (close #6271) 2019-04-30 09:42:24 -07:00
Bryan Housel
dbb10bb155 Just update save count on all changes 
(closes #6239)
 2019-04-30 10:02:00 -04:00
Tobias Zwick
f1d9b82831 inherit preset.removeTags from preset.addTags if not defined 2019-04-30 09:50:47 +02:00
Ming Gao
18dff285d0 add validation for very close node on road 
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
 2019-04-29 22:59:27 -04:00
Bryan Housel
a3605f9b74 Comment out "anchor encoding" for wiki links 
(closes #6232)
 2019-04-29 22:53:16 -04:00
Bryan Housel
a72865e4d8 Treat anything with a from/via/to like a restriction 
(closes #6221)

Applies to actions like splitting, connecting, extracting a via node, etc
 2019-04-29 21:58:10 -04:00
Bryan Housel
2b46440429 Add Relation#hasFromViaTo method and tests 2019-04-29 21:39:40 -04:00
Bryan Housel
bd2490a965 Reverse internal left/right/forward/backward keyparts 
(closes #6235)

Previously only trailing keyparts would reverse:
 `cycleway:left` ⟺  `cycleway:right`
Now it can do internal keyparts too:
 `cycleway:left:surface` ⟺  `cycleway:right:surface`
 2019-04-29 21:13:18 -04:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5 
d3 v5
 2019-04-29 15:46:08 -04:00
Bryan Housel
e981cd5dd5 Switch mapillary and openstreetcam tests to work async 
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
 2019-04-29 15:31:08 -04:00
Quincy Morgan
56898b1843 Merge branch 'master' into unsquare-buildings-autofix 2019-04-29 10:44:37 -07:00
Bryan Housel
b48a7d1e1b Workround for status errors thrown by d3-xml 
Because the done callback is expecting something that has a `status` property,
(like an XHR would), we need to extract the status out of the error message.
d3-xml includes status in the error message, but we can't access the response itself.
 2019-04-26 22:23:08 -04:00
Quincy Morgan
ea05d4e672 Unhighlight features when clicking issue quick fix (close #6219) 2019-04-26 16:26:19 -07:00
Quincy Morgan
3fad3513c1 Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane 2019-04-26 16:05:10 -07:00
Quincy Morgan
59bd6194e0 Add "autofix" for the unsquare building validation 2019-04-26 14:56:39 -07:00
Quincy Morgan
239c622044 Don't tag redundant ignored warnings counts on changesets 2019-04-26 13:02:13 -07:00
Quincy Morgan
228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan
ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00
Bryan Housel
b99be67169 When calling an errback from a Promise.catch, pass err.message 2019-04-25 21:58:36 -04:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
f2ca5316b0 Add total ignored warnings count to changeset tags (re: #6123) 2019-04-25 09:34:07 -07:00
Quincy Morgan
6eeaf94076 Show members of selected relations even when their feature layer is otherwise hidden (close #6220) 2019-04-24 17:28:56 -07:00
Quincy Morgan
42de00e640 Add validation warning for "fixme" tags (close #6214) 2019-04-24 16:59:57 -07:00
Quincy Morgan
aa91c2d768 Move old multipolygon warning into Outdated Tags rule (close #6218) 2019-04-24 15:46:50 -07:00
Quincy Morgan
6a9c7b97a8 Don't flag websites on residential buildings 2019-04-24 15:21:49 -07:00
Quincy Morgan
13f7e536dc Move highway=road validation warning to the missing_tag validation rule (re: #6218) 2019-04-24 15:19:57 -07:00
Quincy Morgan
b30c91828f Don't flag buildings with lots of nodes or buildings connected to other buildings as unsquare (re: #6215) 2019-04-24 14:52:41 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
e6bc9d9e8f Swap out d3-request, swap in d3-fetch 2019-04-24 16:25:25 -04:00