Commit Graph

69 Commits

Author SHA1 Message Date
Bryan Housel
ff14dbf944 Allow contextmenu events to work on the sidebar
(closes #4036)
2017-05-12 14:39:41 +01:00
Bryan Housel
0c810aebe4 Fix menu key as right click replacement on Windows
(closes #4017)
2017-05-08 22:03:05 +01:00
Bryan Housel
4ee5d7334b Fix spacebar drawing and hover in Firefox - don't match active node
(closes #4016)
2017-05-08 01:37:38 -04:00
Bryan Housel
cd09f9dfee Prevent mouseup from turning into a click
Mouseup was turning into a click on whatever was the last thing clicked.
In this walkthrough, this would sometimes be the "Add Area" mode button,
which would re-enter the add area mode and throw away the user's drawing.
(I have no idea why.)
2017-05-07 22:44:42 -04:00
Bryan Housel
a18d690dd5 Don't let window.location changes happen during draw modes
(closes #3996)
2017-05-03 17:15:35 -04:00
Bryan Housel
651ec363f6 Undo/Redo while drawing line/area should keep the user in drawing mode
(closes #3530)
2017-05-03 16:08:23 -04:00
Bryan Housel
af31cf5eb5 Fix spacedraw drawing, make clicking less touchy
(closes #3986)

Root cause was the vertex shadow strokes were too big, esp on endpoints.
For normal lines 16px stroke width centers on the line, but for vertices
it extends beyond the vertex radius, stealing clicks.

Also switched some "globals" to module variables in draw.js
2017-04-26 16:37:15 -04:00
Bryan Housel
5ca4246a6d If drawing a way, don't hover on a node that was just placed
(closes #3974)
2017-04-26 13:33:21 -04:00
Bryan Housel
49c087d51f Rename delegate->selector, adjust formatting, drop userselect polyfill 2017-04-25 16:51:12 -04:00
Bryan Housel
149cbbe350 Fix hover tests 2017-04-24 10:05:02 -04:00
Bryan Housel
6de6056c66 Don't hover sidebar or vertices when alt key disables snapping
This makes it a little more clear that the alt key is doing its job
2017-04-23 11:11:16 -04:00
Bryan Housel
06caeb87b7 Correct lodash _.omit usage
(closes #3965)
2017-04-22 23:05:15 -04:00
Bryan Housel
a5554cf3b0 Expire saved changeset comment older than 2 days
(closes #3947)
2017-04-21 23:01:32 -04:00
Bryan Housel
8989aea023 Clicking a midpoint should be treated as a click on the parent way 2017-04-14 00:38:04 -04:00
Bryan Housel
7da34f474b Pacify eslint 2017-03-29 12:50:29 -04:00
Bryan Housel
7873f0c425 Relax rules for using keyboard shortcuts in the walkthrough 2017-03-29 12:35:33 -04:00
Bryan Housel
d949fe08cb Fix faulty datum test from 681ee5a 2017-03-22 16:01:14 -04:00
Bryan Housel
681ee5a89a Prevent crash when missing datum
(This can happen if the user mouseups on a tooltip, e.g. in walkthrough)
2017-03-22 10:27:15 -04:00
Bryan Housel
31d2733c2a Remove unused mode variable - eslint 2017-03-22 02:51:47 -04:00
Bryan Housel
d664f74832 When changing selection, always update the url hash 2017-03-21 14:20:25 -04:00
Bryan Housel
af757d31be General usability improvements
* Reevaluate all featuers stroke widths for shadow, casing, stroke
* Shadow width is important to make sure all features are easily clickable
* Casing width is important to see oneway arrows
* Make sure all line styles have normal and low-zoom variants
* Show directional arrows for all waterway types
2017-03-16 16:16:35 -04:00
Bryan Housel
f291b0a120 Remove ineffective attempt to grab focus 2017-02-22 22:32:19 -05:00
Bryan Housel
dc2318ab63 Add mention of the right-click menu in the walkthrough 2017-02-22 17:31:08 -05:00
Bryan Housel
f7c3de9545 Preserve backward compability with radial menu
Old menu behavior can be restored with 2 cookies:
- `edit-menu-style=radial` - Display menu as a radial menu, limited to 8 items
- `edit-menu-show-always=1` - Show menu on all clicks, not just contextmenu/right
2017-02-22 16:50:42 -05:00
Bryan Housel
4f8d772397 More improvements to select behavior re contextmenu, shiftclick, etc. 2017-02-21 22:16:17 -05:00
Bryan Housel
e756520bd8 suppressMenu(true) is now the default 2017-02-21 15:47:22 -05:00
Bryan Housel
3908da03cf Fix styling of flash and footer and use absolutely positioned divs
Also fix flash tests
2017-02-17 00:23:24 -05:00
Bryan Housel
1db4ea86f7 Add icons to operation flash messages 2017-02-16 10:20:37 -05:00
Bryan Housel
2ce78d6c43 Call annotation as a function instead of a property
This is because, like tooltip(), it doesn't always make sense to call it,
and it should never get called if the operation is not available.
2017-02-15 23:02:13 -05:00
Bryan Housel
b7a81c6bec Allow customizable flash showDuration and fadeDuration 2017-02-15 22:28:35 -05:00
Bryan Housel
028ef3de3f Expose annotations for each operation 2017-02-15 22:01:30 -05:00
Bryan Housel
c5383c1f55 Darker unintrusive flash.. WIP flash operations on keypress 2017-02-10 16:39:08 -05:00
Kushan Joshi
07de6d975f Fix right clicking edge cases
Fixed

- On reselecting multiple entities, right click doesn’t discard selection

- On selecting new entity, right click discards previous selection
- Preserved shift selection for both left & right click
2017-02-09 15:41:19 +05:30
Kushan Joshi
5b92b90ced Add context menu 2017-02-09 12:53:10 +05:30
Bryan Housel
f93e57b97d Use #map.node() for drag surface instead of svg #surface
This is because #surface can be transformed during a partial redraw
and d3.mouse() returns transformed point, not the real screen point.
a2cf4f32ec/src/point.js (L4-L9)
2017-01-29 17:11:55 -05:00
Bryan Housel
ca409966db Watch for mousemove/mouseup on window, not selection
(closes #3800)
2017-01-26 16:29:49 -05:00
Bryan Housel
b407fb0c17 Remove workaround for old rollup bug 2017-01-22 21:49:25 -05:00
Bryan Housel
fd9b3931d8 Use temp names for temp segments
(closes #1369)
2017-01-13 18:44:42 +05:30
Bryan Housel
45b7a40557 Fix area drawing for #3676
These changes are needed now that `addNode`
* wants to preserve circularity
* automatically remove duplicates
* range checks index argument (can't call it with -1 anymore)
2017-01-12 19:30:07 +05:30
popov
19b0a771f6 make vertex by midpoint double-clicking 2016-12-28 15:32:47 +10:00
Bryan Housel
addd12ae99 Exclude child nodes from newIDs if their parent way was also copied
for #3656 item 1
2016-12-20 01:31:49 -05:00
Bryan Housel
087a8c62d1 Behaviors for all Operations 2016-12-20 00:28:24 -05:00
Bryan Housel
1884c7070e Add a keybinding behavior for operations 2016-12-19 16:55:11 -05:00
Bryan Housel
8a66b3d892 Don't enter iD.modeSelect without valid entities in selectedIDs 2016-12-09 11:32:14 -05:00
Bryan Housel
af3db7ea36 Swap url hash map order to zoom/latitude/longitude
(closes #3554)
2016-11-10 09:56:20 -05:00
Bryan Housel
98d484fc1f Restore hover behavior to restrictions editor, add breathe behavior
The issue was: now that selections are immutable you can't add behaviors
to them unless they are already entered.  i.e. the surface selection in
enter does not end up being the real surface after merging to update.
2016-10-30 11:35:36 -04:00
Bryan Housel
07fa5fcc34 Refactor Entity, Node, Relation, Tags, Way from core to osm 2016-10-11 22:41:24 -04:00
Bryan Housel
1c3e778baf Check for rtl url parameter for testing (rather than regex) 2016-10-08 12:45:01 -04:00
Bryan Housel
3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel
348a973f68 A few changes to make things work and test with Node 4, 5, 6 2016-09-29 10:53:07 -04:00