Commit Graph

254 Commits

Author SHA1 Message Date
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Quincy Morgan
1720f7cb93 Organize some code in coreUploader (re: #7333)
Fix lint error
2020-02-05 17:53:28 -05:00
Quincy Morgan
237a382c51 Merge branch '2.x' into uploader
# Conflicts:
#	modules/modes/save.js
2020-02-05 16:23:09 -05:00
Quincy Morgan
3b19cc32fd Don't grey out the map during conflict resolution (close #6547) 2020-02-05 16:16:50 -05:00
Quincy Morgan
0e14241fcf Move some upload code from modeSave to new coreUploader object (re: #7247) 2020-02-05 15:28:23 -05:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Bryan Housel
b8a8927d33 Start preparing uiSuccess early when saving changeset
This gives us some time to fetch and prepare the community index
2020-01-29 15:23:37 -05:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
7ca9f55d43 2.x: Don't render multipolygon members in yellow when the multipolygon is selected (re: #6558, re: 4ab97128c4aae04b627cf8f19091c6c0fc1cf5bc) 2019-12-13 14:19:15 -05:00
Quincy Morgan
91b6844377 Implement cleaner solution for removing breathe styling from deselected features 2019-12-13 13:16:29 -05:00
Quincy Morgan
61f0a670db Correctly remove yellow member highlight when removing member from select relation (close #6772)
Don't exit select mode when panning selected feature out of view
Return false when checking selected IDs and switching between single and multiselect in modeSelect
2019-12-13 12:07:43 -05:00
Quincy Morgan
7473d32e31 2.x: Highlight relation members in yellow when a relation is selected, including in a multi-selection (re: #5766, re: cf2935576511a1b9f5aac47407ed2b0ce803902a) 2019-12-13 11:20:40 -05:00
Quincy Morgan
9920c7dd1d Fix typo in comment 2019-12-13 11:10:09 -05:00
Quincy Morgan
e352d425e9 Prevent opening edit menu in wide selection 2019-12-13 11:06:36 -05:00
Quincy Morgan
827c8034d5 Enable zoom-to-center of multiple selected entities (close #6696) 2019-12-13 10:30:00 -05:00
Quincy Morgan
ff506fc332 Prevent partial rendering of selection style when showing only selected features at low zooms 2019-12-12 17:50:48 -05:00
Quincy Morgan
912151ff38 Allow viewing and editing the tags/relations of selected features at any zoom level in 2.x (re: #5001) 2019-12-12 16:54:16 -05:00
Quincy Morgan
9aa27f68c3 Fix stale UI when undoing/redoing between single and multiselections (re: #7090) 2019-12-10 10:07:05 -05:00
hack.ily
b40d4ac893 Fix lint 2019-10-28 10:20:40 -04:00
hack.ily
b5fac6396e fix(mode/rotate): polygonHull sometimes returns array of length 2 which polygonCentroid cannot handle 2019-10-28 10:20:26 -04:00
Quincy Morgan
08530dd822 Prevent stale operations by reloading them after history changes 2019-10-03 16:57:12 +02:00
Quincy Morgan
16bc43b00e Clear hover-highlighting when exiting modeSelect 2019-08-22 15:49:28 -05:00
Quincy Morgan
c97ea095f5 Select standalone points after dragging them (close #5747) 2019-08-21 13:46:04 -05:00
Quincy Morgan
760134c2aa Add check for possible missing activeEntity in drag_node 2019-05-08 12:17:36 -04:00
Bryan Housel
8f9dc7afb4 Improve localization of "Thank you for editing the map around.."
(closes #6269)
2019-05-04 13:24:46 -04:00
Bryan Housel
d7a569c425 Merge branch 'defer-select-for-6028' 2019-05-01 14:49:31 -04:00
Quincy Morgan
907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel
d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan
6eeaf94076 Show members of selected relations even when their feature layer is otherwise hidden (close #6220) 2019-04-24 17:28:56 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Bryan Housel
81127d71f3 Cache disabled() results in straighten action for consistent response
What could happen was:
- user could right click on a line
- this would trigger `disabled()` checks for each operation buttons
- the line was not fully downloaded, so would return `disabled()` 'not_downloaded'
  (and also start download of the missing tiles)
- then the tooltip would pop into existence, calling `tooltip()`
- which calls `disabled()` again
- but this time it's fine and the `disabled()` is false
- so you'd see a greyed out button but the tooltip said everyting is ok and
  you can click the button anyway

I fixed this by just caching the disabled test.  This is probably ok anyway
because these tests can be expensive, and then the user will see a consistent
message like "The line is not yet fully downloaded".

If the user clicks off the line and back onto it, iD will reenter select mode,
rebuild the menu, redo the disabled test, and they will see the button enabled.
2019-04-10 10:19:23 -04:00
Quincy Morgan
9d029a37a8 Delete newly-created untagged relations when deselecting them (close #3812) 2019-04-07 13:39:51 -07:00
Quincy Morgan
bf391c997a Fix issue where Points walkthrough could not be completed in some cases due to downgrade operation (re: #6103) 2019-04-02 20:23:27 -07:00
Quincy Morgan
8779e1a6dc Add Downgrade operation to remove most tags from features but retain address and building tags instead of immediate deletion 2019-04-02 11:09:08 -04:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Bryan Housel
5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Quincy Morgan
67fc051632 Tweak newFeature in select mode 2019-03-26 16:34:23 -04:00
Bryan Housel
1ce4f0ad6a Remove lodash without
(re: #6087)
2019-03-25 21:56:54 -04:00
Bryan Housel
76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel
0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
fc6bf79ed1 Make Add Note shortcut translatable 2019-03-05 12:04:13 -05:00
Quincy Morgan
062872c4f0 Merge tags instead of adding new point when adding a point to a point
Fix lint error
2019-03-05 09:39:55 -05:00
Quincy Morgan
b828ada0e2 Don't allow adding point-only features as vertices 2019-03-04 17:04:35 -05:00
Quincy Morgan
971b901b21 Add 1 as the hotkey for focusing the search bar 2019-03-02 15:37:15 -05:00
Quincy Morgan
5ed5a7536b Show preset browser when adding generic point, line, or area 2019-03-01 09:07:41 -05:00