Commit Graph

4770 Commits

Author SHA1 Message Date
Martin Raifer
a166210f34 Merge remote-tracking branch 'arch0345/improveosm' into develop 2024-07-12 12:54:16 +02:00
arch0345
14794ee992 Remove references to ImproveOSM 2024-07-08 17:15:38 -07:00
Martin Raifer
b2b3009a64 .env oauth2 config: drop client secret; use URL if API_URL is empty 2024-07-05 16:15:47 +02:00
Martin Raifer
49492a0e06 keep chosen dropdown item if user clicked on one
fixes a bug where in case multiple items with the same `value` are present in the combobox' dropdown, always the first one is returned in the `accept` event
2024-06-05 19:56:56 +02:00
Martin Raifer
97d1aa5e2d Fix address field overwriting existing data when switching features
fixes #12060

This bug can occur occasionally under the following circumstances:

* map feature 1 is selected
* the cursor is in an address (sub) field
* map feature 2 gets selected directly
* now, in some cases, the contents of the address fields of feature 2 are written into feature 1's tags
2024-06-05 19:55:51 +02:00
Dimitar
b2fc4a43c0 Consider lifecycle prefixed tags in Future/Past features (#10228)
and sharpen landuse filter
2024-06-05 14:47:19 +02:00
Martin Raifer
94a55434bb Merge remote-tracking branch 'k-yle/conveying' into develop 2024-06-05 13:02:37 +02:00
Martin Raifer
99d7a85ab4 Merge remote-tracking branch 'k-yle/highway-ladder' into develop 2024-06-05 12:58:56 +02:00
Kyℓe Hensel
3b9b622294 fix wikidata styling not applying to vertices (#10258) 2024-06-05 12:53:42 +02:00
Martin Raifer
379be391a3 fix crash in zoomToEntity when entity has parent relations 2024-05-31 14:15:35 +02:00
Martin Raifer
342a03bcfe allow type/id syntax in id hash param, and add support for notes 2024-05-28 20:18:53 +02:00
Martin Raifer
82d3c6d22a fix small typos 2024-05-27 12:54:36 +02:00
Martin Raifer
9c6b7251f5 Merge remote-tracking branch 'k-yle/3595-localised-auth-popup' into develop 2024-05-27 12:47:11 +02:00
Kyℓe Hensel
5a7f281e81 update domain name for ImproveOSM (#9997) 2024-05-27 12:28:41 +02:00
Kyle Hensel
c7731f5499 support highway=ladder 2024-05-25 16:25:59 +10:00
Kyle Hensel
180a2bbd50 render oneway arrows for the conveying tag 2024-05-25 16:01:04 +10:00
Kyℓe Hensel
010a812eac fix bug causing a spam of network requests (#10119) 2024-04-25 15:46:32 +02:00
Pavel Zbytovský
aa53bbf550 Sort "more fields" dropdown items (#10181) 2024-04-25 15:34:39 +02:00
Martin Raifer
5251ee6b65 add new method to reuse localized text span, closes #8994 2024-04-24 17:29:06 +02:00
Martin Raifer
fc4e05601a reduce unnecessary html injection 2024-04-24 13:53:43 +02:00
laigyu
42691dec9d fix onclick handler when closing/reopening notes with comment (#10205) 2024-04-24 13:49:25 +02:00
Mateusz Konieczny
70b96b1758 preserve whitespace in inscription tag after semicolons, fixes #10188 (#10189) 2024-04-24 13:26:56 +02:00
laigyu
6a6f30b5a8 fix link button when dragging combo field chips #10153 (#10209) 2024-04-24 12:24:52 +02:00
Martin Raifer
211b6dde5f upgrade to eslintv9 (config format, lint to updated rules) 2024-04-12 18:44:04 +02:00
Martin Raifer
ee56b9c8ae render closed amenity=bicycle_parking ways as areas by default
fixes https://github.com/openstreetmap/id-tagging-schema/issues/1114#issuecomment-2018057194
2024-03-26 15:19:35 +01:00
Hirako
85278c35e4 Field: fix wikiURL by URL encoding it - and slight refactors (#10165)
* Field: fix wikiURL by URL encoding it - and slight refactors

* Field: fix wikiURL only encodeURIComponent instead of redundant full URL

* Field: refactors function to generate wikiURL, ensures anchor part is also URI encoded, ensures the anchor ref is not encoded, adds unit tests

* Field: refactors wikipedia URI encoding of the anchor logic, removes legacy anchorencode effort via try-catch that replaced percentage character with dots, adds unit further  tests, reduces exessive inlining
2024-03-21 00:42:08 -07:00
Martin Raifer
12b0528175 Upgrade closed ways with traffic_calming=island to area:highway=traffic_calming
addresses missing pieces for https://github.com/openstreetmap/id-tagging-schema/issues/1162
2024-03-15 21:12:31 +01:00
Asif Sheriff
1683313621 preserve rows with empty tag values in raw tag editor (#10151) 2024-03-15 01:13:07 +01:00
Martin Raifer
444c5835c9 hide forward/back button if there is no matching image
e.g. for the first/last photo in a sequence, or when there are gaps
2024-03-08 10:59:34 +01:00
Mattia Pezzotti
a75eace135 Fix for Point Tutorial (#10129) 2024-03-07 23:38:51 +01:00
Martin Raifer
5d06d3b83e Merge pull request #10149 from openstreetmap/split-relation-members
Robust local splitting of ways which are part of (route) relations
2024-03-06 13:54:14 +01:00
Martin Raifer
20f53e5748 document algorithm inline, handle "junction=circular" like roundabouts 2024-03-06 13:46:22 +01:00
Martin Raifer
d7aca27f41 minor code readibility refactoring 2024-03-05 17:20:04 +01:00
Martin Raifer
d7111e20f5 add button to load a feature's relations fully (if incomplete), fixes #5420 2024-03-05 14:25:16 +01:00
Martin Raifer
296ce859cf allow splitting of closed roundabout for certain rel types 2024-03-05 14:23:02 +01:00
Martin Raifer
13d46b0578 typo 2024-03-04 23:37:29 +01:00
Tobias
b72a089f35 Field: Fix html tag type of wikidata label (#10144)
The `span` need to be a `div` after https://github.com/openstreetmap/iD/pull/10127/files
2024-03-04 19:25:53 +01:00
Martin Raifer
82af60115d disalow splitting of closed roundabouts when they are part of a route
these cases are not covered by the splitting algorithm at the moment:
* typicall, only a part of the roundabout should be part of the resulting route
* when multiple routes meet at a roundabout coming from different angles, the roundabout must be split at any of those entry/exit point simutaneously, such that all routes remain correct

as a workaround, a mapper can remove the route relation(s) from the roundabout, split it accordingly and then re-add the respective parts to the relation(s) again.
2024-03-04 19:02:33 +01:00
Martin Raifer
7268a8538c handle closed roundabout ways like a single junction "point" 2024-03-04 19:02:32 +01:00
Martin Raifer
088db7ccc1 simplify boolean conditions 2024-03-04 19:02:32 +01:00
Martin Raifer
11dfbe804c fix splitting of (route) relation member ways
instead of fully re-sorting the whole relation every time a member is split, perform a local operation: This works under the assumption that the relation is already sorted properly. The new way is inserted into the relation before or after the existing member, depending on how the old/new way connect to their neighboring members.

for cases where two ways form a loop, a additional look-ahead is implemented to disambiguate the order
2024-03-04 19:02:31 +01:00
Martin Raifer
cc920d3fba drop unused var 2024-03-02 15:43:56 +01:00
Martin Raifer
97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
Martin Raifer
8274384311 Fix validator suggesting to add empty *:wikipedia tags to NSI presets (fixes #10140) 2024-02-29 10:30:18 +01:00
Martin Raifer
075b881978 Merge remote-tracking branch 'mtmail/mutually-exclusive-tags-validator' into develop 2024-02-26 14:11:14 +01:00
Tobias
ce51b33cf2 Improve combobox dropdown styling to give labels more room and readability (#10127)
* Fields: Break long lines in combo dropdown instead of ellipsis

Longer translations keys are not readable with ellipsis and the tooltip only shows the description (or fallback), not the title.

This change makes long use line breaks with small line height to make the whole text visible.

* Fields: Use table styles for rows to maximize available space

The flex box solution gave a lot of space to the label. This solution minimizes that space to give more space to the values dropdown.
2024-02-26 14:02:22 +01:00
marc tobias
277b5d4f45 new validator: mutually exclusive tags 2024-02-25 18:40:10 +01:00
Martin Raifer
85f4cc0316 don't reverse side tag of highway=cyclist_waiting_aid features, fixes #10128 2024-02-25 15:36:17 +01:00
Martin Raifer
96e6dc124f Show message about how to support OSM after a successful save, closes #10054
for example in form of a donation

this can be disabled by setting an env variable (`ID_SHOW_DONATION_MESSAGE=false`)

the icon is from https://uxwing.com/charity-donation-hand-love-icon/
2024-02-24 12:48:35 +01:00
Kyle Hensel
8889118f03 set the locale of the login popup 2024-02-22 21:15:39 +11:00