mirror of
https://github.com/FoggedLens/iD.git
synced 2026-02-14 09:42:56 +00:00
- Many text expects are now wrapped in setTimeout, as the fetch promises settle async now. - This makes the tests somewhat brittle, and we should maybe consider reworking some of them. For example it is very hard to perform a test like `expect(spy).to.have.not.been.called` in an async way. (We could instead inspect the fakeServer requests() to know this.) - Also includes some trickery for osm.js, which uses d3-xml (fetch) now for unauthenticated calls and osmauth (xhr) for authenticated calls
173 lines
7.0 KiB
JavaScript
173 lines
7.0 KiB
JavaScript
describe('iD.uiFieldWikipedia', function() {
|
|
var entity, context, selection, field, server;
|
|
|
|
function changeTags(changed) {
|
|
var e = context.entity(entity.id);
|
|
var annotation = 'Changed tags.';
|
|
var tags = JSON.parse(JSON.stringify(e.tags)); // deep copy
|
|
var didChange = false;
|
|
|
|
for (var k in changed) {
|
|
if (changed.hasOwnProperty(k)) {
|
|
var v = changed[k];
|
|
if (tags[k] !== v && (v !== undefined || tags.hasOwnProperty(k))) {
|
|
tags[k] = v;
|
|
didChange = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (didChange) {
|
|
context.perform(iD.actionChangeTags(e.id, tags), annotation);
|
|
}
|
|
}
|
|
|
|
function createServer(options) { // eslint-disable-line no-unused-vars
|
|
// note - currently skipping the tests that use `options` to delay responses
|
|
// var server = sinon.fakeServer.create(options);
|
|
var server = window.fakeFetch().create();
|
|
server.respondWith('GET',
|
|
new RegExp('\/w\/api\.php.*action=wbgetentities'),
|
|
[200, { 'Content-Type': 'application/json' },
|
|
'{"entities":{"Q216353":{"id":"Q216353"}}}']
|
|
);
|
|
return server;
|
|
}
|
|
|
|
before(function() {
|
|
iD.services.wikipedia = iD.serviceWikipedia;
|
|
iD.services.wikidata = iD.serviceWikidata;
|
|
});
|
|
|
|
after(function() {
|
|
delete iD.services.wikipedia;
|
|
delete iD.services.wikidata;
|
|
});
|
|
|
|
beforeEach(function() {
|
|
entity = iD.osmNode({id: 'n12345'});
|
|
context = iD.coreContext();
|
|
context.history().merge([entity]);
|
|
selection = d3.select(document.createElement('div'));
|
|
field = iD.presetField('wikipedia', {
|
|
key: 'wikipedia',
|
|
keys: ['wikipedia', 'wikidata'],
|
|
type: 'wikipedia'
|
|
});
|
|
server = createServer({ respondImmediately: true });
|
|
});
|
|
|
|
afterEach(function() {
|
|
server.restore();
|
|
});
|
|
|
|
it('recognizes lang:title format', function() {
|
|
var wikipedia = iD.uiFieldWikipedia(field, context);
|
|
selection.call(wikipedia);
|
|
wikipedia.tags({wikipedia: 'en:Title'});
|
|
|
|
expect(iD.utilGetSetValue(selection.selectAll('.wiki-lang'))).to.equal('English');
|
|
expect(iD.utilGetSetValue(selection.selectAll('.wiki-title'))).to.equal('Title');
|
|
});
|
|
|
|
it('sets language, value', function() {
|
|
var wikipedia = iD.uiFieldWikipedia(field, context).entity(entity);
|
|
wikipedia.on('change', changeTags);
|
|
selection.call(wikipedia);
|
|
|
|
var spy = sinon.spy();
|
|
wikipedia.on('change.spy', spy);
|
|
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-lang'), 'Deutsch');
|
|
happen.once(selection.selectAll('.wiki-lang').node(), { type: 'change' });
|
|
happen.once(selection.selectAll('.wiki-lang').node(), { type: 'blur' });
|
|
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-title'), 'Title');
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'change' });
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'blur' });
|
|
|
|
expect(spy.callCount).to.equal(4);
|
|
expect(spy.getCall(0)).to.have.been.calledWith({ wikipedia: undefined}); // lang on change
|
|
expect(spy.getCall(1)).to.have.been.calledWith({ wikipedia: undefined}); // lang on blur
|
|
expect(spy.getCall(2)).to.have.been.calledWith({ wikipedia: 'de:Title' }); // title on change
|
|
expect(spy.getCall(3)).to.have.been.calledWith({ wikipedia: 'de:Title' }); // title on blur
|
|
});
|
|
|
|
it('recognizes pasted URLs', function() {
|
|
var wikipedia = iD.uiFieldWikipedia(field, context).entity(entity);
|
|
wikipedia.on('change', changeTags);
|
|
selection.call(wikipedia);
|
|
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-title'), 'http://de.wikipedia.org/wiki/Title');
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'change' });
|
|
|
|
expect(iD.utilGetSetValue(selection.selectAll('.wiki-lang'))).to.equal('Deutsch');
|
|
expect(iD.utilGetSetValue(selection.selectAll('.wiki-title'))).to.equal('Title');
|
|
});
|
|
|
|
it('preserves existing language', function() {
|
|
selection.call(iD.uiFieldWikipedia(field, context));
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-lang'), 'Deutsch');
|
|
|
|
var wikipedia = iD.uiFieldWikipedia(field, context);
|
|
selection.call(wikipedia);
|
|
wikipedia.tags({});
|
|
|
|
expect(iD.utilGetSetValue(selection.selectAll('.wiki-lang'))).to.equal('Deutsch');
|
|
});
|
|
|
|
it.skip('does not set delayed wikidata tag if graph has changed', function(done) {
|
|
var wikipedia = iD.uiFieldWikipedia(field, context).entity(entity);
|
|
wikipedia.on('change', changeTags);
|
|
selection.call(wikipedia);
|
|
|
|
var spy = sinon.spy();
|
|
wikipedia.on('change.spy', spy);
|
|
|
|
// Create an XHR server that will respond after 60ms
|
|
createServer({ autoRespond: true, autoRespondAfter: 60 });
|
|
|
|
// Set title to "Skip"
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-lang'), 'Deutsch');
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-title'), 'Skip');
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'change' });
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'blur' });
|
|
|
|
// t0
|
|
expect(context.entity(entity.id).tags.wikidata).to.be.undefined;
|
|
|
|
// Create a new XHR server that will respond after 60ms to
|
|
// separate requests after this point from those before
|
|
createServer({ autoRespond: true, autoRespondAfter: 60 });
|
|
|
|
// t30: graph change - Set title to "Title"
|
|
window.setTimeout(function() {
|
|
iD.utilGetSetValue(selection.selectAll('.wiki-title'), 'Title');
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'change' });
|
|
happen.once(selection.selectAll('.wiki-title').node(), { type: 'blur' });
|
|
}, 30);
|
|
|
|
// t60: at t0 + 60ms (delay), wikidata SHOULD NOT be set because graph has changed.
|
|
|
|
// t70: check that wikidata unchanged
|
|
window.setTimeout(function() {
|
|
expect(context.entity(entity.id).tags.wikidata).to.be.undefined;
|
|
}, 70);
|
|
|
|
// t90: at t30 + 60ms (delay), wikidata SHOULD be set because graph is unchanged.
|
|
|
|
// t100: check that wikidata has changed
|
|
window.setTimeout(function() {
|
|
expect(context.entity(entity.id).tags.wikidata).to.equal('Q216353');
|
|
|
|
expect(spy.callCount).to.equal(4);
|
|
expect(spy.getCall(0)).to.have.been.calledWith({ wikipedia: 'de:Skip' }); // 'Skip' on change
|
|
expect(spy.getCall(1)).to.have.been.calledWith({ wikipedia: 'de:Skip' }); // 'Skip' on blur
|
|
expect(spy.getCall(2)).to.have.been.calledWith({ wikipedia: 'de:Title' }); // 'Title' on change +10ms
|
|
expect(spy.getCall(3)).to.have.been.calledWith({ wikipedia: 'de:Title' }); // 'Title' on blur +10ms
|
|
done();
|
|
}, 100);
|
|
|
|
});
|
|
});
|