mirror of
https://github.com/FoggedLens/iD.git
synced 2026-03-11 21:56:00 +00:00
d0452e6be4
- Many text expects are now wrapped in setTimeout, as the fetch promises settle async now. - This makes the tests somewhat brittle, and we should maybe consider reworking some of them. For example it is very hard to perform a test like `expect(spy).to.have.not.been.called` in an async way. (We could instead inspect the fakeServer requests() to know this.) - Also includes some trickery for osm.js, which uses d3-xml (fetch) now for unauthenticated calls and osmauth (xhr) for authenticated calls
304 lines
12 KiB
JavaScript
304 lines
12 KiB
JavaScript
describe('iD.presetIndex', function () {
|
|
var savedPresets, savedAreaKeys, server;
|
|
|
|
before(function () {
|
|
savedPresets = iD.data.presets;
|
|
savedAreaKeys = iD.areaKeys;
|
|
});
|
|
|
|
after(function () {
|
|
iD.data.presets = savedPresets;
|
|
iD.setAreaKeys(savedAreaKeys);
|
|
});
|
|
|
|
describe('#match', function () {
|
|
var testPresets = {
|
|
presets: {
|
|
point: { tags: {}, geometry: ['point'] },
|
|
line: { tags: {}, geometry: ['line'] },
|
|
vertex: { tags: {}, geometry: ['vertex'] },
|
|
residential: { tags: { highway: 'residential' }, geometry: ['line'] },
|
|
park: { tags: { leisure: 'park' }, geometry: ['point', 'area'] }
|
|
}
|
|
};
|
|
|
|
it('returns a collection containing presets matching a geometry and tags', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var way = iD.osmWay({ tags: { highway: 'residential' } });
|
|
var graph = iD.coreGraph([way]);
|
|
|
|
expect(presets.match(way, graph).id).to.eql('residential');
|
|
});
|
|
|
|
it('returns the appropriate fallback preset when no tags match', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var point = iD.osmNode();
|
|
var line = iD.osmWay({ tags: { foo: 'bar' } });
|
|
var graph = iD.coreGraph([point, line]);
|
|
|
|
expect(presets.match(point, graph).id).to.eql('point');
|
|
expect(presets.match(line, graph).id).to.eql('line');
|
|
});
|
|
|
|
it('matches vertices on a line as points', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var point = iD.osmNode({ tags: { leisure: 'park' } });
|
|
var line = iD.osmWay({ nodes: [point.id], tags: { 'highway': 'residential' } });
|
|
var graph = iD.coreGraph([point, line]);
|
|
|
|
expect(presets.match(point, graph).id).to.eql('point');
|
|
});
|
|
|
|
it('matches vertices on an addr:interpolation line as points', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var point = iD.osmNode({ tags: { leisure: 'park' } });
|
|
var line = iD.osmWay({ nodes: [point.id], tags: { 'addr:interpolation': 'even' } });
|
|
var graph = iD.coreGraph([point, line]);
|
|
|
|
expect(presets.match(point, graph).id).to.eql('park');
|
|
});
|
|
});
|
|
|
|
|
|
describe('#areaKeys', function () {
|
|
var testPresets = {
|
|
presets: {
|
|
'amenity/fuel/shell': { tags: { 'amenity': 'fuel' }, geometry: ['point', 'area'], suggestion: true },
|
|
'highway/foo': { tags: { 'highway': 'foo' }, geometry: ['area'] },
|
|
'leisure/track': { tags: { 'leisure': 'track' }, geometry: ['line', 'area'] },
|
|
'natural': { tags: { 'natural': '*' }, geometry: ['point', 'vertex', 'area'] },
|
|
'natural/peak': { tags: { 'natural': 'peak' }, geometry: ['point', 'vertex'] },
|
|
'natural/tree_row': { tags: { 'natural': 'tree_row' }, geometry: ['line'] },
|
|
'natural/wood': { tags: { 'natural': 'wood' }, geometry: ['point', 'area'] }
|
|
}
|
|
};
|
|
|
|
it('whitelists keys for presets with area geometry', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys()).to.include.keys('natural');
|
|
});
|
|
|
|
it('blacklists key-values for presets with a line geometry', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys().natural).to.include.keys('tree_row');
|
|
expect(presets.areaKeys().natural.tree_row).to.be.true;
|
|
});
|
|
|
|
it('blacklists key-values for presets with both area and line geometry', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys().leisure).to.include.keys('track');
|
|
});
|
|
|
|
it('does not blacklist key-values for presets with neither area nor line geometry', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys().natural).not.to.include.keys('peak');
|
|
});
|
|
|
|
it('does not blacklist generic \'*\' key-values', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys().natural).not.to.include.keys('natural');
|
|
});
|
|
|
|
it('ignores keys like \'highway\' that are assumed to be lines', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys()).not.to.include.keys('highway');
|
|
});
|
|
|
|
it('ignores suggestion presets', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
expect(presets.areaKeys()).not.to.include.keys('amenity');
|
|
});
|
|
});
|
|
|
|
describe('#build', function () {
|
|
it('builds presets from provided', function () {
|
|
var surfShop = iD.osmNode({ tags: { amenity: 'shop', 'shop:type': 'surf' } });
|
|
var graph = iD.coreGraph([surfShop]);
|
|
var presets = iD.coreContext().presets();
|
|
var morePresets = {
|
|
presets: {
|
|
'amenity/shop/surf': {
|
|
tags: { amenity: 'shop', 'shop:type': 'surf' },
|
|
geometry: ['point', 'area']
|
|
}
|
|
}
|
|
};
|
|
|
|
expect(presets.match(surfShop, graph)).to.eql(undefined); // no surfshop preset yet...
|
|
presets.build(morePresets, true);
|
|
expect(presets.match(surfShop, graph).addTags).to.eql({ amenity: 'shop', 'shop:type': 'surf' });
|
|
});
|
|
|
|
it('configures presets\' initial visibility', function () {
|
|
var surfShop = iD.osmNode({ tags: { amenity: 'shop', 'shop:type': 'surf' } });
|
|
var firstStreetJetty = iD.osmNode({ tags: { man_made: 'jetty' } });
|
|
var entities = [surfShop, firstStreetJetty];
|
|
var graph = iD.coreGraph(entities);
|
|
var presets = iD.coreContext().presets();
|
|
var morePresets = {
|
|
presets: {
|
|
'amenity/shop/surf': {
|
|
tags: { amenity: 'shop', 'shop:type': 'surf' },
|
|
geometry: ['point', 'area']
|
|
},
|
|
'man_made/jetty': {
|
|
tags: { man_made: 'jetty' },
|
|
geometry: ['point']
|
|
}
|
|
}
|
|
};
|
|
|
|
presets.build(morePresets, false);
|
|
entities.forEach(function (entity) {
|
|
var preset = presets.match(entity, graph);
|
|
expect(preset.visible()).to.be.false;
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('expected matches', function () {
|
|
var testPresets = {
|
|
presets: {
|
|
area: { name: 'Area', tags: {}, geometry: ['area'] },
|
|
line: { name: 'Line', tags: {}, geometry: ['line'] },
|
|
point: { name: 'Point', tags: {}, geometry: ['point'] },
|
|
vertex: { name: 'Vertex', tags: {}, geometry: ['vertex'] },
|
|
relation: { name: 'Relation', tags: {}, geometry: ['relation'] },
|
|
building: { name: 'Building', tags: { building: 'yes' }, geometry: ['area'] },
|
|
'type/multipolygon': {
|
|
name: 'Multipolygon',
|
|
geometry: ['area', 'relation'],
|
|
tags: { 'type': 'multipolygon' },
|
|
searchable: false,
|
|
matchScore: 0.1
|
|
},
|
|
address: {
|
|
name: 'Address',
|
|
geometry: ['point', 'vertex', 'area'],
|
|
tags: { 'addr:*': '*' },
|
|
matchScore: 0.15
|
|
},
|
|
'highway/pedestrian_area': {
|
|
name: 'Pedestrian Area',
|
|
geometry: ['area'],
|
|
tags: { highway: 'pedestrian', area: 'yes' }
|
|
}
|
|
}
|
|
};
|
|
|
|
it('prefers building to multipolygon', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var relation = iD.osmRelation({ tags: { type: 'multipolygon', building: 'yes' } });
|
|
var graph = iD.coreGraph([relation]);
|
|
expect(presets.match(relation, graph).id).to.eql('building');
|
|
});
|
|
|
|
it('prefers building to address', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var way = iD.osmWay({ tags: { area: 'yes', building: 'yes', 'addr:housenumber': '1234' } });
|
|
var graph = iD.coreGraph([way]);
|
|
expect(presets.match(way, graph).id).to.eql('building');
|
|
});
|
|
|
|
it('prefers pedestrian to area', function () {
|
|
iD.data.presets = testPresets;
|
|
var presets = iD.coreContext().presets();
|
|
var way = iD.osmWay({ tags: { area: 'yes', highway: 'pedestrian' } });
|
|
var graph = iD.coreGraph([way]);
|
|
expect(presets.match(way, graph).id).to.eql('highway/pedestrian_area');
|
|
});
|
|
});
|
|
|
|
|
|
describe('#fromExternal', function () {
|
|
var morePresets = {
|
|
presets: {
|
|
'8bc64d6d': {
|
|
'name': 'Surf Shop',
|
|
'geometry': ['area', 'point'],
|
|
'fields': ['2161a712'],
|
|
'tags': { 'amenity': 'shop', 'shop:type': 'surf' },
|
|
'matchScore': 0.99
|
|
}
|
|
},
|
|
'fields': {
|
|
'2161a712': {
|
|
'key': 'building',
|
|
'label': 'Building',
|
|
'overrideLabel': 'Building',
|
|
'type': 'text'
|
|
}
|
|
}
|
|
};
|
|
|
|
beforeEach(function () {
|
|
server = window.fakeFetch().create();
|
|
});
|
|
|
|
afterEach(function () {
|
|
server.restore();
|
|
});
|
|
|
|
it('builds presets w/external sources set to visible', function () {
|
|
var surfShop = iD.osmNode({ tags: { amenity: 'shop', 'shop:type': 'surf' } });
|
|
var graph = iD.coreGraph([surfShop]);
|
|
var url = 'https://fakemaprules.io/fake.json';
|
|
|
|
// no exernal presets yet
|
|
expect(iD.coreContext().presets().match(surfShop, graph).id).to.eql('point');
|
|
|
|
// reset graph...
|
|
graph = iD.coreGraph([surfShop]);
|
|
|
|
// add the validations query param...
|
|
iD.coreContext().presets().fromExternal(url, function (externalPresets) {
|
|
expect(externalPresets.match(surfShop, graph).id).to.eql('8bc64d6d');
|
|
});
|
|
|
|
server.respondWith('GET', /fake\.json/,
|
|
[200, { 'Content-Type': 'application/json' }, JSON.stringify(morePresets)]
|
|
);
|
|
server.respond();
|
|
});
|
|
|
|
it('makes only the external presets initially visible', function () {
|
|
var url = 'https://fakemaprules.io/fake.json';
|
|
|
|
iD.coreContext().presets().fromExternal(url, function(externalPresets) {
|
|
var external = externalPresets.collection.reduce(function(presets, preset) {
|
|
if (!preset.hasOwnProperty('members') && preset.visible()) {
|
|
presets.push(preset.id);
|
|
}
|
|
return presets;
|
|
}, []);
|
|
|
|
var morePresetKeys = Object.keys(morePresets.presets);
|
|
expect(morePresetKeys.length).to.eql(external.length);
|
|
|
|
morePresetKeys.forEach(function(presetID) {
|
|
expect(external.indexOf(presetID)).to.be.at.least(0);
|
|
});
|
|
});
|
|
|
|
server.respondWith('GET', /fake\.json/,
|
|
[200, { 'Content-Type': 'application/json' }, JSON.stringify(morePresets)]
|
|
);
|
|
server.respond();
|
|
});
|
|
});
|
|
|
|
});
|