Refactor DumpsysAppOps

tests/android/test_artifact_dumpsys_appops.py

@@ -0,0 +1,47 @@
+# Mobile Verification Toolkit (MVT)
+# Copyright (c) 2021-2023 Claudio Guarnieri.
+# Use of this software is governed by the MVT License 1.1 that can be found at
+#   https://license.mvt.re/1.1/
+import logging
+
+from mvt.android.artifacts.dumpsys_appops import DumpsysAppops
+from mvt.common.indicators import Indicators
+
+from ..utils import get_artifact
+
+
+class TestDumpsysAppopsArtifact:
+    def test_parsing(self):
+        da = DumpsysAppops()
+        da.log = logging
+        file = get_artifact("android_data/dumpsys_appops.txt")
+        with open(file) as f:
+            data = f.read()
+
+        assert len(da.results) == 0
+        da.parse(data)
+        assert len(da.results) == 13
+        assert da.results[0]["package_name"] == "com.android.phone"
+        assert da.results[0]["uid"] == "0"
+        assert len(da.results[0]["permissions"]) == 1
+        assert da.results[0]["permissions"][0]["name"] == "MANAGE_IPSEC_TUNNELS"
+        assert da.results[0]["permissions"][0]["access"] == "allow"
+        assert da.results[6]["package_name"] == "com.sec.factory.camera"
+        assert len(da.results[6]["permissions"][1]["entries"]) == 1
+        assert len(da.results[11]["permissions"]) == 4
+
+    def test_ioc_check(self, indicator_file):
+        da = DumpsysAppops()
+        da.log = logging
+        file = get_artifact("android_data/dumpsys_appops.txt")
+        with open(file) as f:
+            data = f.read()
+        da.parse(data)
+
+        ind = Indicators(log=logging.getLogger())
+        ind.parse_stix2(indicator_file)
+        ind.ioc_collections[0]["app_ids"].append("com.facebook.katana")
+        da.indicators = ind
+        assert len(da.detected) == 0
+        da.check_indicators()
+        assert len(da.detected) == 1

tests/android/test_dumpsys_parser.py

@@ -4,7 +4,6 @@
 #   https://license.mvt.re/1.1/
 
 from mvt.android.parsers.dumpsys import (
-    parse_dumpsys_appops,
     parse_dumpsys_battery_history,
     parse_dumpsys_packages,
 )
@@ -13,23 +12,6 @@ from ..utils import get_artifact
 
 
 class TestDumpsysParsing:
-    def test_appops_parsing(self):
-        file = get_artifact("android_data/dumpsys_appops.txt")
-        with open(file) as f:
-            data = f.read()
-
-        res = parse_dumpsys_appops(data)
-
-        assert len(res) == 13
-        assert res[0]["package_name"] == "com.android.phone"
-        assert res[0]["uid"] == "0"
-        assert len(res[0]["permissions"]) == 1
-        assert res[0]["permissions"][0]["name"] == "MANAGE_IPSEC_TUNNELS"
-        assert res[0]["permissions"][0]["access"] == "allow"
-        assert res[6]["package_name"] == "com.sec.factory.camera"
-        assert len(res[6]["permissions"][1]["entries"]) == 1
-        assert len(res[11]["permissions"]) == 4
-
     def test_battery_history_parsing(self):
         file = get_artifact("android_data/dumpsys_battery.txt")
         with open(file) as f: