mirror of
https://github.com/mvt-project/mvt.git
synced 2026-09-11 04:08:55 +02:00
Donncha Ó Cearbhaill
eceafdc785
The tests read the settings file of whoever runs them, and importing mvt.common.config writes it back. On a machine whose config.yaml sets NETWORK_ACCESS_ALLOWED to false, the plugin update and URL batch tests fail before their mocked requests are reached, and every Command run in the suite parses the indicators downloaded on that machine, which made the suite take minutes instead of seconds. MVT_CONFIG_FOLDER and MVT_DATA_FOLDER in the environment now relocate the settings file and the downloaded indicators with their update-check state. The test conftest points both at a throwaway folder before any mvt module is imported, and removes it at exit. Subprocesses started by the tests inherit the variables; the isolated interpreter helper already gives them a temporary home. On the machine that prompted this the suite goes from 6 failures in six minutes to none in seven seconds, and config.yaml is left alone.
109 lines
3.7 KiB
Python
109 lines
3.7 KiB
Python
# Mobile Verification Toolkit (MVT)
|
|
# Copyright (c) 2021-2023 The MVT Authors.
|
|
# Use of this software is governed by the MVT License 1.1 that can be found at
|
|
# https://license.mvt.re/1.1/
|
|
|
|
import atexit
|
|
import logging
|
|
import os
|
|
import shutil
|
|
import tempfile
|
|
|
|
import pytest
|
|
|
|
from .artifacts.generate_stix import generate_test_stix_file
|
|
|
|
# The suite must neither read nor write the developer's own MVT settings,
|
|
# downloaded indicators or update-check state, and mvt.common.config saves
|
|
# the settings file as soon as it is imported. Both folders are redirected
|
|
# before any mvt module is imported, which is why this file imports none at
|
|
# the top; the subprocesses the tests start inherit the variables.
|
|
MVT_TEST_HOME = tempfile.mkdtemp(prefix="mvt-tests-")
|
|
atexit.register(shutil.rmtree, MVT_TEST_HOME, ignore_errors=True)
|
|
os.environ["MVT_CONFIG_FOLDER"] = os.path.join(MVT_TEST_HOME, "config")
|
|
os.environ["MVT_DATA_FOLDER"] = os.path.join(MVT_TEST_HOME, "data")
|
|
|
|
|
|
@pytest.fixture(scope="session", autouse=True)
|
|
def indicator_file(request, tmp_path_factory):
|
|
indicator_dir = tmp_path_factory.mktemp("indicators")
|
|
stix_path = indicator_dir / "indicators.stix2"
|
|
generate_test_stix_file(stix_path)
|
|
return str(stix_path)
|
|
|
|
|
|
@pytest.fixture(scope="session", autouse=True)
|
|
def clean_test_env(request, tmp_path_factory):
|
|
try:
|
|
del os.environ["MVT_STIX2"]
|
|
except KeyError:
|
|
pass
|
|
|
|
|
|
@pytest.fixture()
|
|
def indicators_factory(indicator_file):
|
|
def f(
|
|
domains=[],
|
|
emails=[],
|
|
file_names=[],
|
|
file_paths=[],
|
|
processes=[],
|
|
app_ids=[],
|
|
app_cert_hashes=[],
|
|
android_property_names=[],
|
|
files_sha256=[],
|
|
):
|
|
from mvt.common.indicators import Indicators
|
|
|
|
ind = Indicators(log=logging.getLogger())
|
|
ind.parse_stix2(indicator_file)
|
|
|
|
ind.ioc_collections[0]["domains"].extend(domains)
|
|
ind.ioc_collections[0]["emails"].extend(emails)
|
|
ind.ioc_collections[0]["file_names"].extend(file_names)
|
|
ind.ioc_collections[0]["file_paths"].extend(file_paths)
|
|
ind.ioc_collections[0]["processes"].extend(processes)
|
|
ind.ioc_collections[0]["app_ids"].extend(app_ids)
|
|
ind.ioc_collections[0]["android_property_names"].extend(android_property_names)
|
|
ind.ioc_collections[0]["files_sha256"].extend(files_sha256)
|
|
ind.ioc_collections[0]["app_cert_hashes"].extend(app_cert_hashes)
|
|
|
|
return ind
|
|
|
|
return f
|
|
|
|
|
|
@pytest.fixture()
|
|
def restore_cli_commands(monkeypatch):
|
|
"""Keep the external commands a test registers out of the next test.
|
|
|
|
Each CLI group is a module-level object shared by every test, so a test
|
|
registering plugin or environment commands on one has to put it back. The
|
|
groups are imported here rather than at the top of the file, so that
|
|
collecting the tests does not import three CLIs for the sake of one
|
|
fixture.
|
|
"""
|
|
from mvt.android.cli import cli as android_cli
|
|
from mvt.cli import cli as neutral_cli
|
|
from mvt.common.cli_plugins import (
|
|
MVT_ANDROID_CUSTOM_COMMANDS_ENV,
|
|
MVT_CUSTOM_COMMANDS_ENV,
|
|
MVT_IOS_CUSTOM_COMMANDS_ENV,
|
|
)
|
|
from mvt.ios.cli import cli as ios_cli
|
|
|
|
groups = (neutral_cli, ios_cli, android_cli)
|
|
for variable in (
|
|
MVT_CUSTOM_COMMANDS_ENV,
|
|
MVT_IOS_CUSTOM_COMMANDS_ENV,
|
|
MVT_ANDROID_CUSTOM_COMMANDS_ENV,
|
|
):
|
|
monkeypatch.delenv(variable, raising=False)
|
|
originals = [dict(group.commands) for group in groups]
|
|
yield
|
|
for group, commands in zip(groups, originals):
|
|
group.commands.clear()
|
|
group.commands.update(commands)
|
|
if hasattr(group, "_mvt_external_command_sources"):
|
|
delattr(group, "_mvt_external_command_sources")
|