mirror of
https://github.com/mvt-project/mvt.git
synced 2026-11-19 02:14:25 +01:00
A wrong password typed at the prompt ended the check with "Invalid backup password", and check-androidqf skipped the backup modules. An analyst who was handed several candidate passwords had to start the whole run again for each one. Ask for the password again, up to three attempts in total. A password given with --backup-password or in the environment is not asked for again, as before, so scripted runs fail the same way. Fixes #979
140 lines
5.1 KiB
Python
140 lines
5.1 KiB
Python
# Mobile Verification Toolkit (MVT)
|
|
# Copyright (c) 2021-2023 The MVT Authors.
|
|
# Use of this software is governed by the MVT License 1.1 that can be found at
|
|
# https://license.mvt.re/1.1/
|
|
|
|
import logging
|
|
import os
|
|
|
|
from click.testing import CliRunner
|
|
|
|
from mvt.android.cli import check_backup
|
|
from mvt.common.config import settings
|
|
|
|
from .utils import get_artifact_folder
|
|
|
|
TEST_BACKUP_PASSWORD = "123456"
|
|
|
|
|
|
class TestCheckAndroidBackupCommand:
|
|
def test_check_encrypted_backup_prompt_valid(self, mocker):
|
|
"""Prompt for password on CLI"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
return_value=TEST_BACKUP_PASSWORD,
|
|
)
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
result = runner.invoke(check_backup, [path])
|
|
|
|
assert prompt_mock.call_count == 1
|
|
assert result.exit_code == 0
|
|
|
|
def test_check_encrypted_backup_cli(self, mocker):
|
|
"""Provide password as CLI argument"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
return_value=TEST_BACKUP_PASSWORD,
|
|
)
|
|
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
result = runner.invoke(
|
|
check_backup, ["--backup-password", TEST_BACKUP_PASSWORD, path]
|
|
)
|
|
|
|
assert prompt_mock.call_count == 0
|
|
assert result.exit_code == 0
|
|
|
|
def test_check_encrypted_backup_cli_invalid(self, mocker, caplog):
|
|
"""Provide password as CLI argument"""
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
|
|
with caplog.at_level(logging.CRITICAL):
|
|
result = runner.invoke(
|
|
check_backup, ["--backup-password", "invalid_password", path]
|
|
)
|
|
|
|
assert result.exit_code == 1
|
|
assert "Invalid backup password" in caplog.text
|
|
|
|
def test_check_encrypted_backup_prompt_retry(self, mocker):
|
|
"""A wrong password at the prompt is asked for again"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
side_effect=["wrong_password", TEST_BACKUP_PASSWORD],
|
|
)
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
result = runner.invoke(check_backup, [path])
|
|
|
|
assert prompt_mock.call_count == 2
|
|
assert result.exit_code == 0
|
|
|
|
def test_check_encrypted_backup_prompt_gives_up(self, mocker, caplog):
|
|
"""The prompt gives up after three wrong passwords"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
return_value="wrong_password",
|
|
)
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
|
|
with caplog.at_level(logging.CRITICAL):
|
|
result = runner.invoke(check_backup, [path])
|
|
|
|
assert prompt_mock.call_count == 3
|
|
assert result.exit_code == 1
|
|
assert "Invalid backup password" in caplog.text
|
|
|
|
def test_check_encrypted_backup_prompt_retry_empty(self, mocker, caplog):
|
|
"""An empty answer on a retry ends the check"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
side_effect=["wrong_password", ""],
|
|
)
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
|
|
with caplog.at_level(logging.CRITICAL):
|
|
result = runner.invoke(check_backup, [path])
|
|
|
|
assert prompt_mock.call_count == 2
|
|
assert result.exit_code == 1
|
|
assert "No backup password provided" in caplog.text
|
|
|
|
def test_check_encrypted_backup_cli_invalid_no_prompt(self, mocker):
|
|
"""A password given on the command line is not asked for again"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
return_value=TEST_BACKUP_PASSWORD,
|
|
)
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
result = runner.invoke(
|
|
check_backup, ["--backup-password", "invalid_password", path]
|
|
)
|
|
|
|
assert prompt_mock.call_count == 0
|
|
assert result.exit_code == 1
|
|
|
|
def test_check_encrypted_backup_env(self, mocker):
|
|
"""Provide password as environment variable"""
|
|
prompt_mock = mocker.patch(
|
|
"mvt.android.modules.backup.helpers.prompt_password",
|
|
return_value=TEST_BACKUP_PASSWORD,
|
|
)
|
|
|
|
os.environ["MVT_ANDROID_BACKUP_PASSWORD"] = TEST_BACKUP_PASSWORD
|
|
settings.__init__() # Reset settings
|
|
|
|
runner = CliRunner()
|
|
path = os.path.join(get_artifact_folder(), "androidqf_encrypted/backup.ab")
|
|
result = runner.invoke(check_backup, [path])
|
|
|
|
assert prompt_mock.call_count == 0
|
|
assert result.exit_code == 0
|
|
del os.environ["MVT_ANDROID_BACKUP_PASSWORD"]
|
|
settings.__init__() # Reset settings
|