From 98759701e4b2f10caa7fbf8eba4eb4f4e94f7673 Mon Sep 17 00:00:00 2001
From: Ricardo Espinoza <ricardo@n8n.io>
Date: Fri, 11 Oct 2024 09:36:27 -0400
Subject: [PATCH] fix(editor): Disable Ask AI button in deprecated nodes
 (no-changelog) (#11194)

---
 .../AskAssistantChat.spec.ts.snap             |  2 ++
 .../InlineAskAssistantButton.vue              |  1 +
 .../src/components/Error/NodeErrorView.vue    |  8 ++++-
 .../Error/__tests__/NodeErrorView.test.ts     | 33 +++++++++++++++++++
 4 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/packages/design-system/src/components/AskAssistantChat/__tests__/__snapshots__/AskAssistantChat.spec.ts.snap b/packages/design-system/src/components/AskAssistantChat/__tests__/__snapshots__/AskAssistantChat.spec.ts.snap
index 79b57d2d17..891c10abf6 100644
--- a/packages/design-system/src/components/AskAssistantChat/__tests__/__snapshots__/AskAssistantChat.spec.ts.snap
+++ b/packages/design-system/src/components/AskAssistantChat/__tests__/__snapshots__/AskAssistantChat.spec.ts.snap
@@ -840,6 +840,7 @@ exports[`AskAssistantChat > renders default placeholder chat correctly 1`] = `
             For specific tasks, you’ll see the 
             <button
               class="button"
+              data-test-id="ask-assistant-button"
               style="height: 18px;"
               tabindex="-1"
             >
@@ -1082,6 +1083,7 @@ exports[`AskAssistantChat > renders end of session chat correctly 1`] = `
             </span>
             <button
               class="button"
+              data-test-id="ask-assistant-button"
               style="height: 18px;"
               tabindex="-1"
             >
diff --git a/packages/design-system/src/components/InlineAskAssistantButton/InlineAskAssistantButton.vue b/packages/design-system/src/components/InlineAskAssistantButton/InlineAskAssistantButton.vue
index a80de28d8c..49b6d4b325 100644
--- a/packages/design-system/src/components/InlineAskAssistantButton/InlineAskAssistantButton.vue
+++ b/packages/design-system/src/components/InlineAskAssistantButton/InlineAskAssistantButton.vue
@@ -50,6 +50,7 @@ const onClick = () => {
 		:style="{ height: sizes[size].height }"
 		:disabled="asked"
 		:tabindex="static ? '-1' : ''"
+		data-test-id="ask-assistant-button"
 		@click="onClick"
 	>
 		<div>
diff --git a/packages/editor-ui/src/components/Error/NodeErrorView.vue b/packages/editor-ui/src/components/Error/NodeErrorView.vue
index 749cc203e4..76965f0632 100644
--- a/packages/editor-ui/src/components/Error/NodeErrorView.vue
+++ b/packages/editor-ui/src/components/Error/NodeErrorView.vue
@@ -121,7 +121,8 @@ const isAskAssistantAvailable = computed(() => {
 		return false;
 	}
 	const isCustomNode = node.value.type === undefined || isCommunityPackageName(node.value.type);
-	return assistantStore.canShowAssistantButtonsOnCanvas && !isCustomNode;
+
+	return assistantStore.canShowAssistantButtonsOnCanvas && !isCustomNode && !nodeIsHidden();
 });
 
 const assistantAlreadyAsked = computed(() => {
@@ -384,6 +385,11 @@ function copySuccess() {
 	});
 }
 
+function nodeIsHidden() {
+	const nodeType = nodeTypesStore.getNodeType(node?.value.type);
+	return nodeType?.hidden ?? false;
+}
+
 async function onAskAssistantClick() {
 	const { message, lineNumber, description } = props.error;
 	const sessionInProgress = !assistantStore.isSessionEnded;
diff --git a/packages/editor-ui/src/components/Error/__tests__/NodeErrorView.test.ts b/packages/editor-ui/src/components/Error/__tests__/NodeErrorView.test.ts
index 9d33bc3414..0813b2a781 100644
--- a/packages/editor-ui/src/components/Error/__tests__/NodeErrorView.test.ts
+++ b/packages/editor-ui/src/components/Error/__tests__/NodeErrorView.test.ts
@@ -4,6 +4,8 @@ import NodeErrorView from '@/components/Error/NodeErrorView.vue';
 import { STORES } from '@/constants';
 import { createTestingPinia } from '@pinia/testing';
 import { type INode } from 'n8n-workflow';
+import { useAssistantStore } from '@/stores/assistant.store';
+import { useNodeTypesStore } from '@/stores/nodeTypes.store';
 
 const DEFAULT_SETUP = {
 	pinia: createTestingPinia({
@@ -63,4 +65,35 @@ describe('NodeErrorView.vue', () => {
 
 		expect(errorMessage).toHaveTextContent('Unexpected identifier [line 1]');
 	});
+
+	it('should not render AI assistant button when error happens in deprecated function node', async () => {
+		const aiAssistantStore = useAssistantStore(DEFAULT_SETUP.pinia);
+		const nodeTypeStore = useNodeTypesStore(DEFAULT_SETUP.pinia);
+
+		//@ts-expect-error
+		nodeTypeStore.getNodeType = vi.fn(() => ({
+			type: 'n8n-nodes-base.function',
+			typeVersion: 1,
+			hidden: true,
+		}));
+
+		//@ts-expect-error
+		aiAssistantStore.canShowAssistantButtonsOnCanvas = true;
+
+		const { queryByTestId } = renderComponent({
+			props: {
+				error: {
+					node: {
+						...mockNode,
+						type: 'n8n-nodes-base.function',
+						typeVersion: 1,
+					},
+				},
+			},
+		});
+
+		const aiAssistantButton = queryByTestId('ask-assistant-button');
+
+		expect(aiAssistantButton).toBeNull();
+	});
 });