22bdb0568e
refactor(editor): Fix remaining FE type check errors (no-changelog) ( #9607 )
...
Co-authored-by: Alex Grozav <alex@grozav.com >
2024-06-10 16:23:06 +03:00
+6
596c472ecc
feat: RBAC ( #8922 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
Co-authored-by: Val <68596159+valya@users.noreply.github.com >
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in >
Co-authored-by: Valya Bullions <valya@n8n.io >
Co-authored-by: Danny Martini <danny@n8n.io >
Co-authored-by: Danny Martini <despair.blue@gmail.com >
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
Co-authored-by: Omar Ajoue <krynble@gmail.com >
Co-authored-by: oleg <me@olegivaniv.com >
Co-authored-by: Michael Kret <michael.k@radency.com >
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com >
Co-authored-by: Elias Meire <elias@meire.dev >
Co-authored-by: Giulio Andreini <andreini@netseven.it >
Co-authored-by: Giulio Andreini <g.andreini@gmail.com >
Co-authored-by: Ayato Hayashi <go12limchangyong@gmail.com >
2024-05-17 10:53:15 +02:00
Iván Ovejero and GitHub
b8ab049932
refactor(core, editor): Remove legacy nodesAccess (no-changelog) ( #9016 )
2024-04-05 13:17:34 +02:00
Milorad FIlipović and GitHub
2aed788dc3
feat(editor): Send template id as string in all telemetry events ( #8498 )
2024-01-31 13:34:11 +01:00
Milorad FIlipović and GitHub
327cc8df73
fix(editor): Send template id as a number in telemetry events ( #8484 )
2024-01-30 10:37:06 +01:00
Tomi Turtiainen and GitHub
135553bd6b
feat: Redirect users without feature flag from template cred setup (no-changelog) ( #8302 )
2024-01-12 12:10:39 +02:00
Tomi Turtiainen and GitHub
d877d3ce92
fix: Adjust cred setup telemetry (no-changelog) ( #8294 )
2024-01-10 19:41:25 +02:00
Tomi Turtiainen and GitHub
7899f7aca5
fix: Adjust telemetry from canvas (no-changelog) ( #8252 )
2024-01-08 13:56:16 +02:00
Tomi Turtiainen and GitHub
3cf6704dbb
feat: Enable cred setup for workflows created from templates (no-changelog) ( #8240 )
...
## Summary
Enable users to open credential setup for workflows that have been
created from templates if they skip it.
Next steps (will be their own PRs):
- Add telemetry events
- Add e2e test
- Hide the button when user sets up all the credentials
- Change the feature flag to a new one
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1637/feature-support-template-credential-setup-for-http-request-nodes-that
2024-01-05 18:07:57 +02:00
Tomi Turtiainen and GitHub
6e78d2346e
fix: Adjust 'use template' feature telemetry (no-changelog) ( #8232 )
...
- Add extra params to 'User closed cred setup' event
- Fire 'User closed cred setup' only when template has creds
- Skip cred setup page if template has no creds required
- Fire 'User inserted workflow template' also in cred setup
2024-01-05 11:52:10 +02:00
Tomi Turtiainen and GitHub
cd3f5b5b1f
fix: Fix template credential setup for nodes that dont have credentials ( #8208 )
...
Fix template credential setup for templates whose workflow includes
nodes that require credentials but the workflow definition does not have
them defined. Like for example
https://n8n.io/workflows/1344-save-email-attachments-to-nextcloud/
2024-01-04 10:21:36 +02:00
कारतोफ्फेलस्क्रिप्ट™ and GitHub
68cff4c59e
refactor(editor): Improve linting for component and prop names (no-changelog) ( #8169 )
2023-12-28 09:49:58 +01:00
Tomi Turtiainen and GitHub
a3ca7c7acd
fix: Disable continue button unless at least 1 cred has been filled (no-changelog) ( #7959 )
...
Disable the continue button in template credential setup unless at least
one credential has been (pre-)filled
2023-12-07 19:35:34 +02:00
Tomi Turtiainen and GitHub
dc1f14b0be
fix(editor): Send correct telemetry events in credential setup (no-changelog) ( #7926 )
...
Send the `User opened cred setup` and `User closed cred setup` events
specified
[here](https://www.notion.so/n8n/Handoff-a1150c38f6e042db91fdf61c56900967?pvs=4 )
2023-12-07 17:25:33 +02:00
Tomi Turtiainen and GitHub
b63f9cc533
feat(editor): Add user opened cred modal telemetry event (no-changelog) ( #7927 )
...
## Summary
Add `User opened Credential modal` telemetry event to the template
credential setup page, as specified
[here](https://www.notion.so/n8n/Handoff-a1150c38f6e042db91fdf61c56900967?pvs=4 )
2023-12-07 16:05:43 +02:00
Alex Grozav and GitHub
885dba6f12
refactor: Migrate externalHooks mixin to composables (no-changelog) ( #7930 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
As part of NodeView refactor, this PR migrates all externalHooks calls
to `useExternalHooks` composable.
#### How to test the change:
1. Run using env `export N8N_DEPLOYMENT_TYPE=cloud`
2. Hooks should still run as expected
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/N8N-6349/externalhooks
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-06 17:28:09 +02:00
Tomi Turtiainen and GitHub
6448d4c8a5
fix(editor): Tune credential template layout (no-changelog) ( #7903 )
...
Add max width to the content and scale it based on that
2023-12-04 15:27:38 +02:00
Tomi Turtiainen and GitHub
a78729b12f
feat(editor): Allow partial template credential setup (no-changelog) ( #7899 )
...
Enable continue button even if all credentials havent been setup
2023-12-04 09:30:34 +02:00
Tomi Turtiainen and GitHub
38e4b56280
fix(editor): Tune styles of template credential setup (no-changelog) ( #7898 )
2023-12-01 16:00:48 +02:00
Tomi Turtiainen and GitHub
f8e93b3852
fix: Fix credential setup for templates with unnamed credentials (no-changelog) ( #7891 )
...
The template credentials were matched before solely based on the
credential name on the template. This fixes the matching to use both
credential type name and credential name.
2023-12-01 14:56:51 +02:00
Tomi Turtiainen and GitHub
fe3417a615
feat(editor): Select credentials in template setup if theres only one ( #7879 )
...
Automatically select credentials in the template credential setup if
there's only one available.
NOTE! This feature is still behind a feature flag. To test, set:
```js
localStorage.setItem('template-credentials-setup', 'true')
```
https://github.com/n8n-io/n8n/assets/10324676/edc1f586-214f-4c37-b7ec-dd1786433dc1
2023-11-30 15:46:14 +02:00
कारतोफ्फेलस्क्रिप्ट™ and GitHub
753cbc1e96
refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) ( #7838 )
2023-11-28 12:15:08 +01:00
Tomi Turtiainen and GitHub
ac744d6702
test: Ado 1296 add e2e tests ( #7792 )
...
Adds e2e tests for the template credential setup.
2023-11-27 17:18:10 +02:00
Tomi Turtiainen and GitHub
aae45b043b
feat: Ado 1296 spike credential setup in templates ( #7786 )
...
- Add a 'Setup template credentials' view to setup the credentials of a
template before it is created
2023-11-27 16:30:28 +02:00
