From 3208fdd532ce8e91f04d4bc947a764e345727b71 Mon Sep 17 00:00:00 2001
From: Abdullah Atta <abdullahatta@streetwriters.co>
Date: Sat, 9 Sep 2023 20:36:05 +0500
Subject: [PATCH] identity: allow twilio errors to propagate

---
 Streetwriters.Identity/Services/SMSSender.cs | 24 +++++---------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/Streetwriters.Identity/Services/SMSSender.cs b/Streetwriters.Identity/Services/SMSSender.cs
index 13515f1..6fd1887 100644
--- a/Streetwriters.Identity/Services/SMSSender.cs
+++ b/Streetwriters.Identity/Services/SMSSender.cs
@@ -36,10 +36,6 @@ namespace Streetwriters.Identity.Services
         private Client client;
         public SMSSender()
         {
-            if (!string.IsNullOrEmpty(Constants.MESSAGEBIRD_ACCESS_KEY))
-                client = Client.CreateDefault(Constants.MESSAGEBIRD_ACCESS_KEY);
-
-
             if (!string.IsNullOrEmpty(Constants.TWILIO_ACCOUNT_SID) && !string.IsNullOrEmpty(Constants.TWILIO_AUTH_TOKEN))
             {
                 TwilioClient.Init(Constants.TWILIO_ACCOUNT_SID, Constants.TWILIO_AUTH_TOKEN);
@@ -48,20 +44,12 @@ namespace Streetwriters.Identity.Services
 
         public async Task<string> SendOTPAsync(string number, IClient app)
         {
-            try
-            {
-                var verification = await VerificationResource.CreateAsync(
-                    to: number,
-                    channel: "sms",
-                    pathServiceSid: Constants.TWILIO_SERVICE_SID
-                );
-                return verification.Sid;
-            }
-            catch (Exception ex)
-            {
-
-            }
-            return null;
+            var verification = await VerificationResource.CreateAsync(
+                to: number,
+                channel: "sms",
+                pathServiceSid: Constants.TWILIO_SERVICE_SID
+            );
+            return verification.Sid;
         }
 
         public async Task<bool> VerifyOTPAsync(string id, string code)