From beb4ce46f1bb88af707c9fc07b889e9d59edfe98 Mon Sep 17 00:00:00 2001
From: Praveen Thirumurugan <mail@praveent.com>
Date: Sat, 27 Dec 2025 20:22:56 +0000
Subject: [PATCH] refactor: use Number.parseInt/Number.isNaN for numeric
 parsing across API and UI

Co-authored-by: Genie <genie@cosine.sh>
---
 dashboard/app/api/metrics/route.ts      | 14 +++++++-------
 dashboard/app/page.tsx                  |  2 +-
 dashboard/components/ModelBreakdown.tsx |  4 ++--
 dashboard/components/TrendsChart.tsx    |  4 ++--
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/dashboard/app/api/metrics/route.ts b/dashboard/app/api/metrics/route.ts
index 7261492..d14b774 100644
--- a/dashboard/app/api/metrics/route.ts
+++ b/dashboard/app/api/metrics/route.ts
@@ -11,12 +11,12 @@ export async function GET(request: NextRequest) {
   const { searchParams } = new URL(request.url);
 
   // Validate and sanitize hours parameter
-  const hoursParam = parseInt(searchParams.get('hours') || '24', 10);
-  const hours = !isNaN(hoursParam) && hoursParam > 0 && hoursParam <= 720 ? hoursParam : 24;
+  const hoursParam = Number.parseInt(searchParams.get('hours') || '24', 10);
+  const hours = !Number.isNaN(hoursParam) && hoursParam > 0 && hoursParam <= 720 ? hoursParam : 24;
 
   // Validate and sanitize limit parameter
-  const limitParam = parseInt(searchParams.get('limit') || '100', 10);
-  const limit = !isNaN(limitParam) && limitParam > 0 && limitParam <= 1000 ? limitParam : 100;
+  const limitParam = Number.parseInt(searchParams.get('limit') || '100', 10);
+  const limit = !Number.isNaN(limitParam) && limitParam > 0 && limitParam <= 1000 ? limitParam : 100;
 
   try {
     const client = await pool.connect();
@@ -95,11 +95,11 @@ export async function GET(request: NextRequest) {
         success: true,
         data: {
           summary: {
-            totalRequests: parseInt(summary.total_requests ?? '0'),
-            totalTokens: parseInt(summary.total_tokens_used ?? '0'),
+            totalRequests: Number.parseInt(summary.total_requests ?? '0'),
+            totalTokens: Number.parseInt(summary.total_tokens_used ?? '0'),
             totalCost: parseFloat(summary.total_cost ?? '0'),
             avgResponseTime: parseFloat(summary.avg_response_time ?? '0'),
-            uniqueModels: parseInt(summary.unique_models ?? '0'),
+            uniqueModels: Number.parseInt(summary),
             uniqueClients: parseInt(summary.unique_clients ?? '0'),
           },
           recentRequests,
diff --git a/dashboard/app/page.tsx b/dashboard/app/page.tsx
index 331a627..3b27812 100644
--- a/dashboard/app/page.tsx
+++ b/dashboard/app/page.tsx
@@ -97,7 +97,7 @@ export default function Dashboard() {
         <div style={styles.controls}>
           <select
             value={timeRange}
-            onChange={(e) => setTimeRange(parseInt(e.target.value))}
+            onChange={(e) => setTimeRange(Number.parseInt(e.target.value))}
             style={styles.select}
           >
             <option value={1}>Last Hour</option>
diff --git a/dashboard/components/ModelBreakdown.tsx b/dashboard/components/ModelBreakdown.tsx
index 9a9b420..9de3074 100644
--- a/dashboard/components/ModelBreakdown.tsx
+++ b/dashboard/components/ModelBreakdown.tsx
@@ -40,8 +40,8 @@ export default function ModelBreakdown({ models }: ModelBreakdownProps) {
                 <td style={styles.td}>
                   <strong>{model.model}</strong>
                 </td>
-                <td style={styles.td}>{parseInt(model.request_count).toLocaleString()}</td>
-                <td style={styles.td}>{parseInt(model.total_tokens).toLocaleString()}</td>
+                <td style={styles.td}>{Number.parseInt(model.request_count).toLocaleString()}</td>
+                <td style={styles.td}>{Number.parseInt(model.total_tokens).toLocaleString()}</td>
                 <td style={styles.td}>${parseFloat(model.total_cost).toFixed(4)}</td>
                 <td style={styles.td}>{Math.round(parseFloat(model.avg_response_time))}ms</td>
               </tr>
diff --git a/dashboard/components/TrendsChart.tsx b/dashboard/components/TrendsChart.tsx
index 67f6473..f9a6389 100644
--- a/dashboard/components/TrendsChart.tsx
+++ b/dashboard/components/TrendsChart.tsx
@@ -39,8 +39,8 @@ export default function TrendsChart({ trends }: TrendsChartProps) {
       day: 'numeric',
       hour: '2-digit',
     }),
-    requests: parseInt(trend.requests),
-    tokens: parseInt(trend.tokens),
+    requests: Number.parseInt(trend.requests),
+    tokens: Number.parseInt(trend.tokens),
     cost: parseFloat(trend.cost),
     responseTime: Math.round(parseFloat(trend.avg_response_time)),
   }));