diff --git a/CHANGES.md b/CHANGES.md index 61e7fde3c3..52816e2c57 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,11 @@ # CHANGELOG +## 1.12.4-beta + +### :bug: Bugs fixed + +- Fix crash on iOS when displaying viewer [#1522](https://github.com/penpot/penpot/issues/1522) + ## 1.12.3-beta ### :bug: Bugs fixed diff --git a/frontend/src/app/main/ui/viewer.cljs b/frontend/src/app/main/ui/viewer.cljs index 144c472d9b..917a0c9d71 100644 --- a/frontend/src/app/main/ui/viewer.cljs +++ b/frontend/src/app/main/ui/viewer.cljs @@ -152,7 +152,7 @@ (mf/deps fullscreen?) (fn [] ;; Trigger dom fullscreen depending on our state - (let [wrapper (dom/get-element "viewer-layout") + (let [wrapper (dom/get-element "viewer-layout") fullscreen-dom? (dom/fullscreen?)] (when (not= fullscreen? fullscreen-dom?) (if fullscreen? diff --git a/frontend/src/app/util/dom.cljs b/frontend/src/app/util/dom.cljs index 15cbf004ef..4398e9da81 100644 --- a/frontend/src/app/util/dom.cljs +++ b/frontend/src/app/util/dom.cljs @@ -6,13 +6,15 @@ (ns app.util.dom (:require - [app.common.exceptions :as ex] - [app.common.geom.point :as gpt] - [app.util.globals :as globals] - [app.util.object :as obj] - [cuerdas.core :as str] - [goog.dom :as dom] - [promesa.core :as p])) + [app.common.geom.point :as gpt] + [app.common.logging :as log] + [app.util.globals :as globals] + [app.util.object :as obj] + [cuerdas.core :as str] + [goog.dom :as dom] + [promesa.core :as p])) + +(log/set-level! :warn) ;; --- Deprecated methods @@ -289,8 +291,9 @@ (boolean (.-fullscreenElement globals/document)) :else - (ex/raise :type :not-supported - :hint "seems like the current browser does not support fullscreen api."))) + (do + (log/error :msg "Seems like the current browser does not support fullscreen api.") + false))) (defn ^boolean blob? [^js v] diff --git a/frontend/src/app/util/webapi.cljs b/frontend/src/app/util/webapi.cljs index 643d6d618f..b56ac91a7a 100644 --- a/frontend/src/app/util/webapi.cljs +++ b/frontend/src/app/util/webapi.cljs @@ -8,11 +8,13 @@ "HTML5 web api helpers." (:require [app.common.data :as d] - [app.common.exceptions :as ex] + [app.common.logging :as log] [app.util.object :as obj] [beicon.core :as rx] [cuerdas.core :as str])) +(log/set-level! :warn) + (defn- file-reader [f] (rx/create @@ -114,8 +116,9 @@ (.webkitRequestFullscreen el) :else - (ex/raise :type :not-supported - :hint "seems like the current browser does not support fullscreen api."))) + (do + (log/error :msg "Seems like the current browser does not support fullscreen api.") + false))) (defn exit-fullscreen [] @@ -127,8 +130,9 @@ (.webkitExitFullscreen js/document) :else - (ex/raise :type :not-supported - :hint "seems like the current browser does not support fullscreen api."))) + (do + (log/error :msg "Seems like the current browser does not support fullscreen api.") + false))) (defn observe-resize [node]