From 3a34eb1357ca38058b2cfbade095fbbb8d2882b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bel=C3=A9n=20Albeza?= Date: Thu, 4 Jul 2024 15:45:50 +0200 Subject: [PATCH] :bug: Fix flakiness of visual workspace test (assets tab) --- frontend/playwright/ui/pages/WorkspacePage.js | 1 + frontend/playwright/ui/visual-specs/workspace.spec.js | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/frontend/playwright/ui/pages/WorkspacePage.js b/frontend/playwright/ui/pages/WorkspacePage.js index 76f0c05341..7e5bf6b36f 100644 --- a/frontend/playwright/ui/pages/WorkspacePage.js +++ b/frontend/playwright/ui/pages/WorkspacePage.js @@ -202,6 +202,7 @@ export class WorkspacePage extends BaseWebSocketPage { async openLibrariesModal(clickOptions = {}) { await this.sidebar.getByText("Libraries").click(clickOptions); + await expect(this.librariesModal).toBeVisible(); } async clickLibrary(name, clickOptions = {}) { diff --git a/frontend/playwright/ui/visual-specs/workspace.spec.js b/frontend/playwright/ui/visual-specs/workspace.spec.js index 42abbcb477..e594ea343f 100644 --- a/frontend/playwright/ui/visual-specs/workspace.spec.js +++ b/frontend/playwright/ui/visual-specs/workspace.spec.js @@ -91,11 +91,14 @@ test.describe("Assets tab", () => { await workspace.goToWorkspace(); await workspace.clickAssets(); await workspace.openLibrariesModal(); - await expect(workspace.page).toHaveScreenshot(); await workspace.clickLibrary("Testing library 1"); - + await expect( + workspace.librariesModal.getByText( + "There are no Shared Libraries available", + ), + ).toBeVisible(); await expect(workspace.page).toHaveScreenshot(); });