From 91efcd17a29f0c96dd6aef4016123788f20fc59e Mon Sep 17 00:00:00 2001 From: Luis de Dios Date: Tue, 25 Feb 2025 10:30:11 +0100 Subject: [PATCH] :bug: Fix design panel does not reappear if comment draft is open --- frontend/src/app/main/data/comments.cljs | 9 ++------- frontend/src/app/main/ui/workspace/viewport.cljs | 3 +-- .../src/app/main/ui/workspace/viewport/comments.cljs | 4 ++-- frontend/src/app/main/ui/workspace/viewport_wasm.cljs | 3 +-- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/frontend/src/app/main/data/comments.cljs b/frontend/src/app/main/data/comments.cljs index 14f973af55..f07758a9cc 100644 --- a/frontend/src/app/main/data/comments.cljs +++ b/frontend/src/app/main/data/comments.cljs @@ -90,7 +90,6 @@ (update :comments-local assoc :open id)) (update :comments-local assoc :options nil) (update :comments-local dissoc :draft) - (update :workspace-drawing dissoc :comment) (update-in [:comments id] assoc (:id comment) comment)))) ptk/WatchEvent @@ -146,7 +145,6 @@ (update :comments-local assoc :open id) (update :comments-local assoc :options nil) (update :comments-local dissoc :draft) - (update :workspace-drawing dissoc :comment) (update-in [:comments id] assoc (:id comment) comment)))) ptk/WatchEvent @@ -474,7 +472,7 @@ (-> state (update :comments-local assoc :open id) (update :comments-local assoc :options nil) - (update :workspace-drawing dissoc :comment))))) + (update :comments-local dissoc :draft))))) (defn close-thread [] @@ -482,8 +480,7 @@ ptk/UpdateEvent (update [_ state] (-> state - (update :comments-local dissoc :open :draft :options) - (update :workspace-drawing dissoc :comment))))) + (update :comments-local dissoc :open :draft :options))))) (defn update-filters [{:keys [mode show list] :as params}] @@ -524,7 +521,6 @@ ptk/UpdateEvent (update [_ state] (-> state - (update :workspace-drawing assoc :comment params) (update :comments-local assoc :draft params))))) (defn update-draft-thread @@ -533,7 +529,6 @@ ptk/UpdateEvent (update [_ state] (-> state - (d/update-in-when [:workspace-drawing :comment] merge data) (d/update-in-when [:comments-local :draft] merge data))))) (defn toggle-comment-options diff --git a/frontend/src/app/main/ui/workspace/viewport.cljs b/frontend/src/app/main/ui/workspace/viewport.cljs index 2a31a10133..d106c28fb5 100644 --- a/frontend/src/app/main/ui/workspace/viewport.cljs +++ b/frontend/src/app/main/ui/workspace/viewport.cljs @@ -304,8 +304,7 @@ :page-id page-id :file-id file-id :vport vport - :zoom zoom - :drawing drawing}]) + :zoom zoom}]) (when picking-color? [:& pixel-overlay/pixel-overlay {:vport vport diff --git a/frontend/src/app/main/ui/workspace/viewport/comments.cljs b/frontend/src/app/main/ui/workspace/viewport/comments.cljs index c68cb9af1b..30a2d6dae0 100644 --- a/frontend/src/app/main/ui/workspace/viewport/comments.cljs +++ b/frontend/src/app/main/ui/workspace/viewport/comments.cljs @@ -16,7 +16,7 @@ [rumext.v2 :as mf])) (mf/defc comments-layer* - [{:keys [vbox vport zoom drawing file-id page-id]}] + [{:keys [vbox vport zoom file-id page-id]}] (let [vbox-x (dm/get-prop vbox :x) vbox-y (dm/get-prop vbox :y) vport-w (dm/get-prop vport :width) @@ -73,7 +73,7 @@ :viewport viewport :zoom zoom}]))) - (when-let [draft (:comment drawing)] + (when-let [draft (:draft local)] [:> cmt/comment-floating-thread-draft* {:draft draft :on-cancel on-draft-cancel diff --git a/frontend/src/app/main/ui/workspace/viewport_wasm.cljs b/frontend/src/app/main/ui/workspace/viewport_wasm.cljs index 3de0c4c9d1..3021a60156 100644 --- a/frontend/src/app/main/ui/workspace/viewport_wasm.cljs +++ b/frontend/src/app/main/ui/workspace/viewport_wasm.cljs @@ -350,8 +350,7 @@ [:> comments/comments-layer* {:vbox vbox :page-id page-id :vport vport - :zoom zoom - :drawing drawing}]) + :zoom zoom}]) (when picking-color? [:& pixel-overlay/pixel-overlay {:vport vport