From d6cc46902779a34ccbaba1144c667f67c2820f75 Mon Sep 17 00:00:00 2001 From: girafic Date: Tue, 17 Mar 2026 15:05:26 +0100 Subject: [PATCH] :bug: Fix permission message and update ruler guide proxy name on plugins api (#8632) - Updated the error message for missing content write permission in the removeRulerGuide function. - Renamed the ruler guide proxy from "RuleGuideProxy" to "RulerGuideProxy" for consistency. - Adjusted variable naming in the addRulerGuide function for clarity. Signed-off-by: Stas Haas --- frontend/src/app/plugins/page.cljs | 2 +- frontend/src/app/plugins/ruler_guides.cljs | 2 +- frontend/src/app/plugins/shape.cljs | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/src/app/plugins/page.cljs b/frontend/src/app/plugins/page.cljs index b0302a1939..c7a946d348 100644 --- a/frontend/src/app/plugins/page.cljs +++ b/frontend/src/app/plugins/page.cljs @@ -331,7 +331,7 @@ (u/display-not-valid :removeRulerGuide "Guide not provided") (not (r/check-permission plugin-id "content:write")) - (u/display-not-valid :removeRulerGuide "Plugin doesn't have 'comment:write' permission") + (u/display-not-valid :removeRulerGuide "Plugin doesn't have 'content:write' permission") :else (let [guide (u/proxy->ruler-guide value)] diff --git a/frontend/src/app/plugins/ruler_guides.cljs b/frontend/src/app/plugins/ruler_guides.cljs index d9c8e7c6c4..c42e148e56 100644 --- a/frontend/src/app/plugins/ruler_guides.cljs +++ b/frontend/src/app/plugins/ruler_guides.cljs @@ -24,7 +24,7 @@ (defn ruler-guide-proxy [plugin-id file-id page-id id] - (obj/reify {:name "RuleGuideProxy"} + (obj/reify {:name "RulerGuideProxy"} :$plugin {:enumerable false :get (constantly plugin-id)} :$file {:enumerable false :get (constantly file-id)} :$page {:enumerable false :get (constantly page-id)} diff --git a/frontend/src/app/plugins/shape.cljs b/frontend/src/app/plugins/shape.cljs index c7730d8a36..29e560bf35 100644 --- a/frontend/src/app/plugins/shape.cljs +++ b/frontend/src/app/plugins/shape.cljs @@ -1267,7 +1267,7 @@ (u/display-not-valid :addRulerGuide "Plugin doesn't have 'content:write' permission") :else - (let [id (uuid/next) + (let [ruler-id (uuid/next) axis (parser/orientation->axis orientation) objects (u/locate-objects file-id page-id) frame (get objects id) @@ -1275,11 +1275,11 @@ position (+ board-pos value)] (st/emit! (dwgu/update-guides - {:id id + {:id ruler-id :axis axis :position position :frame-id id})) - (rg/ruler-guide-proxy plugin-id file-id page-id id))))) + (rg/ruler-guide-proxy plugin-id file-id page-id ruler-id))))) :removeRulerGuide (fn [_ value]