diff --git a/common/src/app/common/files/migrations.cljc b/common/src/app/common/files/migrations.cljc index a0e5ff22bd..d6070cdd9d 100644 --- a/common/src/app/common/files/migrations.cljc +++ b/common/src/app/common/files/migrations.cljc @@ -30,7 +30,6 @@ [app.common.types.path :as path] [app.common.types.path.segment :as path.segment] [app.common.types.shape :as cts] - [app.common.types.shape-tree :as ctsht] [app.common.types.shape.interactions :as ctsi] [app.common.types.shape.shadow :as ctss] [app.common.types.shape.text :as ctst] diff --git a/common/src/app/common/files/validate.cljc b/common/src/app/common/files/validate.cljc index 9b3e1bba64..b7dca6ddfd 100644 --- a/common/src/app/common/files/validate.cljc +++ b/common/src/app/common/files/validate.cljc @@ -713,8 +713,6 @@ ;; PUBLIC API: VALIDATION FUNCTIONS ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; -#_(declare check-swap-slots) - (defn validate-file "Validate full referential integrity and semantic coherence on file data. @@ -725,8 +723,6 @@ (doseq [page (filter :id (ctpl/pages-seq data))] (check-shape uuid/zero file page libraries) - #_(when (str/includes? (:name file) "check-swap-slot") - (check-swap-slots uuid/zero file page libraries)) (->> (get-orphan-shapes page) (run! #(check-shape % file page libraries)))) @@ -767,40 +763,3 @@ :hint "error on validating file referential integrity" :file-id (:id file) :details errors))) - -#_(declare compare-slots) - -;; Optional check to look for missing swap slots. -;; Search for copies that do not point the shape-ref to the near component but don't have swap slot -;; (looking for position relative to the parent, in the copy and the main). -;; -;; This check cannot be generally enabled, because files that have been migrated from components v1 -;; may have copies with shapes that do not match by position, but have not been swapped. So we enable -;; it for specific files only. To activate the check, you need to add the string "check-swap-slot" to -;; the name of the file. -#_(defn- check-swap-slots - [shape-id file page libraries] - (let [shape (ctst/get-shape page shape-id)] - (if (and (ctk/instance-head? shape) (ctk/in-component-copy? shape)) - (let [ref-shape (ctf/find-ref-shape file page libraries shape :include-deleted? true :with-context? true) - container (:container (meta ref-shape))] - (when (some? ref-shape) - (compare-slots shape ref-shape file page container))) - (doall (for [child-id (:shapes shape)] - (check-swap-slots child-id file page libraries)))))) - -#_(defn- compare-slots - [shape-copy shape-main file container-copy container-main] - (if (and (not= (:shape-ref shape-copy) (:id shape-main)) - (nil? (ctk/get-swap-slot shape-copy))) - (report-error :missing-slot - "Shape has been swapped, should have swap slot" - shape-copy file container-copy - :swap-slot (or (ctk/get-swap-slot shape-main) (:id shape-main))) - (when (nil? (ctk/get-swap-slot shape-copy)) - (let [children-id-pairs (d/zip-all (:shapes shape-copy) (:shapes shape-main))] - (doall (for [[child-copy-id child-main-id] children-id-pairs] - (let [child-copy (ctst/get-shape container-copy child-copy-id) - child-main (ctst/get-shape container-main child-main-id)] - (when (and (some? child-copy) (some? child-main)) - (compare-slots child-copy child-main file container-copy container-main))))))))) diff --git a/common/test/common_tests/logic/multiple_nesting_levels_test.cljc b/common/test/common_tests/logic/multiple_nesting_levels_test.cljc index d0337feb8f..eed52c0125 100644 --- a/common/test/common_tests/logic/multiple_nesting_levels_test.cljc +++ b/common/test/common_tests/logic/multiple_nesting_levels_test.cljc @@ -6,20 +6,11 @@ (ns common-tests.logic.multiple-nesting-levels-test (:require - [app.common.files.changes :as ch] - [app.common.files.changes-builder :as pcb] - [app.common.logic.libraries :as cll] - [app.common.logic.shapes :as cls] - [app.common.pprint :as pp] [app.common.test-helpers.components :as thc] [app.common.test-helpers.compositions :as tho] [app.common.test-helpers.files :as thf] [app.common.test-helpers.ids-map :as thi] [app.common.test-helpers.shapes :as ths] - [app.common.types.component :as ctk] - [app.common.types.container :as ctn] - [app.common.types.file :as ctf] - [app.common.uuid :as uuid] [clojure.test :as t])) (t/use-fixtures :each thi/test-fixture) diff --git a/frontend/src/app/main/data/changes.cljs b/frontend/src/app/main/data/changes.cljs index 7cae1add0f..63e076eba0 100644 --- a/frontend/src/app/main/data/changes.cljs +++ b/frontend/src/app/main/data/changes.cljs @@ -23,10 +23,11 @@ [potok.v2.core :as ptk])) ;; Change this to :info :debug or :trace to debug this module -(log/set-level! :info) +(log/set-level! :warn) (def page-change? #{:add-page :mod-page :del-page :mov-page}) + (def update-layout-attr? #{:hidden}) @@ -205,6 +206,7 @@ ;; Prevent commit changes by a viewer team member (it really should never happen) (when (:can-edit permissions) + (log/trace :hint "commit-changes" :redo-changes redo-changes) (rx/of (-> params (assoc :undo-group undo-group) (assoc :features features)