From 1d486f13542ac146b962fea286c9851f3111da73 Mon Sep 17 00:00:00 2001
From: Ronni Skansing <rskansing@gmail.com>
Date: Wed, 3 Jun 2026 21:17:14 +0200
Subject: [PATCH] update build actions and fix frontend warnings

Signed-off-by: Ronni Skansing <rskansing@gmail.com>
---
 .github/workflows/release.yml                 | 10 +-
 .github/workflows/test-build.yml              | 10 +-
 .../lib/components/CampaignCalendar.svelte    |  4 +-
 .../src/lib/components/header/Header.svelte   |  1 -
 .../remote-browser/RemoteBrowserEditor.svelte |  4 +-
 frontend/src/routes/+layout.svelte            |  2 +-
 frontend/src/routes/proxy/+page.svelte        | 91 +++++++++----------
 7 files changed, 57 insertions(+), 65 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 9bc27a6..97b02bc 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -13,20 +13,20 @@ jobs:
       packages: write
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 1
 
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@v4
         with:
           platforms: linux/amd64,linux/arm64
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
 
       - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
@@ -135,7 +135,7 @@ jobs:
               phishingclub.sig
 
       - name: Build and push multi-arch Docker image
-        uses: docker/build-push-action@v5
+        uses: docker/build-push-action@v7
         with:
           context: .
           file: ./Dockerfile.release
diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml
index 4b1434c..4c583e3 100644
--- a/.github/workflows/test-build.yml
+++ b/.github/workflows/test-build.yml
@@ -12,20 +12,20 @@ jobs:
       packages: write
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 1
 
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@v4
         with:
           platforms: linux/amd64,linux/arm64
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
 
       - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
@@ -212,7 +212,7 @@ jobs:
           tar -tzf packages/phishingclub_${{ steps.get_version.outputs.VERSION }}_linux_arm64.tar.gz
 
       - name: Upload build artifacts (for review)
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: phishingclub-test-build-${{ steps.get_version.outputs.HASH }}
           path: |
diff --git a/frontend/src/lib/components/CampaignCalendar.svelte b/frontend/src/lib/components/CampaignCalendar.svelte
index fc80150..a03a832 100644
--- a/frontend/src/lib/components/CampaignCalendar.svelte
+++ b/frontend/src/lib/components/CampaignCalendar.svelte
@@ -9,15 +9,13 @@
 		startOfMonth,
 		endOfMonth,
 		startOfWeek,
-		endOfWeek,
 		startOfDay,
 		endOfDay,
 		addDays,
 		subDays,
 		isSameDay,
 		isSameMonth,
-		getDay,
-		getDaysInMonth
+		getDay
 	} from 'date-fns';
 	import { scrollBarClassesHorizontal, scrollBarClassesVertical } from '$lib/utils/scrollbar';
 
diff --git a/frontend/src/lib/components/header/Header.svelte b/frontend/src/lib/components/header/Header.svelte
index 0b2015e..07fa096 100644
--- a/frontend/src/lib/components/header/Header.svelte
+++ b/frontend/src/lib/components/header/Header.svelte
@@ -9,7 +9,6 @@
 
 	export let isProfileMenuVisible = false;
 	export let isMobileMenuVisible = false;
-	export let toggleChangeCompanyModal;
 
 	let isUpdateAvailable = false;
 	let isInstalled = false;
diff --git a/frontend/src/lib/components/remote-browser/RemoteBrowserEditor.svelte b/frontend/src/lib/components/remote-browser/RemoteBrowserEditor.svelte
index 9b5ebb6..969e0b9 100644
--- a/frontend/src/lib/components/remote-browser/RemoteBrowserEditor.svelte
+++ b/frontend/src/lib/components/remote-browser/RemoteBrowserEditor.svelte
@@ -1077,9 +1077,9 @@ declare var Infinity: number;
 				{#if activeTab === 'config'}
 					<div class="space-y-4">
 						<div>
-							<label class="block text-xs font-medium text-gray-600 dark:text-gray-400 mb-1">
+							<p class="block text-xs font-medium text-gray-600 dark:text-gray-400 mb-1">
 								Browser Mode
-							</label>
+							</p>
 							<div class="flex gap-2">
 								<button
 									type="button"
diff --git a/frontend/src/routes/+layout.svelte b/frontend/src/routes/+layout.svelte
index e26aa6b..6a298b8 100644
--- a/frontend/src/routes/+layout.svelte
+++ b/frontend/src/routes/+layout.svelte
@@ -285,7 +285,7 @@
 	{:else if loginStatus === AppStateService.LOGIN.LOGGED_OUT && $page.route.id === '/login'}
 		<slot />
 	{:else if loginStatus === AppStateService.LOGIN.LOGGED_IN && $page.route.id !== '/login'}
-		<Header bind:isProfileMenuVisible bind:isMobileMenuVisible {toggleChangeCompanyModal} />
+		<Header bind:isProfileMenuVisible bind:isMobileMenuVisible />
 		{#if installState === AppStateService.INSTALL.INSTALLED}
 			<DesktopMenu
 				bind:this={desktopMenuRef}
diff --git a/frontend/src/routes/proxy/+page.svelte b/frontend/src/routes/proxy/+page.svelte
index 0107bb2..7cd2513 100644
--- a/frontend/src/routes/proxy/+page.svelte
+++ b/frontend/src/routes/proxy/+page.svelte
@@ -30,6 +30,7 @@
 	import AutoRefresh from '$lib/components/AutoRefresh.svelte';
 	import TableCellScope from '$lib/components/table/TableCellScope.svelte';
 	import ProxyConfigBuilder from '$lib/components/proxy/ProxyConfigBuilder.svelte';
+	import jsyaml, { dumpWithLiteralStrings } from '$lib/components/yaml/index.js';
 	import FileField from '$lib/components/FileField.svelte';
 
 	// services
@@ -100,34 +101,30 @@
 		}
 
 		try {
-			// dynamically import js-yaml
-			import('$lib/components/yaml/index.js').then((jsyaml) => {
-				const parsed = jsyaml.default.load(yamlStr);
-				if (!parsed || typeof parsed !== 'object') {
-					console.warn('Invalid YAML: not an object');
-					return;
-				}
+			const parsed = jsyaml.load(yamlStr);
+			if (!parsed || typeof parsed !== 'object') {
+				console.warn('Invalid YAML: not an object');
+				return;
+			}
 
-				// extract and apply general section
-				if (parsed._general) {
-					if (parsed._general.name) {
-						formValues.name = parsed._general.name;
-					}
-					if (parsed._general.description) {
-						formValues.description = parsed._general.description;
-					}
-					if (parsed._general.start_url) {
-						formValues.startURL = parsed._general.start_url;
-					}
-					// remove _general from parsed object before serializing back
-					delete parsed._general;
+			// extract and apply general section
+			if (parsed._general) {
+				if (parsed._general.name) {
+					formValues.name = parsed._general.name;
 				}
+				if (parsed._general.description) {
+					formValues.description = parsed._general.description;
+				}
+				if (parsed._general.start_url) {
+					formValues.startURL = parsed._general.start_url;
+				}
+				// remove _general from parsed object before serializing back
+				delete parsed._general;
+			}
 
-				// serialize back to YAML without _meta for the config
-				// use dumpWithLiteralStrings to preserve literal block style for replace/body fields
-				const cleanYaml = jsyaml.dumpWithLiteralStrings(parsed);
-				formValues.proxyConfig = cleanYaml;
-			});
+			// serialize back to YAML without _meta for the config
+			// use dumpWithLiteralStrings to preserve literal block style for replace/body fields
+			formValues.proxyConfig = dumpWithLiteralStrings(parsed);
 		} catch (e) {
 			console.warn('Failed to parse imported YAML config:', e);
 		}
@@ -135,12 +132,11 @@
 
 	// export configuration to YAML file with metadata (for YAML mode)
 	function exportYamlConfig() {
-		import('$lib/components/yaml/index.js').then((yamlModule) => {
-			try {
-				// parse current config
-				const parsed = formValues.proxyConfig
-					? yamlModule.default.load(formValues.proxyConfig) || {}
-					: {};
+		try {
+			// parse current config
+			const parsed = formValues.proxyConfig
+				? jsyaml.load(formValues.proxyConfig) || {}
+				: {};
 
 				// build output with _general first
 				const output = {};
@@ -160,24 +156,23 @@
 				// merge rest of config
 				Object.assign(output, parsed);
 
-				// serialize to YAML with literal block style for replace/body fields
-				const yamlContent = yamlModule.dumpWithLiteralStrings(output);
+			// serialize to YAML with literal block style for replace/body fields
+			const yamlContent = dumpWithLiteralStrings(output);
 
-				// create blob and download
-				const blob = new Blob([yamlContent], { type: 'application/x-yaml' });
-				const url = URL.createObjectURL(blob);
-				const a = document.createElement('a');
-				a.href = url;
-				const safeName = (formValues.name || 'proxy-config').replace(/[^a-zA-Z0-9-_]/g, '_');
-				a.download = `${safeName}.yaml`;
-				document.body.appendChild(a);
-				a.click();
-				document.body.removeChild(a);
-				URL.revokeObjectURL(url);
-			} catch (e) {
-				console.warn('Failed to export YAML config:', e);
-			}
-		});
+			// create blob and download
+			const blob = new Blob([yamlContent], { type: 'application/x-yaml' });
+			const url = URL.createObjectURL(blob);
+			const a = document.createElement('a');
+			a.href = url;
+			const safeName = (formValues.name || 'proxy-config').replace(/[^a-zA-Z0-9-_]/g, '_');
+			a.download = `${safeName}.yaml`;
+			document.body.appendChild(a);
+			a.click();
+			document.body.removeChild(a);
+			URL.revokeObjectURL(url);
+		} catch (e) {
+			console.warn('Failed to export YAML config:', e);
+		}
 	}
 
 	// trigger file input for YAML mode import