CalvinBackup/sd-webui-faceswaplab
1
0
Fork 0
Code Issues 56 Pull Requests 4 Actions Packages Projects Releases 8 Wiki Activity

Allow faceswaplab to run before other extensions #154

New Issue
Open
opened 2023-11-16 14:21:38 +01:00 by hassan-sd · 2 comments
hassan-sd commented 2023-11-16 14:21:38 +01:00 (Migrated from github.com)
Copy Link
Copy Source

With Reactor, I can rename the extension folder to _sd-webui-reactor which allows me to perform a faceswap directly after the image is generated but before other extensions like Adetailer.

When I try to rename faceswaplab it doesn't make a difference, it always runs last, after Adetailer has run.

The benefit of running before Adetailer means I can do a faceswap and enhance the details with my adetailer ultralytics models such as eyes/face/hair etc. on the already faceswapped image.
The faceswaplab "post processing" isn't as sufficient as using Adetailer to perform enhancements to specific areas.

Request
Allow a custom setting so we can choose to run faceswaplab at different stages of the image creation process in txt2img, such as 1st or last.

With Reactor, I can rename the extension folder to` _sd-webui-reactor` which allows me to perform a faceswap directly after the image is generated but _before_ other extensions like Adetailer. When I try to rename faceswaplab it doesn't make a difference, it always runs last, after Adetailer has run. The benefit of running before Adetailer means I can do a faceswap and enhance the details with my adetailer ultralytics models such as eyes/face/hair etc. on the already faceswapped image. The faceswaplab "post processing" isn't as sufficient as using Adetailer to perform enhancements to specific areas. **Request** Allow a custom setting so we can choose to run faceswaplab at different stages of the image creation process in txt2img, such as 1st or last.
👍 3
zexcster commented 2023-11-20 09:07:01 +01:00 (Migrated from github.com)
Copy Link
Copy Source

Even more, would be good to have it run before the highres fix

Even more, would be good to have it run before the highres fix
isu-shrestha commented 2024-01-03 23:10:55 +01:00 (Migrated from github.com)
Copy Link
Copy Source

Same. Seems to me that we are deliberately running this last. If someone could point to the part of code that is doing this, I can
update and send in a PR

Same. Seems to me that we are deliberately running this last. If someone could point to the part of code that is doing this, I can update and send in a PR
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 configuration
Problem related to configuration
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 fixed in future version
good first issue
Good for newcomers
 gradio
Gradio related bug
 help wanted
Extra attention is needed
 install
Install problem
 invalid
This doesn't seem right
 lack of information
Bug report does not comply with instructions. Not enough information to provide a solution
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CalvinBackup (Calvin Backup)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CalvinBackup/sd-webui-faceswaplab#154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?