From 7dc8cfe5c795ebee7d11f0600c341dc6d28b21e8 Mon Sep 17 00:00:00 2001 From: ajmallesh Date: Tue, 13 Jan 2026 18:17:33 -0800 Subject: [PATCH] fix: remove pipeline_testing_mode from telemetry events --- src/telemetry/telemetry-manager.ts | 7 +------ src/temporal/client.ts | 3 +-- src/temporal/worker.ts | 1 - 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/telemetry/telemetry-manager.ts b/src/telemetry/telemetry-manager.ts index 02e1bcc..ee6be5a 100644 --- a/src/telemetry/telemetry-manager.ts +++ b/src/telemetry/telemetry-manager.ts @@ -118,7 +118,6 @@ class TelemetryManager { private config: TelemetryConfig; private distinctId: string; private initialized = false; - private pipelineTestingMode = false; constructor() { this.config = loadTelemetryConfig(); @@ -137,16 +136,13 @@ class TelemetryManager { /** * Initialize PostHog client. * Safe: never throws, logs warning on failure. - * - * @param pipelineTestingMode - Whether running in testing mode */ - initialize(pipelineTestingMode = false): void { + initialize(): void { try { if (this.initialized) { return; } - this.pipelineTestingMode = pipelineTestingMode; this.initialized = true; if (!this.config.enabled) { @@ -187,7 +183,6 @@ class TelemetryManager { // Build base properties const baseProps: BaseTelemetryProperties & Record = { - pipeline_testing_mode: this.pipelineTestingMode, os_platform: process.platform, node_version: process.version, $lib: 'shannon', diff --git a/src/temporal/client.ts b/src/temporal/client.ts index f589130..47482fb 100644 --- a/src/temporal/client.ts +++ b/src/temporal/client.ts @@ -135,7 +135,7 @@ async function startPipeline(): Promise { const installationId = await getInstallationId(); // Initialize telemetry with installation ID as distinct ID (for unique user tracking) - telemetry.initialize(pipelineTestingMode); + telemetry.initialize(); telemetry.setDistinctId(installationId); const input: PipelineInput = { @@ -172,7 +172,6 @@ async function startPipeline(): Promise { // Track workflow start telemetry.track(TelemetryEvent.WORKFLOW_START, { has_config: !!configPath, - pipeline_testing_mode: pipelineTestingMode, target_hash: hashTargetUrl(webUrl), workflow_id: workflowId, }); diff --git a/src/temporal/worker.ts b/src/temporal/worker.ts index 1a7549b..80e1896 100644 --- a/src/temporal/worker.ts +++ b/src/temporal/worker.ts @@ -39,7 +39,6 @@ async function runWorker(): Promise { const connection = await NativeConnection.connect({ address }); // Initialize telemetry for activity execution - // Worker doesn't know pipelineTestingMode until activity runs, so default to false telemetry.initialize(); // Bundle workflows for Temporal's V8 isolate