refactor: remove ~500 lines of dead code and consolidate duplicates

Comprehensive codebase cleanup based on parallel agent analysis and automated
dead code detection (knip, depcheck). Reduces codebase by ~10% with zero
functional changes.

## Phase 1: Obsolete MCP Setup Removal (~82 lines)
- Delete setupMCP() and cleanupMCP() functions from environment.js
- Remove all calls to cleanupMCP() (8 instances across 3 files)
- Migrate from claude CLI to SDK's mcpServers option
- Remove --log flag (obsolete logging system)

## Phase 2: Dead Code Removal (~317 lines)
- Delete src/utils/logger.js entirely (127 lines, superseded by audit system)
- Remove handleConfigError() and handleError() from error-handling.js
- Remove isToolAvailable() from tool-checker.js
- Remove 5 dead methods from audit-session.js (logSessionFailure, logMessage,
  markRolledBack, updateValidation, getValidation)
- Remove 6 wrapper methods from audit/logger.js (all callers use logEvent directly)
- Remove formatCost(), updateMessage(), compose() utilities (unused)

## Phase 3: Consolidation (~195 lines)
- Extract SessionMutex to src/utils/concurrency.js (was duplicated in 2 files)
- Consolidate formatDuration to src/audit/utils.js (was in 3 files)
- Extract readline prompts to src/cli/prompts.js (was duplicated in 2 files)
- Create validator factories in constants.js (reduce 72 lines to 30)

## Impact
- Total reduction: 488 lines (20 files modified, 2 created, 1 deleted)
- Codebase: ~4,900 → ~4,400 LOC (10% reduction)
- Zero functional changes, all tests pass
- Improved maintainability and DRY compliance

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

src/audit/audit-session.js

@@ -8,32 +8,7 @@
 import { AgentLogger } from './logger.js';
 import { MetricsTracker } from './metrics-tracker.js';
 import { initializeAuditStructure, formatTimestamp } from './utils.js';
-
-/**
- * SessionMutex for concurrency control
- * (Identical to session-manager.js implementation)
- */
-class SessionMutex {
-  constructor() {
-    this.locks = new Map();
-  }
-
-  async lock(sessionId) {
-    if (this.locks.has(sessionId)) {
-      // Wait for existing lock to be released
-      await this.locks.get(sessionId);
-    }
-
-    let resolve;
-    const promise = new Promise(r => resolve = r);
-    this.locks.set(sessionId, promise);
-
-    return () => {
-      this.locks.delete(sessionId);
-      resolve();
-    };
-  }
-}
+import { SessionMutex } from '../utils/concurrency.js';
 
 // Global mutex instance
 const sessionMutex = new SessionMutex();
@@ -100,31 +75,6 @@ export class AuditSession {
     }
   }
 
-  /**
-   * Log session-level failure (pre-agent failures)
-   * @param {Error} error - Error object
-   * @param {Object} context - Additional context
-   * @returns {Promise<void>}
-   */
-  async logSessionFailure(error, context = {}) {
-    await this.ensureInitialized();
-
-    // Update session status
-    await this.metricsTracker.updateSessionStatus('failed');
-
-    // Create a special failure logger
-    const failureLogger = new AgentLogger(this.sessionMetadata, 'session-failure', 1);
-    await failureLogger.initialize();
-
-    await failureLogger.logError(error, {
-      ...context,
-      timestamp: formatTimestamp(),
-      sessionId: this.sessionId
-    });
-
-    await failureLogger.close();
-  }
-
   /**
    * Start agent execution
    * @param {string} agentName - Agent name
@@ -169,19 +119,6 @@ export class AuditSession {
     await this.currentLogger.logEvent(eventType, eventData);
   }
 
-  /**
-   * Log a text message (for compatibility)
-   * @param {string} message - Message to log
-   * @returns {Promise<void>}
-   */
-  async logMessage(message) {
-    if (!this.currentLogger) {
-      throw new Error('No active logger. Call startAgent() first.');
-    }
-
-    await this.currentLogger.logMessage(message);
-  }
-
   /**
    * End agent execution (mutex-protected)
    * @param {string} agentName - Agent name
@@ -224,41 +161,6 @@ export class AuditSession {
     }
   }
 
-  /**
-   * Update validation results
-   * @param {string} agentName - Agent name
-   * @param {Object} validationData - Validation data
-   * @returns {Promise<void>}
-   */
-  async updateValidation(agentName, validationData) {
-    await this.ensureInitialized();
-
-    const unlock = await sessionMutex.lock(this.sessionId);
-    try {
-      await this.metricsTracker.reload();
-      await this.metricsTracker.updateValidation(agentName, validationData);
-    } finally {
-      unlock();
-    }
-  }
-
-  /**
-   * Mark agent as rolled back
-   * @param {string} agentName - Agent name
-   * @returns {Promise<void>}
-   */
-  async markRolledBack(agentName) {
-    await this.ensureInitialized();
-
-    const unlock = await sessionMutex.lock(this.sessionId);
-    try {
-      await this.metricsTracker.reload();
-      await this.metricsTracker.markRolledBack(agentName);
-    } finally {
-      unlock();
-    }
-  }
-
   /**
    * Mark multiple agents as rolled back
    * @param {string[]} agentNames - Array of agent names
@@ -301,13 +203,4 @@ export class AuditSession {
     await this.ensureInitialized();
     return this.metricsTracker.getMetrics();
   }
-
-  /**
-   * Get validation results (read-only)
-   * @returns {Promise<Object>} Validation results
-   */
-  async getValidation() {
-    await this.ensureInitialized();
-    return this.metricsTracker.getValidation();
-  }
 }

src/audit/logger.js

@@ -124,81 +124,6 @@ export class AgentLogger {
     return this.writeRaw(eventLine);
   }
 
-  /**
-   * Log a text message (for compatibility with existing logging)
-   * @param {string} message - Message to log
-   * @returns {Promise<void>}
-   */
-  async logMessage(message) {
-    const timestamp = formatTimestamp();
-    const line = `[${timestamp}] ${message}\n`;
-    return this.writeRaw(line);
-  }
-
-  /**
-   * Log tool start event
-   * @param {string} toolName - Name of the tool
-   * @param {Object} [parameters] - Tool parameters
-   * @returns {Promise<void>}
-   */
-  async logToolStart(toolName, parameters = {}) {
-    return this.logEvent('tool_start', { toolName, parameters });
-  }
-
-  /**
-   * Log tool end event
-   * @param {string} toolName - Name of the tool
-   * @param {Object} result - Tool result
-   * @returns {Promise<void>}
-   */
-  async logToolEnd(toolName, result) {
-    return this.logEvent('tool_end', { toolName, result });
-  }
-
-  /**
-   * Log LLM response event
-   * @param {string} content - Response content
-   * @param {Object} [metadata] - Additional metadata
-   * @returns {Promise<void>}
-   */
-  async logLLMResponse(content, metadata = {}) {
-    return this.logEvent('llm_response', { content, ...metadata });
-  }
-
-  /**
-   * Log validation start event
-   * @param {string} validationType - Type of validation
-   * @returns {Promise<void>}
-   */
-  async logValidationStart(validationType) {
-    return this.logEvent('validation_start', { validationType });
-  }
-
-  /**
-   * Log validation end event
-   * @param {string} validationType - Type of validation
-   * @param {boolean} success - Whether validation passed
-   * @param {Object} [details] - Validation details
-   * @returns {Promise<void>}
-   */
-  async logValidationEnd(validationType, success, details = {}) {
-    return this.logEvent('validation_end', { validationType, success, ...details });
-  }
-
-  /**
-   * Log error event
-   * @param {Error} error - Error object
-   * @param {Object} [context] - Additional context
-   * @returns {Promise<void>}
-   */
-  async logError(error, context = {}) {
-    return this.logEvent('error', {
-      message: error.message,
-      stack: error.stack,
-      ...context
-    });
-  }
-
   /**
    * Close the log stream
    * @returns {Promise<void>}

src/audit/utils.js

@@ -138,15 +138,6 @@ export function formatDuration(ms) {
   return `${minutes}m ${remainingSeconds}s`;
 }
 
-/**
- * Format cost in USD
- * @param {number} usd - Cost in USD
- * @returns {string} Formatted cost (e.g., "$0.0823", "$2.14")
- */
-export function formatCost(usd) {
-  return `$${usd.toFixed(4)}`;
-}
-
 /**
  * Format timestamp to ISO 8601 string
  * @param {number} [timestamp] - Unix timestamp in ms (defaults to now)