CalvinBackup/tauri-plugins-workspace
1
0
Fork 0
mirror of https://github.com/tauri-apps/plugins-workspace.git synced 2026-08-05 18:18:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(updater): check ShellExecuteW results (#3516)

Browse Source 
* fix(updater): check `ShellExecuteW` results

* document the exit on windows
This commit is contained in:
Tony
2026-07-27 16:38:50 +08:00
committed by GitHub
parent abc903c240
commit 622f02bf21
5 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/updater/src/updater.rs
+14 -1
View File
@@ -743,11 +743,21 @@ impl Update {
}
/// Installs the updater package downloaded by [`Update::download`]
///
/// ## Platform-specific:
///
/// - **Windows:** This function exits the app after launching the updater installer successfully
/// - **macOS / Linux:** You need to relaunch the app to run the newly install version
pub fn install(&self, bytes: impl AsRef<[u8]>) -> Result<()> {
self.install_inner(bytes.as_ref())
}
/// Downloads and installs the updater package
///
/// ## Platform-specific:
///
/// - **Windows:** This function exits the app after launching the updater installer successfully
/// - **macOS / Linux:** You need to relaunch the app to run the newly install version
pub async fn download_and_install<C: FnMut(usize, Option<u64>), D: FnOnce()>(
&self,
on_chunk: C,
@@ -849,7 +859,7 @@ impl Update {
let file = encode_wide(file);
let parameters = encode_wide(parameters);
unsafe {
let result = unsafe {
ShellExecuteW(
std::ptr::null_mut(),
w!("open"),
@@ -859,6 +869,9 @@ impl Update {
SW_SHOW,
)
};
if result as isize <= 32 {
return Err(crate::Error::Io(std::io::Error::last_os_error()));
}
std::process::exit(0);
}