mirror of
https://github.com/tauri-apps/plugins-workspace.git
synced 2026-10-10 22:38:44 +02:00
fix(fs): reject negative offsets when seeking from the start (#3633)
In plugins/fs/src/commands.rs seek, `SeekFrom::Start(offset as u64)` turned -1 into u64::MAX. The offset is now converted with u64::try_from and a negative one is an error. E2E spec added.
This commit is contained in:
1 parent
5c144e7466
commit
77d00a4f54
3 files changed
+29
-9
No files matched your search
@@ -888,16 +888,17 @@ pub async fn seek<R: Runtime>(
|
||||
whence: SeekMode,
|
||||
) -> CommandResult<u64> {
|
||||
use std::io::{Seek, SeekFrom};
|
||||
let position = match whence {
|
||||
SeekMode::Start => SeekFrom::Start(u64::try_from(offset).map_err(|_| {
|
||||
format!("invalid seek offset {offset}: it must not be negative with SeekMode.Start")
|
||||
})?),
|
||||
SeekMode::Current => SeekFrom::Current(offset),
|
||||
SeekMode::End => SeekFrom::End(offset),
|
||||
};
|
||||
let file: std::sync::Arc<StdFileResource<R>> = webview.resources_table().get(rid)?;
|
||||
StdFileResource::with_lock(&file, |file| {
|
||||
file.seek(match whence {
|
||||
SeekMode::Start => SeekFrom::Start(offset as u64),
|
||||
SeekMode::Current => SeekFrom::Current(offset),
|
||||
SeekMode::End => SeekFrom::End(offset),
|
||||
})
|
||||
})
|
||||
.map_err(|e| format!("failed to seek file with error: {e}"))
|
||||
.map_err(Into::into)
|
||||
StdFileResource::with_lock(&file, |file| file.seek(position))
|
||||
.map_err(|e| format!("failed to seek file with error: {e}"))
|
||||
.map_err(Into::into)
|
||||
}
|
||||
|
||||
#[cfg(target_os = "android")]
|
||||
|
||||
Reference in new issue
Block a user