CalvinBackup/tauri-plugins-workspace
1
0
Fork 0
mirror of https://github.com/tauri-apps/plugins-workspace.git synced 2026-09-24 21:40:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(fs): reject malformed write_file options instead of ignoring them (#3622)

Browse Source 
In plugins/fs/src/commands.rs write_file_inner, a malformed or non-ASCII
`options` header was dropped with .ok(), so baseDir/append/createNew were
silently ignored and the call became a truncating write to the raw path;
the JSON array body fallback truncated values above 255 and dropped
non-numbers.

The header is parsed with parse_write_file_options: empty, `undefined`
(what fetch sends for JSON.stringify(undefined)) and `null` mean no
options, anything else must parse. Array bodies must only contain bytes.
Unit test for the header parser; e2e spec for writes without options,
which is the case the `undefined` handling keeps working.
This commit is contained in:
Lucas Fernandes Nogueira
2026-09-23 12:57:49 -03:00
committed by GitHub
parent 0c84c917e3
commit b46a88ff55
3 changed files with 64 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changes/fix-fs-write-options-header.md
+6
View File
@@ -0,0 +1,6 @@
---
fs: patch
fs-js: patch
---
`writeFile` and `writeTextFile` now fail when their options cannot be parsed instead of silently ignoring them (including `baseDir`, `append` and `createNew`) and writing to the raw path. Data sent as a JSON array is rejected if it contains values that are not bytes, instead of truncating them.