From 220bf92ed876c32fbc0b7e8d09b5292e3ffe526c Mon Sep 17 00:00:00 2001 From: Amr Bashir Date: Tue, 9 Jul 2024 02:57:31 +0300 Subject: [PATCH] fix(core/updater): pass `/NS` to nsis installer to disable creating shortcuts on updates (#9413) * fix(core/updater): pass `/NS` to nsis installer to disable creating shortcuts on updates closes #9395 * Update .changes/utils-nsis-args-ns.md [skip ci] --------- Co-authored-by: Lucas Fernandes Nogueira --- .changes/updater-nsis-shortcut.md | 5 +++++ .changes/utils-nsis-args-ns.md | 5 +++++ core/tauri-utils/src/config.rs | 8 ++++---- 3 files changed, 14 insertions(+), 4 deletions(-) create mode 100644 .changes/updater-nsis-shortcut.md create mode 100644 .changes/utils-nsis-args-ns.md diff --git a/.changes/updater-nsis-shortcut.md b/.changes/updater-nsis-shortcut.md new file mode 100644 index 000000000..faddb78c5 --- /dev/null +++ b/.changes/updater-nsis-shortcut.md @@ -0,0 +1,5 @@ +--- +"tauri": "patch:bug" +--- + +Fix NSIS updater creating new shortcuts on update. diff --git a/.changes/utils-nsis-args-ns.md b/.changes/utils-nsis-args-ns.md new file mode 100644 index 000000000..fdc23a21a --- /dev/null +++ b/.changes/utils-nsis-args-ns.md @@ -0,0 +1,5 @@ +--- +"tauri-utils": "patch:enhance" +--- + +Added `/NS` flag in the return of `WindowsUpdateInstallMode::nsis_args`. diff --git a/core/tauri-utils/src/config.rs b/core/tauri-utils/src/config.rs index 586d55770..3611790ee 100644 --- a/core/tauri-utils/src/config.rs +++ b/core/tauri-utils/src/config.rs @@ -2756,12 +2756,12 @@ impl WindowsUpdateInstallMode { /// Returns the associated nsis arguments. /// - /// [WindowsUpdateInstallMode::Passive] will return `["/P", "/R"]` - /// [WindowsUpdateInstallMode::Quiet] will return `["/S", "/R"]` + /// [WindowsUpdateInstallMode::Passive] will return `["/P", "/R", "/NS"]` + /// [WindowsUpdateInstallMode::Quiet] will return `["/S", "/R", "/NS"]` pub fn nsis_args(&self) -> &'static [&'static str] { match self { - Self::Passive => &["/P", "/R"], - Self::Quiet => &["/S", "/R"], + Self::Passive => &["/P", "/R", "/NS"], + Self::Quiet => &["/S", "/R", "/NS"], _ => &[], } }