From f2865fad13d74b5accb440179427fc3ccfcadf8d Mon Sep 17 00:00:00 2001 From: cybai Date: Tue, 31 Aug 2021 00:31:38 +0900 Subject: [PATCH] fix: recommended run dev command in create-tauri-app (#2555) `--dev` is not a valid option for `tauri` cli; instead, we should use `-- dev` or just `dev`. Also, we can just use `tauri dev` for all package managers so we don't need to do the npm checking. --- tooling/create-tauri-app/src/recipes/dominator.ts | 4 +--- tooling/create-tauri-app/src/recipes/ng-cli.ts | 4 +--- tooling/create-tauri-app/src/recipes/react.ts | 4 +--- tooling/create-tauri-app/src/recipes/svelte.ts | 4 +--- tooling/create-tauri-app/src/recipes/vanilla.ts | 4 +--- tooling/create-tauri-app/src/recipes/vite.ts | 4 +--- 6 files changed, 6 insertions(+), 18 deletions(-) diff --git a/tooling/create-tauri-app/src/recipes/dominator.ts b/tooling/create-tauri-app/src/recipes/dominator.ts index 771bbc865..06707ad2b 100644 --- a/tooling/create-tauri-app/src/recipes/dominator.ts +++ b/tooling/create-tauri-app/src/recipes/dominator.ts @@ -50,9 +50,7 @@ export const dominator: Recipe = { $ cd ${cfg.appName} $ ${packageManager} install - $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${ - packageManager === 'npm' ? '--' : '' - }dev + $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev `) return await Promise.resolve() } diff --git a/tooling/create-tauri-app/src/recipes/ng-cli.ts b/tooling/create-tauri-app/src/recipes/ng-cli.ts index b0fff28b9..77b53ab11 100644 --- a/tooling/create-tauri-app/src/recipes/ng-cli.ts +++ b/tooling/create-tauri-app/src/recipes/ng-cli.ts @@ -100,9 +100,7 @@ const ngcli: Recipe = { Your installation completed. $ cd ${cfg.appName} - $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${ - packageManager === 'npm' ? '--' : '' - }dev + $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev `) return await Promise.resolve() diff --git a/tooling/create-tauri-app/src/recipes/react.ts b/tooling/create-tauri-app/src/recipes/react.ts index c2e75688e..fa492dbf6 100644 --- a/tooling/create-tauri-app/src/recipes/react.ts +++ b/tooling/create-tauri-app/src/recipes/react.ts @@ -120,9 +120,7 @@ export const cra: Recipe = { Your installation completed. $ cd ${cfg.appName} - $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${ - packageManager === 'npm' ? '--' : '' - }dev + $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev `) return await Promise.resolve() } diff --git a/tooling/create-tauri-app/src/recipes/svelte.ts b/tooling/create-tauri-app/src/recipes/svelte.ts index d113aa4c1..c93ecd142 100644 --- a/tooling/create-tauri-app/src/recipes/svelte.ts +++ b/tooling/create-tauri-app/src/recipes/svelte.ts @@ -60,9 +60,7 @@ const svelte: Recipe = { $ cd ${cfg.appName} $ ${packageManager} install - $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${ - packageManager === 'npm' ? '--' : '' - }dev + $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev `) return await Promise.resolve() diff --git a/tooling/create-tauri-app/src/recipes/vanilla.ts b/tooling/create-tauri-app/src/recipes/vanilla.ts index e083d0e48..6c77820c2 100644 --- a/tooling/create-tauri-app/src/recipes/vanilla.ts +++ b/tooling/create-tauri-app/src/recipes/vanilla.ts @@ -45,9 +45,7 @@ export const vanillajs: Recipe = { $ cd ${cfg.appName} $ ${packageManager} install - $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${ - packageManager === 'npm' ? '--' : '' - }dev + $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev `) return await Promise.resolve() } diff --git a/tooling/create-tauri-app/src/recipes/vite.ts b/tooling/create-tauri-app/src/recipes/vite.ts index 456852b33..9f6bd15fa 100644 --- a/tooling/create-tauri-app/src/recipes/vite.ts +++ b/tooling/create-tauri-app/src/recipes/vite.ts @@ -91,9 +91,7 @@ const vite: Recipe = { Your installation completed. $ cd ${cfg.appName} - $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${ - packageManager === 'npm' ? '--' : '' - }dev + $ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev `) return await Promise.resolve() }