CalvinBackup/HackBrowserData
1
0
Fork 0
mirror of https://github.com/moonD4rk/HackBrowserData.git synced 2026-05-23 19:14:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(keys): guard --keys against misuse + hint Safari

Browse Source 
Without -p, dumped keys would be applied to local profile data and
decrypt to garbage; -b all hits the same path because pickFromConfigs
ignores -p when name == "all". Require both.
This commit is contained in:
moonD4rk
2026-05-23 21:35:20 +08:00
parent 2ba10429dc
commit 6313513d82
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/hack-browser-data/dump.go
+19 -1
View File
@@ -104,8 +104,18 @@ func selectBrowsers(browserName, profilePath, keychainPw, keysPath string) ([]br
})
}
// Require -p and a single -b to prevent dumped keys from being applied to local profile data,
// which would decrypt to garbage. -b all is rejected because pickFromConfigs ignores -p in that case.
if profilePath == "" {
return nil, fmt.Errorf("--keys requires -p <copied-profile-dir>")
}
name := strings.ToLower(browserName)
if name == "" || name == "all" {
return nil, fmt.Errorf(`--keys requires -b <browser> (single, not "all")`)
}
if keychainPw != "" {
log.Warnf("--keychain-pw is ignored when --keys is set; platform key retrieval is skipped")
log.Warnf("--keychain-pw is ignored when --keys is set")
}
browsers, err := browser.DiscoverBrowsers(browser.PickOptions{
@@ -128,6 +138,14 @@ func selectBrowsers(browserName, profilePath, keychainPw, keysPath string) ([]br
}
browser.ApplyDump(browsers, dump)
for _, b := range browsers {
if _, ok := b.(browser.KeychainPasswordReceiver); ok {
log.Infof("Safari has no portable master key; run `dump -b safari` separately for full extraction")
break
}
}
return browsers, nil
}