CalvinBackup/Shadowbroker
1
0
Fork 0
mirror of https://github.com/BigBodyCobain/Shadowbroker.git synced 2026-05-01 23:35:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

perf: wrap interpFlight/Ship/Sat in useCallback to prevent spurious re-renders

Browse Source 
interpFlight, interpShip, and interpSat were plain arrow functions
recreated on every render. Because interpTick fires every second,
TrackedFlightLabels received a new function reference every second
(preventing memo bailout) and all downstream useMemos closed over
these functions re-executed unnecessarily.

Wrap all three in useCallback([dtSeconds]) — dtSeconds is their
only reactive closure variable; interpolatePosition is a stable
module-level import and does not need to be listed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Former-commit-id: 84c3c06407afa5c0227ac1b682cca1157498d1a5
This commit is contained in:
csysp
2026-03-13 20:00:06 -06:00
parent a9d21a0bb5
commit 10960c5a3f
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/MaplibreViewer.tsx
+6 -6
View File
@@ -505,29 +505,29 @@ const MaplibreViewer = ({ data, activeLayers, onEntityClick, flyToLocation, sele
}, [interpTick]);
// Helper: interpolate a flight's position if airborne and has speed+heading
const interpFlight = (f: any): [number, number] => {
const interpFlight = useCallback((f: any): [number, number] => {
if (!f.speed_knots || f.speed_knots <= 0 || dtSeconds <= 0) return [f.lng, f.lat];
if (f.alt != null && f.alt <= 100) return [f.lng, f.lat];
if (dtSeconds < 1) return [f.lng, f.lat];
const heading = f.true_track || f.heading || 0;
const [newLat, newLng] = interpolatePosition(f.lat, f.lng, heading, f.speed_knots, dtSeconds);
return [newLng, newLat];
};
}, [dtSeconds]);
// Helper: interpolate a ship's position using SOG + heading
const interpShip = (s: any): [number, number] => {
const interpShip = useCallback((s: any): [number, number] => {
if (typeof s.sog !== 'number' || !s.sog || s.sog <= 0 || dtSeconds <= 0) return [s.lng, s.lat];
const heading = (typeof s.cog === 'number' ? s.cog : 0) || s.heading || 0;
const [newLat, newLng] = interpolatePosition(s.lat, s.lng, heading, s.sog, dtSeconds);
return [newLng, newLat];
};
}, [dtSeconds]);
// Helper: interpolate a satellite's position between API updates
const interpSat = (s: any): [number, number] => {
const interpSat = useCallback((s: any): [number, number] => {
if (!s.speed_knots || s.speed_knots <= 0 || dtSeconds < 1) return [s.lng, s.lat];
const [newLat, newLng] = interpolatePosition(s.lat, s.lng, s.heading || 0, s.speed_knots, dtSeconds, 0, 65);
return [newLng, newLat];
};
}, [dtSeconds]);
// Satellite GeoJSON with interpolated positions
const satellitesGeoJSON = useMemo(() => {