mirror of
https://github.com/zarzet/SpotiFLAC-Mobile.git
synced 2026-11-21 20:00:49 +01:00
fix(home): show a network cover not stored yet in Continue listening
The resume card read only the item's artUri, which stays empty for a network song whose cover the store does not hold, such as the first launch after an update from a build that kept loopback URLs. It now falls back to the item's cover reference, as the queue rows do, so the cover is fetched once and shows.
This commit is contained in:
1 parent
e913f09d4a
commit
28ff305699
2 files changed
+108
-1
No files matched your search
@@ -316,7 +316,10 @@ class _HomeContinueListeningCardState
|
||||
child: SizedBox.square(
|
||||
dimension: _coverSize,
|
||||
child: PlayerArtwork(
|
||||
artUri: mediaItem.artUri?.toString(),
|
||||
// A network cover not stored yet shows once fetched.
|
||||
artUri:
|
||||
mediaItem.artUri?.toString() ??
|
||||
mediaItem.extras?['artworkRef']?.toString(),
|
||||
colorScheme: colorScheme,
|
||||
cacheWidth:
|
||||
(_coverSize * MediaQuery.devicePixelRatioOf(context))
|
||||
|
||||
@@ -0,0 +1,104 @@
|
||||
import 'package:audio_service/audio_service.dart' show MediaItem;
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:mornye/l10n/app_localizations.dart';
|
||||
import 'package:mornye/models/settings.dart';
|
||||
import 'package:mornye/providers/download_queue_provider.dart';
|
||||
import 'package:mornye/providers/explore_provider.dart';
|
||||
import 'package:mornye/providers/extension_provider.dart';
|
||||
import 'package:mornye/providers/library_mixes_provider.dart';
|
||||
import 'package:mornye/providers/music_player_provider.dart';
|
||||
import 'package:mornye/providers/recent_access_provider.dart';
|
||||
import 'package:mornye/providers/settings_provider.dart';
|
||||
import 'package:mornye/screens/home_tab.dart';
|
||||
import 'package:mornye/services/playable_media.dart';
|
||||
import 'package:mornye/theme/app_theme.dart';
|
||||
import 'package:mornye/widgets/player_artwork.dart';
|
||||
|
||||
import 'support/fixed_settings.dart';
|
||||
|
||||
void main() {
|
||||
testWidgets('Continue listening shows a network cover not stored yet', (
|
||||
tester,
|
||||
) async {
|
||||
const cover = 'network://nas/Album/cover.jpg';
|
||||
await tester.pumpWidget(
|
||||
ProviderScope(
|
||||
overrides: [
|
||||
settingsProvider.overrideWith(
|
||||
() => FixedSettingsNotifier(
|
||||
const AppSettings(
|
||||
searchProvider: 'example',
|
||||
homeFeedProvider: AppSettings.homeFeedProviderOff,
|
||||
hasSearchedBefore: true,
|
||||
),
|
||||
),
|
||||
),
|
||||
extensionProvider.overrideWith(_Extensions.new),
|
||||
exploreProvider.overrideWith(_Explore.new),
|
||||
downloadHistoryProvider.overrideWith(_History.new),
|
||||
recentAccessProvider.overrideWith(_Recent.new),
|
||||
libraryMixesProvider.overrideWith((ref) async => const []),
|
||||
playerUiEnabledProvider.overrideWithValue(true),
|
||||
currentMediaItemProvider.overrideWithBuild(
|
||||
(ref, notifier) => Stream<MediaItem?>.value(null),
|
||||
),
|
||||
playbackResumeProvider.overrideWith(
|
||||
(ref) async => (
|
||||
media: const PlayableMedia(
|
||||
id: 'network://nas/Album/song.flac',
|
||||
source: 'network://nas/Album/song.flac',
|
||||
title: 'Saved song',
|
||||
artist: 'Artist',
|
||||
networkArtworkSource: cover,
|
||||
),
|
||||
position: const Duration(seconds: 23),
|
||||
),
|
||||
),
|
||||
],
|
||||
child: MaterialApp(
|
||||
theme: AppTheme.dark(),
|
||||
localizationsDelegates: AppLocalizations.localizationsDelegates,
|
||||
supportedLocales: AppLocalizations.supportedLocales,
|
||||
home: const HomeTab(mode: HomeTabMode.combined),
|
||||
),
|
||||
),
|
||||
);
|
||||
await tester.pump();
|
||||
await tester.pump();
|
||||
|
||||
final card = find.ancestor(
|
||||
of: find.text('Saved song'),
|
||||
matching: find.byType(InkWell),
|
||||
);
|
||||
final artwork = find.descendant(
|
||||
of: card.first,
|
||||
matching: find.byType(PlayerArtwork),
|
||||
);
|
||||
expect(tester.widget<PlayerArtwork>(artwork).artUri, cover);
|
||||
});
|
||||
}
|
||||
|
||||
class _Extensions extends ExtensionNotifier {
|
||||
@override
|
||||
ExtensionState build() => const ExtensionState();
|
||||
}
|
||||
|
||||
class _Explore extends ExploreNotifier {
|
||||
@override
|
||||
ExploreState build() => const ExploreState();
|
||||
|
||||
@override
|
||||
Future<void> fetchHomeFeed({bool forceRefresh = false}) async {}
|
||||
}
|
||||
|
||||
class _History extends DownloadHistoryNotifier {
|
||||
@override
|
||||
DownloadHistoryState build() => DownloadHistoryState();
|
||||
}
|
||||
|
||||
class _Recent extends RecentAccessNotifier {
|
||||
@override
|
||||
RecentAccessState build() => const RecentAccessState(isLoaded: true);
|
||||
}
|
||||
Reference in new issue
Block a user