mirror of
https://github.com/zarzet/SpotiFLAC-Mobile.git
synced 2026-08-02 09:08:35 +02:00
fix(metadata): keep header details legible in light theme
This commit is contained in:
@@ -1,5 +1,11 @@
|
||||
part of 'track_metadata_screen.dart';
|
||||
|
||||
const _trackMetadataHeroScheme = ColorScheme.dark(
|
||||
surface: Colors.black,
|
||||
onSurface: Colors.white,
|
||||
onSurfaceVariant: Colors.white70,
|
||||
);
|
||||
|
||||
extension _TrackMetadataCards on _TrackMetadataScreenState {
|
||||
Widget _buildAnimatedTrackContent(
|
||||
BuildContext context,
|
||||
@@ -222,28 +228,31 @@ extension _TrackMetadataCards on _TrackMetadataScreenState {
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
const SizedBox(height: 12),
|
||||
HeaderMetaRow(
|
||||
items: [
|
||||
if (_displayAudioQuality != null &&
|
||||
_displayAudioQuality!.isNotEmpty)
|
||||
HeaderMetaItem(_displayAudioQuality!),
|
||||
if (duration != null)
|
||||
HeaderMetaItem(formatClock(duration!)),
|
||||
if (_service != 'local')
|
||||
HeaderMetaItem(
|
||||
_service[0].toUpperCase() + _service.substring(1),
|
||||
)
|
||||
else
|
||||
HeaderMetaItem(
|
||||
context.l10n.librarySourceLocal,
|
||||
icon: Icons.folder,
|
||||
),
|
||||
if (_hasCheckedFile && !_fileExists)
|
||||
HeaderMetaItem(
|
||||
context.l10n.trackFileNotFound,
|
||||
icon: Icons.warning_rounded,
|
||||
),
|
||||
],
|
||||
HeaderPalette(
|
||||
scheme: _trackMetadataHeroScheme,
|
||||
child: HeaderMetaRow(
|
||||
items: [
|
||||
if (_displayAudioQuality != null &&
|
||||
_displayAudioQuality!.isNotEmpty)
|
||||
HeaderMetaItem(_displayAudioQuality!),
|
||||
if (duration != null)
|
||||
HeaderMetaItem(formatClock(duration!)),
|
||||
if (_service != 'local')
|
||||
HeaderMetaItem(
|
||||
_service[0].toUpperCase() + _service.substring(1),
|
||||
)
|
||||
else
|
||||
HeaderMetaItem(
|
||||
context.l10n.librarySourceLocal,
|
||||
icon: Icons.folder,
|
||||
),
|
||||
if (_hasCheckedFile && !_fileExists)
|
||||
HeaderMetaItem(
|
||||
context.l10n.trackFileNotFound,
|
||||
icon: Icons.warning_rounded,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
|
||||
@@ -36,6 +36,7 @@ import 'package:spotiflac_android/utils/user_facing_error.dart';
|
||||
import 'package:spotiflac_android/utils/int_utils.dart';
|
||||
import 'package:spotiflac_android/utils/nav_bar_inset.dart';
|
||||
import 'package:spotiflac_android/utils/re_enrich_release_policy.dart';
|
||||
import 'package:spotiflac_android/theme/cover_palette.dart' show HeaderPalette;
|
||||
import 'package:spotiflac_android/widgets/album_detail_header.dart'
|
||||
show HeaderMetaRow, HeaderMetaItem;
|
||||
import 'package:spotiflac_android/widgets/audio_analysis_widget.dart';
|
||||
|
||||
@@ -0,0 +1,60 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:spotiflac_android/l10n/l10n.dart';
|
||||
import 'package:spotiflac_android/providers/download_history_provider.dart';
|
||||
import 'package:spotiflac_android/screens/track_metadata_screen.dart';
|
||||
import 'package:spotiflac_android/widgets/album_detail_header.dart';
|
||||
|
||||
void main() {
|
||||
testWidgets('metadata hero keeps technical text legible in light theme', (
|
||||
tester,
|
||||
) async {
|
||||
await tester.binding.setSurfaceSize(const Size(430, 900));
|
||||
addTearDown(() => tester.binding.setSurfaceSize(null));
|
||||
|
||||
final item = DownloadHistoryItem(
|
||||
id: 'history-track',
|
||||
trackName: 'Track',
|
||||
artistName: 'Artist',
|
||||
albumName: 'Album',
|
||||
filePath: r'Z:\missing\track.flac',
|
||||
service: 'tidal-web',
|
||||
downloadedAt: DateTime(2026),
|
||||
duration: 250,
|
||||
bitDepth: 16,
|
||||
sampleRate: 44100,
|
||||
format: 'flac',
|
||||
);
|
||||
|
||||
await tester.pumpWidget(
|
||||
ProviderScope(
|
||||
child: MaterialApp(
|
||||
theme: ThemeData.light(useMaterial3: true),
|
||||
localizationsDelegates: AppLocalizations.localizationsDelegates,
|
||||
supportedLocales: AppLocalizations.supportedLocales,
|
||||
home: TrackMetadataScreen(item: item),
|
||||
),
|
||||
),
|
||||
);
|
||||
await tester.pump();
|
||||
|
||||
final headerMeta = find.byType(HeaderMetaRow);
|
||||
expect(headerMeta, findsOneWidget);
|
||||
for (final label in const ['16-bit/44.1kHz', '4:10', 'Tidal-web']) {
|
||||
final text = tester.widget<Text>(
|
||||
find.descendant(of: headerMeta, matching: find.text(label)),
|
||||
);
|
||||
expect(text.style?.color, Colors.white);
|
||||
}
|
||||
|
||||
final separators = tester.widgetList<Text>(
|
||||
find.descendant(of: headerMeta, matching: find.text('•')),
|
||||
);
|
||||
expect(separators, isNotEmpty);
|
||||
expect(
|
||||
separators.every((text) => text.style?.color == Colors.white70),
|
||||
isTrue,
|
||||
);
|
||||
});
|
||||
}
|
||||
Reference in New Issue
Block a user