CalvinBackup/ctrld
1
0
Fork 0
mirror of https://github.com/Control-D-Inc/ctrld.git synced 2026-02-03 22:18:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: rename service_manager.go and remove unused CommandRunner interface

Browse Source 
Rename service_manager.go to commands_service_manager.go to follow the
established naming pattern with other command files.

Remove the unused CommandRunner interface from commands.go since it's not
being used anywhere in the codebase. Clean up unused imports.

This improves consistency in file naming and removes dead code.
This commit is contained in:
Cuong Manh Le
2025-07-29 15:36:30 +07:00
committed by Cuong Manh Le
parent 42ea5f7fed
commit 13de41d854
2 changed files with 11 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/cli/commands_service.go
View File

@@ -21,6 +21,17 @@ import (
"github.com/Control-D-Inc/ctrld"
)
// filterEmptyStrings removes empty strings from a slice
func filterEmptyStrings(slice []string) []string {
var result []string
for _, s := range slice {
if s != "" {
result = append(result, s)
}
}
return result
}
// ServiceCommand handles service-related operations
type ServiceCommand struct {
serviceManager *ServiceManager

25
cmd/cli/commands.go → cmd/cli/commands_service_manager.go
View File

@@ -5,22 +5,11 @@ import (
"time"
"github.com/kardianos/service"
"github.com/spf13/cobra"
)
// dialSocketControlServerTimeout is the default timeout to wait when ping control server.
const dialSocketControlServerTimeout = 30 * time.Second
// CommandRunner interface for dependency injection and testing
type CommandRunner interface {
RunServiceCommand(cmd *cobra.Command, args []string) error
RunLogCommand(cmd *cobra.Command, args []string) error
RunStatusCommand(cmd *cobra.Command, args []string) error
RunUpgradeCommand(cmd *cobra.Command, args []string) error
RunClientsCommand(cmd *cobra.Command, args []string) error
RunInterfacesCommand(cmd *cobra.Command, args []string) error
}
// ServiceManager handles service operations
type ServiceManager struct {
prog *prog
@@ -50,17 +39,3 @@ func NewServiceManager() (*ServiceManager, error) {
func (sm *ServiceManager) Status() (service.Status, error) {
return sm.svc.Status()
}
// initLogCmd is now implemented in commands_log.go as InitLogCmd
// initRunCmd is now implemented in commands_run.go as InitRunCmd
// filterEmptyStrings removes empty strings from a slice
func filterEmptyStrings(slice []string) []string {
var result []string
for _, s := range slice {
if s != "" {
result = append(result, s)
}
}
return result
}