mirror of
https://github.com/Control-D-Inc/ctrld.git
synced 2026-02-03 22:18:39 +00:00
cmd/cli: do not mask err argument of selfUninstall
The err should be preserved, so if we passed the error around, other functions could still check for utility error code correctly.
This commit is contained in:
committed by
Cuong Manh Le
parent
30320ec9c7
commit
8b98faa441
@@ -14,15 +14,15 @@ import (
|
||||
"github.com/rs/zerolog"
|
||||
)
|
||||
|
||||
func selfUninstall(err error, p *prog, logger zerolog.Logger) {
|
||||
func selfUninstall(uninstallErr error, p *prog, logger zerolog.Logger) {
|
||||
var uer *controld.UtilityErrorResponse
|
||||
if errors.As(err, &uer) && uer.ErrorField.Code == controld.InvalidConfigCode {
|
||||
if errors.As(uninstallErr, &uer) && uer.ErrorField.Code == controld.InvalidConfigCode {
|
||||
if runtime.GOOS == "linux" {
|
||||
s, err := newService(p, svcConfig)
|
||||
if err != nil {
|
||||
logger.Warn().Err(err).Msg("failed to create new service")
|
||||
} else {
|
||||
selfUninstallLinux(err, p, logger)
|
||||
selfUninstallLinux(uninstallErr, p, logger)
|
||||
_ = s.Stop()
|
||||
os.Exit(0)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user