fix(delivery note): avoid maintaining si_detail on return delivery note (backport #52456) (#53352)

Co-authored-by: NaviN <118178330+Navin-S-R@users.noreply.github.com>
fix(delivery note): avoid maintaining si_detail on return delivery note (#52456)
This commit is contained in:
mergify[bot]
2026-03-12 05:40:33 +00:00
committed by GitHub
parent fd94cd0e7c
commit 034d460ae1
2 changed files with 3 additions and 1 deletions

View File

@@ -531,7 +531,6 @@ def make_return_doc(doctype: str, source_name: str, target_doc=None, return_agai
target_doc.against_sales_order = source_doc.against_sales_order
target_doc.against_sales_invoice = source_doc.against_sales_invoice
target_doc.so_detail = source_doc.so_detail
target_doc.si_detail = source_doc.si_detail
target_doc.expense_account = source_doc.expense_account
target_doc.dn_detail = source_doc.name
if default_warehouse_for_sales_return:

View File

@@ -393,6 +393,9 @@ class DeliveryNote(SellingController):
)
def validate_sales_invoice_references(self):
if self.is_return:
return
self._validate_dependent_item_fields(
"against_sales_invoice", "si_detail", _("References to Sales Invoices are Incomplete")
)