CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-18 17:55:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: show or hide section or attributes depending on other attributes… (#22933)

Browse Source 
* fix: show or hide section or attributes depending on other attributes for better UI

* fix:depends on: batch_no for retain sample

Co-authored-by: Marica <maricadsouza221197@gmail.com>
This commit is contained in:
Afshan
2020-08-06 19:04:35 +05:30
committed by GitHub
parent e2e9633ee1
commit 2cf4168009
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/stock/doctype/item/item.js
View File

@@ -117,7 +117,7 @@ frappe.ui.form.on("Item", {
const stock_exists = (frm.doc.__onload
&& frm.doc.__onload.stock_exists) ? 1 : 0;
['is_stock_item', 'has_serial_no', 'has_batch_no'].forEach((fieldname) => {
['is_stock_item', 'has_serial_no', 'has_batch_no', 'has_variants'].forEach((fieldname) => {
frm.set_df_property(fieldname, 'read_only', stock_exists);
});

5
erpnext/stock/doctype/item/item.json
View File

@@ -472,6 +472,7 @@
},
{
"default": "0",
"depends_on": "has_batch_no",
"fieldname": "retain_sample",
"fieldtype": "Check",
"label": "Retain Sample"
@@ -498,7 +499,7 @@
"oldfieldtype": "Select"
},
{
"depends_on": "eval:doc.is_stock_item || doc.is_fixed_asset",
"depends_on": "has_serial_no",
"description": "Example: ABCD.#####\nIf series is set and Serial No is not mentioned in transactions, then automatic serial number will be created based on this series. If you always want to explicitly mention Serial Nos for this item. leave this blank.",
"fieldname": "serial_no_series",
"fieldtype": "Data",
@@ -1059,7 +1060,7 @@
"idx": 2,
"image_field": "image",
"max_attachments": 1,
"modified": "2020-07-01 12:43:10.656530",
"modified": "2020-08-06 17:03:26.594319",
"modified_by": "Administrator",
"module": "Stock",
"name": "Item",