mirror of
https://github.com/frappe/erpnext.git
synced 2026-02-14 02:04:17 +00:00
fix: remove applied pricing rule
(cherry picked from commit 50223c6bec)
This commit is contained in:
@@ -415,8 +415,6 @@ def get_pricing_rule_for_item(args, doc=None, for_validate=False):
|
||||
"parent": args.parent,
|
||||
"parenttype": args.parenttype,
|
||||
"child_docname": args.get("child_docname"),
|
||||
"discount_percentage": args.get("discount_percentage") or 0.0,
|
||||
"discount_amount": args.get("discount_amount") or 0.0,
|
||||
}
|
||||
)
|
||||
|
||||
|
||||
@@ -1658,7 +1658,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
|
||||
},
|
||||
callback: function(r) {
|
||||
if (!r.exc && r.message) {
|
||||
me.remove_pricing_rule(r.message, removed_pricing_rule);
|
||||
me.remove_pricing_rule(r.message, removed_pricing_rule, item.name);
|
||||
me.calculate_taxes_and_totals();
|
||||
if(me.frm.doc.apply_discount_on) me.frm.trigger("apply_discount_on");
|
||||
}
|
||||
@@ -1937,7 +1937,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
|
||||
});
|
||||
}
|
||||
|
||||
remove_pricing_rule(item, removed_pricing_rule) {
|
||||
remove_pricing_rule(item, removed_pricing_rule, row_name) {
|
||||
let me = this;
|
||||
const fields = ["discount_percentage",
|
||||
"discount_amount", "margin_rate_or_amount", "rate_with_margin"];
|
||||
@@ -1976,6 +1976,13 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
|
||||
|
||||
me.trigger_price_list_rate();
|
||||
}
|
||||
else if(!item.is_free_item && row_name){
|
||||
me.frm.doc.items.forEach(d => {
|
||||
if (d.name != row_name) return;
|
||||
|
||||
Object.assign(d, item);
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
trigger_price_list_rate() {
|
||||
|
||||
Reference in New Issue
Block a user