CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-13 07:18:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #49163 from diptanilsaha/fix-product-bundle-qty

Browse Source 
fix: product bundle child item quantity should be a positive number
This commit is contained in:
Diptanil Saha
2025-08-14 18:46:23 +05:30
committed by GitHub
parent 667213e52b 711076d02d
commit 734880f314
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/selling/doctype/product_bundle/product_bundle.py
View File

@@ -32,6 +32,7 @@ class ProductBundle(Document):
def validate(self):
self.validate_main_item()
self.validate_child_items()
self.validate_child_items_qty_non_zero()
from erpnext.utilities.transaction_base import validate_uom_is_integer
validate_uom_is_integer(self, "uom", "qty")
@@ -88,6 +89,15 @@ class ProductBundle(Document):
).format(item.idx, frappe.bold(item.item_code))
)
def validate_child_items_qty_non_zero(self):
for item in self.items:
if item.qty <= 0:
frappe.throw(
_(
"Row #{0}: Quantity cannot be a non-positive number. Please increase the quantity or remove the Item {1}"
).format(item.idx, frappe.bold(item.item_code))
)
@frappe.whitelist()
@frappe.validate_and_sanitize_search_inputs