CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-12 23:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16749 from Alchez/hotfix-cancelled-payments

Browse Source 
fix(payments): Only check for Draft or Submitted payments while cancelling payment requests
This commit is contained in:
Rushabh Mehta
2019-03-22 12:43:52 +05:30
committed by GitHub
parent 199aae0fe8 59a3012a5c
commit 7defd6f3b5
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/payment_request/payment_request.py
View File

@@ -214,9 +214,10 @@ class PaymentRequest(Document):
def check_if_payment_entry_exists(self):
if self.status == "Paid":
payment_entry = frappe.db.sql_list("""select parent from `tabPayment Entry Reference`
where reference_name=%s""", self.reference_name)
if payment_entry:
if frappe.get_all("Payment Entry Reference",
filters={"reference_name": self.reference_name, "docstatus": ["<", 2]},
fields=["parent"],
limit=1):
frappe.throw(_("Payment Entry already exists"), title=_('Error'))
def make_communication_entry(self):