refactor(test): make employee deterministic

This commit is contained in:
ruthra kumar
2025-12-26 13:32:18 +05:30
parent 0dbd10893e
commit 9231dbbb2f

View File

@@ -13,8 +13,8 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestEmployee(ERPNextTestSuite):
def test_employee_status_left(self):
employee1 = make_employee("test_employee_1@company.com")
employee2 = make_employee("test_employee_2@company.com")
employee1 = make_employee("test_employee_1@company.com", company=self.companies[0].name)
employee2 = make_employee("test_employee_2@company.com", company=self.companies[0].name)
employee1_doc = frappe.get_doc("Employee", employee1)
employee2_doc = frappe.get_doc("Employee", employee2)
employee2_doc.reload()
@@ -25,7 +25,7 @@ class TestEmployee(ERPNextTestSuite):
self.assertRaises(InactiveEmployeeStatusError, employee1_doc.save)
def test_user_has_employee(self):
employee = make_employee("test_emp_user_creation@company.com")
employee = make_employee("test_emp_user_creation@company.com", company=self.companies[0].name)
employee_doc = frappe.get_doc("Employee", employee)
user = employee_doc.user_id
self.assertTrue("Employee" in frappe.get_roles(user))
@@ -34,9 +34,13 @@ class TestEmployee(ERPNextTestSuite):
self.assertTrue("Employee" not in frappe.get_roles(user))
def test_employee_user_permission(self):
employee1 = make_employee("employee_1_test@company.com", create_user_permission=1)
employee2 = make_employee("employee_2_test@company.com", create_user_permission=1)
make_employee("employee_3_test@company.com", create_user_permission=1)
employee1 = make_employee(
"employee_1_test@company.com", create_user_permission=1, company=self.companies[0].name
)
employee2 = make_employee(
"employee_2_test@company.com", create_user_permission=1, company=self.companies[0].name
)
make_employee("employee_3_test@company.com", create_user_permission=1, company=self.companies[0].name)
employee1_doc = frappe.get_doc("Employee", employee1)
employee2_doc = frappe.get_doc("Employee", employee2)