CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-02-13 09:43:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #51116 from frappe/mergify/bp/version-15-hotfix/pr-51077

Browse Source 
refactor: standardize cost_center updation across transactions (backport #51077)
This commit is contained in:
ruthra kumar
2025-12-16 11:07:51 +05:30
committed by GitHub
parent a61890ec2b 41659a875b
commit b529a6d00c
4 changed files with 2 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.js
View File

@@ -575,17 +575,6 @@ cur_frm.fields_dict["items"].grid.get_field("cost_center").get_query = function
};
};
cur_frm.cscript.cost_center = function (doc, cdt, cdn) {
var d = locals[cdt][cdn];
if (d.cost_center) {
var cl = doc.items || [];
for (var i = 0; i < cl.length; i++) {
if (!cl[i].cost_center) cl[i].cost_center = d.cost_center;
}
}
refresh_field("items");
};
cur_frm.fields_dict["items"].grid.get_field("project").get_query = function (doc, cdt, cdn) {
return {
filters: [["Project", "status", "not in", "Completed, Cancelled"]],

4
erpnext/accounts/doctype/sales_invoice/sales_invoice.js
View File

@@ -648,10 +648,6 @@ cur_frm.cscript.expense_account = function (doc, cdt, cdn) {
erpnext.utils.copy_value_in_all_rows(doc, cdt, cdn, "items", "expense_account");
};
cur_frm.cscript.cost_center = function (doc, cdt, cdn) {
erpnext.utils.copy_value_in_all_rows(doc, cdt, cdn, "items", "cost_center");
};
cur_frm.set_query("debit_to", function (doc) {
return {
filters: {

8
erpnext/public/js/controllers/transaction.js
View File

@@ -1093,12 +1093,8 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
this.frm.refresh_field("payment_schedule");
}
cost_center(doc) {
this.frm.doc.items.forEach((item) => {
item.cost_center = doc.cost_center;
});
this.frm.refresh_field("items");
cost_center(doc, cdt, cdn) {
erpnext.utils.copy_value_in_all_rows(doc, cdt, cdn, "items", "cost_center");
}
due_date(doc, cdt, cdn) {

4
erpnext/stock/doctype/delivery_note/delivery_note.js
View File

@@ -130,10 +130,6 @@ frappe.ui.form.on("Delivery Note Item", {
var d = locals[dt][dn];
frm.update_in_all_rows("items", "expense_account", d.expense_account);
},
cost_center: function (frm, dt, dn) {
var d = locals[dt][dn];
frm.update_in_all_rows("items", "cost_center", d.cost_center);
},
});
erpnext.stock.DeliveryNoteController = class DeliveryNoteController extends (