fix: patch to complete onboarding stpes for existing records

2026-03-11 06:17:44 +00:00 · 2026-02-25 17:23:57 +05:30
parent 2517369270
commit d90ec49241
22 changed files with 66 additions and 71 deletions
--- a/erpnext/assets/module_onboarding/asset_onboarding/asset_onboarding.json
+++ b/erpnext/assets/module_onboarding/asset_onboarding/asset_onboarding.json
@@ -15,7 +15,7 @@
 "doctype": "Module Onboarding",
 "idx": 0,
 "is_complete": 0,
- "modified": "2026-02-23 22:51:11.027665",
+ "modified": "2026-02-25 16:59:52.159087",
 "modified_by": "Administrator",
 "module": "Assets",
 "name": "Asset Onboarding",
@@ -40,5 +40,5 @@
   "step": "View Balance Sheet"
  }
 ],
- "title": "Assets Setup!"
+ "title": "Assets Setup"
 }
--- a/erpnext/assets/onboarding_step/learn_asset/learn_asset.json
+++ b/erpnext/assets/onboarding_step/learn_asset/learn_asset.json
@@ -8,7 +8,7 @@
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-23 22:44:25.734547",
+ "modified": "2026-02-25 15:09:37.450763",
 "modified_by": "Administrator",
 "name": "Learn Asset",
 "owner": "Administrator",
--- a/erpnext/buying/module_onboarding/buying_onboarding/buying_onboarding.json
+++ b/erpnext/buying/module_onboarding/buying_onboarding/buying_onboarding.json
@@ -12,7 +12,7 @@
 "doctype": "Module Onboarding",
 "idx": 0,
 "is_complete": 0,
- "modified": "2026-02-24 16:57:55.172763",
+ "modified": "2026-02-25 16:59:28.328912",
 "modified_by": "Administrator",
 "module": "Buying",
 "name": "Buying Onboarding",
@@ -37,5 +37,5 @@
   "step": "Review Buying Settings"
  }
 ],
- "title": "Buying Setup! "
+ "title": "Buying Setup"
 }
--- a/erpnext/buying/onboarding_step/create_item/create_item.json
+++ b/erpnext/buying/onboarding_step/create_item/create_item.json
@@ -4,11 +4,11 @@
 "creation": "2026-02-19 12:38:40.865013",
 "docstatus": 0,
 "doctype": "Onboarding Step",
- "idx": 7,
+ "idx": 8,
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-24 16:57:14.098288",
+ "modified": "2026-02-25 16:58:56.384284",
 "modified_by": "Administrator",
 "name": "Create Item",
 "owner": "Administrator",
--- a/erpnext/buying/onboarding_step/create_purchase_invoice/create_purchase_invoice.json
+++ b/erpnext/buying/onboarding_step/create_purchase_invoice/create_purchase_invoice.json
@@ -8,7 +8,7 @@
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-23 20:26:00.223899",
+ "modified": "2026-02-25 16:58:56.386439",
 "modified_by": "Administrator",
 "name": "Create Purchase Invoice",
 "owner": "Administrator",
--- a/erpnext/buying/onboarding_step/create_purchase_order/create_purchase_order.json
+++ b/erpnext/buying/onboarding_step/create_purchase_order/create_purchase_order.json
@@ -9,7 +9,7 @@
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-24 16:57:37.904322",
+ "modified": "2026-02-25 16:58:56.379480",
 "modified_by": "Administrator",
 "name": "Create Purchase Order",
 "owner": "Administrator",
--- a/erpnext/buying/onboarding_step/create_supplier/create_supplier.json
+++ b/erpnext/buying/onboarding_step/create_supplier/create_supplier.json
@@ -10,7 +10,7 @@
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-23 22:16:40.903633",
+ "modified": "2026-02-25 16:58:56.375824",
 "modified_by": "Administrator",
 "name": "Create Supplier",
 "owner": "Administrator",
--- a/erpnext/buying/onboarding_step/review_buying_settings/review_buying_settings.json
+++ b/erpnext/buying/onboarding_step/review_buying_settings/review_buying_settings.json
@@ -8,7 +8,7 @@
 "is_complete": 0,
 "is_single": 1,
 "is_skipped": 0,
- "modified": "2026-02-24 16:57:14.031766",
+ "modified": "2026-02-25 16:58:56.388794",
 "modified_by": "Administrator",
 "name": "Review Buying Settings",
 "owner": "Administrator",
--- a/erpnext/buying/onboarding_step/setup_company/setup_company.json
+++ b/erpnext/buying/onboarding_step/setup_company/setup_company.json
@@ -1,21 +0,0 @@
-{
- "action": "Go to Page",
- "action_label": "Set up company",
- "creation": "2026-02-20 11:12:50.373049",
- "docstatus": 0,
- "doctype": "Onboarding Step",
- "idx": 1,
- "is_complete": 0,
- "is_single": 0,
- "is_skipped": 0,
- "modified": "2026-02-22 16:44:20.499954",
- "modified_by": "Administrator",
- "name": "Setup Company",
- "owner": "Administrator",
- "path": "company",
- "reference_document": "Company",
- "show_form_tour": 0,
- "show_full_form": 0,
- "title": "Setup Company",
- "validate_action": 1
-}
--- a/erpnext/buying/onboarding_step/view_purchase_order_analysis/view_purchase_order_analysis.json
+++ b/erpnext/buying/onboarding_step/view_purchase_order_analysis/view_purchase_order_analysis.json
@@ -8,7 +8,7 @@
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-23 22:44:35.794807",
+ "modified": "2026-02-25 10:33:43.731928",
 "modified_by": "Administrator",
 "name": "View Purchase Order Analysis",
 "owner": "Administrator",
--- a/erpnext/manufacturing/module_onboarding/manufacturing_onboarding/manufacturing_onboarding.json
+++ b/erpnext/manufacturing/module_onboarding/manufacturing_onboarding/manufacturing_onboarding.json
@@ -12,7 +12,7 @@
 "doctype": "Module Onboarding",
 "idx": 0,
 "is_complete": 0,
- "modified": "2026-02-23 22:51:27.390568",
+ "modified": "2026-02-25 16:59:39.508221",
 "modified_by": "Administrator",
 "module": "Manufacturing",
 "name": "Manufacturing Onboarding",
@@ -40,5 +40,5 @@
   "step": "Review Manufacturing Settings"
  }
 ],
- "title": "Manufacturing Setup!"
+ "title": "Manufacturing Setup"
 }
--- a/erpnext/manufacturing/onboarding_step/view_work_order_summary_report/view_work_order_summary_report.json
+++ b/erpnext/manufacturing/onboarding_step/view_work_order_summary_report/view_work_order_summary_report.json
@@ -8,7 +8,7 @@
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-23 22:44:32.658354",
+ "modified": "2026-02-25 16:49:31.440969",
 "modified_by": "Administrator",
 "name": "View Work Order Summary Report",
 "owner": "Administrator",
--- a/erpnext/patches.txt
+++ b/erpnext/patches.txt
@@ -467,4 +467,5 @@ erpnext.patches.v16_0.update_company_custom_field_in_bin
 erpnext.patches.v15_0.replace_http_with_https_in_sales_partner
 erpnext.patches.v16_0.migrate_asset_type_checkboxes_to_select
 erpnext.patches.v15_0.delete_quotation_lost_record_detail
-erpnext.patches.v16_0.add_portal_redirects
+erpnext.patches.v16_0.add_portal_redirects
+erpnext.patches.v16_0.complete_onboarding_steps_for_older_sites #2
--- a/erpnext/patches/v16_0/complete_onboarding_steps_for_older_sites.py
+++ b/erpnext/patches/v16_0/complete_onboarding_steps_for_older_sites.py
@@ -0,0 +1,36 @@
+import frappe
+from frappe.utils import date_diff, getdate, today
+
+
+def execute():
+	steps = frappe.get_all(
+		"Onboarding Step",
+		filters={"is_complete": 0},
+		fields=["name", "action", "reference_document"],
+	)
+
+	if not steps:
+		return
+
+	company_creation = frappe.get_all("Company", fields=["creation"], order_by="creation asc", limit=1)
+	days_diff = date_diff(getdate(today()), getdate(company_creation[0].creation))
+
+	if days_diff > 15:
+		complete_all_onboarding_steps(steps)
+	else:
+		complete_onboarding_steps_if_record_exists(steps)
+
+
+def complete_all_onboarding_steps(steps):
+	for step in steps:
+		frappe.db.set_value("Onboarding Step", step.name, "is_complete", 1, update_modified=False)
+
+
+def complete_onboarding_steps_if_record_exists(steps):
+	for step in steps:
+		if (
+			step.action == "Create Entry"
+			and step.reference_document
+			and frappe.get_all(step.reference_document, limit=1)
+		):
+			frappe.db.set_value("Onboarding Step", step.name, "is_complete", 1, update_modified=False)
--- a/erpnext/projects/module_onboarding/projects_onboarding/projects_onboarding.json
+++ b/erpnext/projects/module_onboarding/projects_onboarding/projects_onboarding.json
@@ -12,7 +12,7 @@
 "doctype": "Module Onboarding",
 "idx": 0,
 "is_complete": 0,
- "modified": "2026-02-23 22:50:58.003699",
+ "modified": "2026-02-25 16:59:59.005097",
 "modified_by": "Administrator",
 "module": "Projects",
 "name": "Projects Onboarding",
@@ -31,5 +31,5 @@
   "step": "View Project Summary"
  }
 ],
- "title": "Projects Setup!"
+ "title": "Projects Setup"
 }
--- a/erpnext/selling/module_onboarding/selling_onboarding/selling_onboarding.json
+++ b/erpnext/selling/module_onboarding/selling_onboarding/selling_onboarding.json
@@ -12,7 +12,7 @@
 "doctype": "Module Onboarding",
 "idx": 1,
 "is_complete": 0,
- "modified": "2026-02-24 16:57:50.753045",
+ "modified": "2026-02-25 16:59:32.154164",
 "modified_by": "Administrator",
 "module": "Selling",
 "name": "Selling Onboarding",
@@ -37,5 +37,5 @@
   "step": "Review Selling Settings"
  }
 ],
- "title": "Selling Setup!"
+ "title": "Selling Setup"
 }
--- a/erpnext/selling/onboarding_step/create_customer/create_customer.json
+++ b/erpnext/selling/onboarding_step/create_customer/create_customer.json
@@ -5,7 +5,7 @@
 "docstatus": 0,
 "doctype": "Onboarding Step",
 "form_tour": "Customer Form Tour",
- "idx": 0,
+ "idx": 1,
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
--- a/erpnext/selling/onboarding_step/create_item/create_item.json
+++ b/erpnext/selling/onboarding_step/create_item/create_item.json
@@ -4,11 +4,11 @@
 "creation": "2026-02-19 12:38:40.865013",
 "docstatus": 0,
 "doctype": "Onboarding Step",
- "idx": 7,
+ "idx": 8,
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-24 16:57:14.098288",
+ "modified": "2026-02-25 16:58:56.384284",
 "modified_by": "Administrator",
 "name": "Create Item",
 "owner": "Administrator",
--- a/erpnext/selling/onboarding_step/setup_company/setup_company.json
+++ b/erpnext/selling/onboarding_step/setup_company/setup_company.json
@@ -1,21 +0,0 @@
-{
- "action": "Go to Page",
- "action_label": "Setup Company",
- "creation": "2026-02-20 11:12:50.373049",
- "docstatus": 0,
- "doctype": "Onboarding Step",
- "idx": 1,
- "is_complete": 0,
- "is_single": 0,
- "is_skipped": 0,
- "modified": "2026-02-20 11:37:46.922137",
- "modified_by": "Administrator",
- "name": "Setup Company",
- "owner": "Administrator",
- "path": "company",
- "reference_document": "Company",
- "show_form_tour": 0,
- "show_full_form": 0,
- "title": "Setup Company",
- "validate_action": 1
-}
--- a/erpnext/stock/module_onboarding/stock_onboarding/stock_onboarding.json
+++ b/erpnext/stock/module_onboarding/stock_onboarding/stock_onboarding.json
@@ -12,7 +12,7 @@
 "doctype": "Module Onboarding",
 "idx": 0,
 "is_complete": 0,
- "modified": "2026-02-23 22:51:17.460108",
+ "modified": "2026-02-25 16:59:45.630766",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Stock Onboarding",
@@ -40,5 +40,5 @@
   "step": "Review Stock Settings"
  }
 ],
- "title": "Stock Setup!"
+ "title": "Stock Setup"
 }
--- a/erpnext/stock/onboarding_step/create_item/create_item.json
+++ b/erpnext/stock/onboarding_step/create_item/create_item.json
@@ -4,11 +4,11 @@
 "creation": "2026-02-19 12:38:40.865013",
 "docstatus": 0,
 "doctype": "Onboarding Step",
- "idx": 7,
+ "idx": 8,
 "is_complete": 0,
 "is_single": 0,
 "is_skipped": 0,
- "modified": "2026-02-23 20:30:37.698459",
+ "modified": "2026-02-25 16:58:56.384284",
 "modified_by": "Administrator",
 "name": "Create Item",
 "owner": "Administrator",
--- a/erpnext/subcontracting/module_onboarding/subcontracting_onboarding/subcontracting_onboarding.json
+++ b/erpnext/subcontracting/module_onboarding/subcontracting_onboarding/subcontracting_onboarding.json
@@ -15,7 +15,7 @@
 "doctype": "Module Onboarding",
 "idx": 1,
 "is_complete": 0,
- "modified": "2026-02-23 22:51:04.595547",
+ "modified": "2026-02-25 16:59:55.409759",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting Onboarding",
@@ -43,5 +43,5 @@
   "step": "Create Subcontracting Order"
  }
 ],
- "title": "Subcontracting Setup!"
+ "title": "Subcontracting Setup"
 }