refactor(test): remove explicit commit and dead code

This commit is contained in:
ruthra kumar
2026-01-28 15:52:07 +05:30
parent 6d86bfe2e3
commit e6885af96b

View File

@@ -1591,79 +1591,3 @@ def get_unique_suffix():
# Used to isolate valuation sensitive
# tests to prevent future tests from failing.
return str(uuid4())[:8].upper()
@classmethod
def setUpClass(cls) -> None:
super().setUpClass()
cls.gle_autoname = frappe.get_meta("GL Entry").autoname
cls.sle_autoname = frappe.get_meta("Stock Ledger Entry").autoname
def setUp(self) -> None:
self.item = make_item().name
self.warehouse = "Stores - TCP1"
self.company = "_Test Company with perpetual inventory"
def tearDown(self) -> None:
make_property_setter(
doctype="GL Entry",
for_doctype=True,
property="autoname",
value=self.gle_autoname,
property_type="Data",
fieldname=None,
)
make_property_setter(
doctype="Stock Ledger Entry",
for_doctype=True,
property="autoname",
value=self.sle_autoname,
property_type="Data",
fieldname=None,
)
# since deferred naming autocommits, commit all changes to avoid flake
frappe.db.commit() # nosemgrep
@staticmethod
def get_gle_sles(se):
filters = {"voucher_type": se.doctype, "voucher_no": se.name}
gle = set(frappe.get_list("GL Entry", filters, pluck="name"))
sle = set(frappe.get_list("Stock Ledger Entry", filters, pluck="name"))
return gle, sle
def test_deferred_naming(self):
se = make_stock_entry(
item_code=self.item, to_warehouse=self.warehouse, qty=10, rate=100, company=self.company
)
gle, sle = self.get_gle_sles(se)
rename_gle_sle_docs()
renamed_gle, renamed_sle = self.get_gle_sles(se)
self.assertFalse(gle & renamed_gle, msg="GLEs not renamed")
self.assertFalse(sle & renamed_sle, msg="SLEs not renamed")
se.cancel()
def test_hash_naming(self):
# disable naming series
for doctype in ("GL Entry", "Stock Ledger Entry"):
make_property_setter(
doctype=doctype,
for_doctype=True,
property="autoname",
value="hash",
property_type="Data",
fieldname=None,
)
se = make_stock_entry(
item_code=self.item, to_warehouse=self.warehouse, qty=10, rate=100, company=self.company
)
gle, sle = self.get_gle_sles(se)
rename_gle_sle_docs()
renamed_gle, renamed_sle = self.get_gle_sles(se)
self.assertEqual(gle, renamed_gle, msg="GLEs are renamed while using hash naming")
self.assertEqual(sle, renamed_sle, msg="SLEs are renamed while using hash naming")
se.cancel()