ruthra kumar
075a7dfe2e
chore: code cleanup
...
(cherry picked from commit cd42b26839 )
2023-08-14 04:51:41 +00:00
ruthra kumar
86aead3d45
refactor: remove call for setting deductions in payment entry
...
(cherry picked from commit 1bcb728c85 )
# Conflicts:
# erpnext/accounts/utils.py
2023-08-14 04:51:40 +00:00
ruthra kumar
e20b213737
refactor(test): difference amount no updated for exchange gain/loss
...
(cherry picked from commit 72bc5b3a11 )
# Conflicts:
# erpnext/accounts/test/test_utils.py
2023-08-14 04:51:40 +00:00
ruthra kumar
4025442491
refactor(test): exc gain/loss journal for advance in purchase invoice
...
(cherry picked from commit 5b06bd1af4 )
2023-08-14 04:51:40 +00:00
ruthra kumar
f6bb6b78db
refactor: only post on base currency for exchange gain/loss
...
(cherry picked from commit 78bc712756 )
2023-08-14 04:51:40 +00:00
ruthra kumar
00a26ea6e6
refactor(test): payment will have same exch rate - no gain/loss
...
while making payment entry using reference to sales/purchase invoice,
it herits the parent docs exchange rate. so, there will be no exchange
gain/loss
(cherry picked from commit ee2d1fa36e )
2023-08-14 04:51:39 +00:00
ruthra kumar
e2c35f8c85
refactor(test): assert Exc journal when reconciling Journa to invoic
...
(cherry picked from commit 389cadf157 )
2023-08-14 04:51:39 +00:00
ruthra kumar
72e88d22ed
chore: remove debugging statements and fixing failing unit tests
...
(cherry picked from commit ee3ce82ea8 )
2023-08-14 04:51:39 +00:00
ruthra kumar
220bf24555
refactor: exc booking logic for Journal Entry
...
(cherry picked from commit 7b516f8463 )
2023-08-14 04:51:39 +00:00
ruthra kumar
1f76dde025
refactor(test): exc gain/loss booked through journal
...
(cherry picked from commit 00a2e42a47 )
2023-08-14 04:51:38 +00:00
ruthra kumar
59b7e96255
refactor: assert exchange gain/loss amount in reference table
...
(cherry picked from commit 4ff53e1062 )
2023-08-14 04:51:38 +00:00
ruthra kumar
d030f4a100
refactor: remove unused variable, pe should pull in parent exc rate
...
1. 'reference_doc' variable is never set. Hence, removing.
2. set_exchange_rate() relies on ref_doc, which was never
set due to point [1]. Replacing it with 'doc'.
3. Sales/Purchase Invoice has 'conversion_rate' field for tracking
exchange rate. Added a get statement for them as well.
(cherry picked from commit 92ae9c2201 )
2023-08-14 04:51:38 +00:00
ruthra kumar
6c6acef78e
refactor: helper method
...
(cherry picked from commit c1184585ed )
2023-08-14 04:51:38 +00:00
ruthra kumar
a9da619903
chore: fix logic for purchase invoice and some typos
...
(cherry picked from commit 34b5e849a2 )
2023-08-14 04:51:38 +00:00
ruthra kumar
72005bdb39
refactor: add new reference type in journal entry account
...
(cherry picked from commit 13febcac81 )
2023-08-14 04:51:38 +00:00
ruthra kumar
287af687cf
chore: patch to update property setter for Journal Entry Accounts
...
(cherry picked from commit 0587338435 )
2023-08-14 04:51:37 +00:00
ruthra kumar
db46987d4b
refactor: replace with new method in purchase invoice
...
(cherry picked from commit 7e94a1c51b )
2023-08-14 04:51:37 +00:00
ruthra kumar
44110860b4
test: different scenarios for exchange booking
...
(cherry picked from commit 5e1cd1f227 )
2023-08-14 04:51:37 +00:00
ruthra kumar
c06a6bfc09
refactor: book exchange gain/loss through journal
...
(cherry picked from commit 81cd7873d3 )
2023-08-14 04:51:37 +00:00
mergify[bot]
ac0fff7e94
fix: AR/AP report based on payment terms ( #36574 )
...
fix: AR/AP report based on payment terms (#36574 )
* fix: AR/AP report based on payment terms
* fix: AR/AP report based on payment terms
(cherry picked from commit fbb5058531 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-08-14 09:46:41 +05:30
mergify[bot]
3044f46c52
fix: wrong currency on financial-statement based reports ( #36524 )
...
fix: wrong currency on financial-statement based reports (#36524 )
* add missing field options on financial_statement Total field
* format financial statement code
(cherry picked from commit ce25f9e8c9 )
Co-authored-by: Naufal Afif <naufalafif58@gmail.com >
2023-08-13 17:11:47 +05:30
Deepesh Garg
0a832bc979
Merge pull request #36609 from frappe/mergify/bp/version-14-hotfix/pr-36564
...
fix: Make default sales update frequency as monthly instead of each transaction (#36564 )
2023-08-13 13:20:27 +05:30
Deepesh Garg
e5bc888798
Merge pull request #36614 from deepeshgarg007/loan_repayment_cancel_v14
...
fix: Allow backdated repayment cancels for term loans
2023-08-13 11:57:49 +05:30
ruthra kumar
9172985a9b
Merge pull request #36621 from frappe/mergify/bp/version-14-hotfix/pr-36309
...
fix: allocation validation blocks partial payment for SO and PO (backport #36309 )
2023-08-13 11:39:27 +05:30
Deepesh Garg
a3032910a7
chore: resolve conflicts
2023-08-13 11:37:40 +05:30
ruthra kumar
ce08f038d2
fix: validation blocks partial payment for SO and PO
...
(cherry picked from commit cb2bfabb6f )
2023-08-13 10:58:55 +05:30
ruthra kumar
df632d7ecb
Merge pull request #36620 from frappe/mergify/bp/version-14-hotfix/pr-36590
...
fix: disallow mulitple SO with same Purchase Order No if not enabled in Settings (backport #36590 )
2023-08-13 08:48:27 +05:30
ruthra kumar
1693905703
Merge pull request #36619 from frappe/mergify/bp/version-14-hotfix/pr-36593
...
chore: update permissions for Process Payment Reconciliation (backport #36593 )
2023-08-13 08:43:00 +05:30
ruthra kumar
21d3fb0625
chore: resolve merge conflict
2023-08-13 08:24:01 +05:30
ruthra kumar
c83f10f638
refactor(test): don't set po_no by default
...
(cherry picked from commit 64614cd915 )
# Conflicts:
# erpnext/stock/doctype/delivery_note/test_delivery_note.py
2023-08-13 02:40:42 +00:00
ruthra kumar
b901cfdbe2
fix: disallow mulitple SO with same PO No
...
(cherry picked from commit dbd3fdbb41 )
2023-08-13 02:40:42 +00:00
ruthra kumar
cbcdf30840
chore: update permissions for Process Payment Reconciliation
...
(cherry picked from commit cd28d15292 )
2023-08-13 02:40:38 +00:00
mergify[bot]
8b13185c25
fix: fetch Stock UOM from Item if not set (backport #36606 ) ( #36617 )
...
fix: fetch `Stock UOM` from Item if not set (#36606 )
(cherry picked from commit 539cfd08f0 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-08-12 23:25:05 +05:30
Deepesh Garg
1377cf4cf1
fix: Allow backdated repayment cancels for term loans
2023-08-12 20:01:04 +05:30
Deepesh Garg
4ca1f3b9cf
fix: Make default sales update frequency as monthly instead of each transaction
...
(cherry picked from commit 32863b4922 )
# Conflicts:
# erpnext/selling/doctype/selling_settings/selling_settings.json
2023-08-11 17:10:07 +00:00
Deepesh Garg
347c67a0f1
Merge pull request #36608 from frappe/mergify/bp/version-14-hotfix/pr-36582
...
fix: Group Account total not showing in Financial Statements (#36582 )
2023-08-11 22:33:35 +05:30
Deepesh Garg
2912648151
fix: Group Account total not showing in Financial Statements
...
(cherry picked from commit baf5cddd1b )
2023-08-11 16:27:53 +00:00
mergify[bot]
63c061e5e8
fix: wrap none type rate under flt (backport #36602 ) ( #36604 )
...
fix: wrap none type rate under flt (#36602 )
(cherry picked from commit 627986efa1 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-08-11 12:55:25 +00:00
mergify[bot]
96663d7e28
chore: set default filter dates if missing (backport #36597 ) ( #36598 )
...
chore: set default filter dates if missing (#36597 )
(cherry picked from commit 98e82e0d99 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-08-11 09:19:14 +00:00
rohitwaghchaure
ee04c6d5c5
fix: allow negative stock condition for batch item ( #36586 )
...
* fix: allow negative stock condition for batch item
* fix: test case
2023-08-11 13:57:27 +05:30
ruthra kumar
5488785fd8
Merge pull request #36579 from frappe/mergify/bp/version-14-hotfix/pr-36573
...
refactor: 'is system generated' field and better remarks in Journal Entry (backport #36573 )
2023-08-11 09:43:53 +05:30
ruthra kumar
25ac0ce1cc
Merge pull request #36580 from frappe/mergify/bp/version-14-hotfix/pr-36578
...
fix: unhide `uom` and `stock_uom` fields in print view (backport #36578 )
2023-08-11 09:16:07 +05:30
ruthra kumar
727a379581
chore: remove unwanted 'Reversal of ITC' and merge conflicts
2023-08-11 09:12:11 +05:30
Anand Baburajan
29181274c8
feat: daily asset depreciation method ( #36587 )
...
* feat: daily asset depreciation method
* chore: hide depr schedule if no schedules
2023-08-10 22:47:16 +05:30
rohitwaghchaure
2800ad39d2
fix: incorrect available qty for backdated stock reco with batch ( #36581 )
2023-08-10 17:22:14 +05:30
ruthra kumar
b49309c160
fix: unhide uom and stock_uom fields in print view
...
(cherry picked from commit 11cd163db7 )
2023-08-10 10:18:36 +00:00
ruthra kumar
a04471024d
refactor: enable 'no-copy'
...
(cherry picked from commit 4ed4b0240d )
2023-08-10 10:09:26 +00:00
ruthra kumar
9b0d30c56b
refactor: set flag display condition
...
(cherry picked from commit de17eaef38 )
2023-08-10 10:09:25 +00:00
ruthra kumar
00c7dbceaa
refactor: add is_system_generated field to Journal Entry
...
(cherry picked from commit 3997aa77d4 )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
2023-08-10 10:09:25 +00:00
ruthra kumar
5443592d84
fix: better remarks on Cr note created by Reconciliation
...
(cherry picked from commit 47cb349362 )
# Conflicts:
# erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
2023-08-10 10:09:25 +00:00