rohitwaghchaure
409cc95b7b
Merge pull request #27158 from rohitwaghchaure/merge-branch-hotfix-to-pre-release-for-13-10
...
chore: merge version-13-hotfix into version-13-pre-release for release v13.10.0
2021-08-26 17:39:58 +05:30
Rohit Waghchaure
327be1cd9d
chore: merge version-13-hotfix into version-13-pre-release for release v13.10.0
2021-08-26 11:45:55 +05:30
Frappe PR Bot
6609321399
fix: removing toggle_display for address and contact HTML ( #27152 ) ( #27155 )
...
(cherry picked from commit c8f22e5524 )
Co-authored-by: Anupam Kumar <anupamvns0099@gmail.com >
2021-08-26 11:02:01 +05:30
Frappe PR Bot
7f27586cbe
fix(healthcare): Removed ignore user permissions flag in appointment ( #27146 )
...
* fix(healthcare): Removed ignore user permissions flag in appointment (#27129 )
(cherry picked from commit 81b28b8998 )
# Conflicts:
# erpnext/healthcare/doctype/patient_appointment/test_patient_appointment.py
* chore: Fix merge conflicts
Co-authored-by: Chillar Anand <anand21nanda@gmail.com >
2021-08-25 22:26:09 +05:30
Frappe PR Bot
4837d8872e
fix: unable to create manual / auto asset depreciation entry when cost_center is mandatory ( #26912 ) ( #27149 )
...
Summary : unable to create manual / auto asset depreciation entry when cost_center is mandatory
Reason: Though we are calculating value for depreciation_cost_center, it is not passed in credit_entry(it is passed in debit_entry) and this prevents creation of manual / auto asset depreciation entry when cost_center is mandatory
Solution : pass already calculated depreciation_cost_center value in credit_entry (in line with, already done as in debit_entry)
(cherry picked from commit b99c011947 )
Co-authored-by: Ashish Shah <mr.ashish.shah@gmail.com >
2021-08-25 22:25:29 +05:30
Nabin Hait
014df08e7b
Merge branch 'alyf-de-datev_more_info' into version-13-hotfix
2021-08-25 21:23:45 +05:30
Nabin Hait
09fb90b8ac
fix: merge conflict
2021-08-25 21:23:24 +05:30
Dany Robert
7b9a23eb7a
feat: Increase number of supported currency exchanges ( #26763 )
...
* fix: update test suite to accodomate new currency exchange function
* feat: Increase number of supported currency exchanges
* fix: don't make api call when testing
* remove condition for test(being fixed in another pull request)
2021-08-25 21:15:44 +05:30
Frappe PR Bot
0fe6995816
fix: sequence of sub-operations in job card ( #27138 ) ( #27147 )
...
(cherry picked from commit ad45ddcabe )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2021-08-25 20:11:23 +05:30
Frappe PR Bot
f8ec0b6a86
feat: provision to create customer from opportunity ( #27145 )
...
* feat: provision to create customer from opportunity (#27141 )
* feat: provision to create customer from opportunity
* fead: linking of address and contact
* revert: create_opportunity_address_contact
* enabming print hide and no copy
(cherry picked from commit 4d98be2126 )
# Conflicts:
# erpnext/crm/doctype/opportunity/opportunity.js
* Update opportunity.js
* fix: conflicts
Co-authored-by: Anupam Kumar <anupamvns0099@gmail.com >
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-08-25 20:05:54 +05:30
Frappe PR Bot
4c3034ad79
fix: remove VARCHARs from Sales Invoice ( #27136 ) ( #27139 )
...
Sales Invoice doctype is starting to hit row length limit as many
integrations add custom fields on this doctype. This is just a small
change to remove VARCHAR(140) fields and reduce row size wherever
possible.
(cherry picked from commit 8d116fb9ff )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-08-25 17:47:51 +05:30
Alan
1be810479c
refactor: update stock module onboarding ( #25745 )
...
* refactor: update stock onboarding
* refactor: add form tour for stock module onboarding
* refactor: move trailing whitespace out of translate func
* refactor: sider/semgrep
* refactor: remove DN, PR; change wording, add/remove steps in tour
* refactor: add watch video step for stock opening balance
* refactor: reorder steps according to stock settings refactor
* refactor: fix typo, remove target warehouse cause SE Type dependency
* fix: semgrep, remove trailing and leading whitespaces
* refactor: reduce steps, reword cards
* fix: minor changes
- remove Is Group from warehouse
- change stock entry type
- link to stock entry type
- add posting date to stock reco
- change report to Stock Projected Qty
- highlight quality inspection action
- remove allow neg highlight
* refactor: use Form Tour doc instead of controller form tour
note - keeping controller form tours as a fallback, new form tours
seem to work only for Stock Settings
* fix: rename form tours to doctype names, remove tours from js controllers
* fix: re-order tour to circumvent glitchy save highlight
2021-08-25 17:45:55 +05:30
Frappe PR Bot
d97a87e28d
fix(healthcare): Made payment fields mandatory for new appointments ( #27135 )
...
* fix(healthcare): Made payment fields mandatory for new appointments (#26608 )
* fix(healthcare): Made payment fields mandatory for new appointments
* fix: sider issues
* fix: Fix failing test
* fix: Patient appointment invoicing
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
Co-authored-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in >
(cherry picked from commit a65498dc61 )
# Conflicts:
# erpnext/healthcare/doctype/patient_appointment/patient_appointment.json
# erpnext/healthcare/doctype/patient_appointment/test_patient_appointment.py
* chore: Fix merge conflicts
* chore: Fix failing tests
Co-authored-by: Chillar Anand <anand21nanda@gmail.com >
2021-08-25 17:12:04 +05:30
Frappe PR Bot
7ac4916191
feat: unreconcile on cancellation of bank transaction ( #27109 ) ( #27137 )
2021-08-25 16:59:03 +05:30
Deepesh Garg
4eb7c2a011
fix: TDS calculation on net total ( #27058 )
2021-08-25 16:54:45 +05:30
Frappe PR Bot
fcb17f047d
fix: validate party and party type only if both available ( #27002 ) ( #27133 )
...
* fix: validate party and party type only if both available
* fix: indentation
(cherry picked from commit 8366b6322e )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-25 12:49:04 +05:30
Marica
688fe4192c
Merge pull request #27118 from 18alantom/fix-scrap-items-updation-bp
...
fix: update scrap table item details; typo (backport #27052 )
2021-08-25 12:36:14 +05:30
rohitwaghchaure
2b875bbf52
Merge pull request #27127 from rohitwaghchaure/v13-fixed-stock-ledger-report-with-included-uom
...
fix: stock ledger report not working if include uom selected in filter
2021-08-25 01:24:53 +05:30
Rohit Waghchaure
1810b73113
fix: stock ledger report not working if include uom selected in filter
2021-08-25 01:24:02 +05:30
rohitwaghchaure
2ea108ae92
Merge pull request #27126 from rohitwaghchaure/fixed-donot-overrride-batch-no-v13
...
fix: selected batch no changed on updation of qty
2021-08-25 01:23:10 +05:30
Rohit Waghchaure
2f71b740fd
fix: selected batch no changed on updation of qty
2021-08-25 01:22:04 +05:30
Frappe PR Bot
5b411dc1f6
fix: Updated timestamp for pos invoice json ( #27110 ) ( #27123 )
...
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
(cherry picked from commit fbc5977248 )
Co-authored-by: Subin Tom <36098155+nemesis189@users.noreply.github.com >
2021-08-24 23:18:35 +05:30
Frappe PR Bot
f13ae4de0b
fix: broken URL in supplier portal ( #26823 ) ( #27122 )
...
* fix: broken URL
The quotations are supplier quotations, not sales quotation.
* fix: remove erpnext from path
(cherry picked from commit c7bad657b1 )
Co-authored-by: Dany Robert <rtdany10@gmail.com >
2021-08-24 22:28:29 +05:30
Frappe PR Bot
b3ffa0eb57
fix(minor): Update GSTR-1 json version ( #27074 ) ( #27121 )
...
(cherry picked from commit c30fb04e96 )
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
2021-08-24 22:28:07 +05:30
Anuja Pawar
8220117500
feat(regional): South Africa VAT Audit Report ( #27017 )
...
* feat: SA VAT Report
* fix: added party column and fixed permissions
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2021-08-24 22:02:05 +05:30
Deepesh Garg
74073ddc85
fix: Ignore due date validations if payment terms are copied from orders/receipts ( #27120 )
2021-08-24 21:56:49 +05:30
Frappe PR Bot
8474961b79
perf: reduce number of queries to validate selling price ( #26225 ) ( #27119 )
...
* perf: reduce number of queries to validate selling price
* fix: improved flow and formatting
* fix: improve condition and use of `as_dict`
Co-authored-by: Sagar Vora <sagar@resilient.tech >
(cherry picked from commit 7c957d72b3 )
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com >
2021-08-24 21:51:53 +05:30
Nabin Hait
487952a04e
Merge branch 'version-13-hotfix' into fix-scrap-items-updation-bp
2021-08-24 21:08:14 +05:30
Frappe PR Bot
c7508a034a
feat: allow draft pos invoices even if no stock available ( #27078 ) ( #27106 )
...
(cherry picked from commit f47cbae5e0 )
Co-authored-by: Saqib <nextchamp.saqib@gmail.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-24 20:51:30 +05:30
18alantom
38898d33c6
fix: update scrap table item details; typo
2021-08-24 20:39:51 +05:30
Frappe PR Bot
0bf9d1b29f
fix: pos invoice test ( #27116 )
2021-08-24 19:48:05 +05:30
Frappe PR Bot
a7cdba24bc
feat: coupon code discount in pos invoice ( #27103 )
2021-08-24 19:47:40 +05:30
Saqib
f84740e6e4
fix: incorrect gl entry on period closing involving finance books ( #27104 )
2021-08-24 19:46:35 +05:30
Mohammad Hussain Nagaria
24b2a31581
feat: Employee reminders ( #25735 )
...
* feat: Add reminders section to HR Settings
* refactor: Extract generic function for getting Employees
* feat: Employee Work Anniversary Reminder
* feat: Daily Holiday Reminder
* fix: Unnecessary params and replace [] with .get()
* test: Daily Holiday Reminders
* test: is_holiday basic tests
* refactor: Move employee reminders code to separate module
* feat: Add advance reminder to HR settings
* feat: Advance Holiday Reminders
* refactor: get_holidays_for_employee
* feat: Email holiday reminders in advance + tests
* fix: Remove unused import
* refactor: HR Setting Reminder Section
* refactor: Remove Daily Holiday Reminders feat
* feat: Reminder miss warning
* fix: Failing test and function name change
* chore: Add patch for field rename
* chore: Rename frequency label
* fix: Failing patch test
* fix: sider and removed description of fields
* fix: email alignment
Co-authored-by: pateljannat <pateljannat2308@gmail.com >
Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com >
2021-08-24 19:43:43 +05:30
Anupam Kumar
f7e0edecc9
refactor: social media post fixes ( #24664 )
...
* fix: social media post fixes
* feat: post metrics and some fixes
* fix: sider issues
* fix: sider issue
* fix: reverting optional chaning statements
* fix: sider issues
* fix: review chnages
* fix: text trigger check
* fix: sider issue
2021-08-24 19:15:56 +05:30
Frappe PR Bot
d55d200b47
fix: calculation of gross profit percentage in Gross Profit Report ( #27108 )
2021-08-24 18:58:56 +05:30
Frappe PR Bot
c8092b7e7a
fix: correct price list rate value in return si ( #27105 )
2021-08-24 18:41:16 +05:30
Syed Mujeer Hashmi
1604b6cc63
fix: Allow backdated discharge for inpatient ( #25124 )
...
* fix: Allow backdated discharge for inpatient
The system is not flexible enough to allow backdated patient discharge.
Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in >
* fix: Sider issues and test cases related to this patch
Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in >
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com >
2021-08-24 18:35:59 +05:30
Rucha Mahabal
27fad29ad6
refactor: Healthcare Redesign Changes ( #27100 )
...
* chore: reorder workspace cards
* fix: Patient Progress Page UI
* feat: redesign Patient History
* fix: redesign patient history card
* fix: filter style
* fix: sider
* fix: patient history and patient progress links
* fix: change percentage/donut charts to bar charts
-percentage charts broken in redesign
* fix(style): patient progress heatmap
* chore: semgrep and translation fixes
* fix: patient progress page card views
* fix: tests
2021-08-24 17:54:28 +05:30
Deepesh Garg
0476accf26
fix: Payment Reconciliation link in Accounting Workspace ( #27085 )
2021-08-24 16:27:10 +05:30
Sagar Vora
925a4a28e2
Merge pull request #27092 from frappe-pr-bot/backport/version-13-hotfix/27008
...
refactor: use `read_only_depends_on` instead of code
2021-08-24 13:33:19 +05:30
Afshan
ac0800511d
fix: resolved conflicts
2021-08-24 12:59:07 +05:30
Afshan
d360819384
Merge branch 'version-13-hotfix' into backport/version-13-hotfix/27008
2021-08-24 12:53:13 +05:30
Marica
ff6cda8547
Merge pull request #27096 from frappe-pr-bot/backport/version-13-hotfix/27043
...
fix(ux): keep stock entry title & purpose in sync
2021-08-24 12:46:31 +05:30
rohitwaghchaure
60c06d3194
Merge pull request #26455 from noahjacob/supplier_defaults_v13hf
...
feat: fetching details from supplier/customer groups
2021-08-24 12:31:01 +05:30
rohitwaghchaure
5320f3e5ea
Merge branch 'version-13-hotfix' into supplier_defaults_v13hf
2021-08-24 12:28:16 +05:30
Ankush Menat
cc7ed1573a
fix(ux): keep stock entry title & purpose in sync ( #27043 )
...
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
(cherry picked from commit c09d8a2809 )
2021-08-24 06:55:25 +00:00
Marica
b932b3f252
Merge pull request #27093 from frappe-pr-bot/backport/version-13-hotfix/27014
...
fix: stock analytics report date range issues and add company filter
2021-08-24 12:21:43 +05:30
Frappe PR Bot
1e3a6a8a98
fix: discard empty rows from update items ( #27021 ) ( #27095 )
...
(cherry picked from commit 6de7b8ea93 )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-08-24 12:20:51 +05:30
Ankush Menat
0a23328151
fix: stock analytics report date range issues and add company filter ( #27014 )
...
* test: tests for correct get_period_date_ranges
* fix: stock analytics report date range issues
- Upon selecting second half of month with Monthly filter, data from
that period was missing.
- Solution: "round down" the date as per expected frequency.
* chore: drop py2 and fix misleading docstring
* test: fix test to avoid FY clash
* feat: add company filter in stock analytics report
[skip ci]
Co-authored-by: Marica <maricadsouza221197@gmail.com >
(cherry picked from commit 0dff0beaba )
2021-08-24 06:47:49 +00:00